Received: by 2002:a25:1506:0:0:0:0:0 with SMTP id 6csp2097982ybv; Fri, 14 Feb 2020 11:24:37 -0800 (PST) X-Google-Smtp-Source: APXvYqzi9jvBAnfTmBpuMy0FmLTc3ty6XsIfRfHkV7TJewtjRaAxC2aWMEYng3ohPhNMh2uJ2Mnj X-Received: by 2002:a05:6830:15c2:: with SMTP id j2mr3309451otr.351.1581708277496; Fri, 14 Feb 2020 11:24:37 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1581708277; cv=none; d=google.com; s=arc-20160816; b=nKBVhKRwaSbE1wgX1ZlqmLRLjbygvcpLMgGQVXQ+D7janrgNlIccTBfY9jmIEQO+V8 mqZP3qtEzMnIJ1ht/mc1g3VmuYqi60PUJR9DlRVuvPdoqthH63GwOAX0askEtT68H2SG Pm1buBeb8fWpp9WzYTAShdYSlRJE0xu+bUXV1+LJnc95TxTIhVEq1a9P0tM3o8pzRU+W z8J0HWLOV2eXj456zVfPSH95vunG4+8VbaSvdeW1vMBQkiPtqVF/PsRLSBSrxK9KZk6W Rok/6AHbF8I0oO9wRii0ev6I6szTQfmxw59mIbufdLCtfT7yzqr/hqTvppUMV7WA7ShD mVsA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=Ha43rM3KNl2ywTmmquarsRVleo66vDOJWPO8lRx+MyE=; b=v2O1nR00+0+Xq8rH2pPd+9GZz5fsoZpK2CbAe2mDTZFX16b+unT04hWZT4LDt2i5mp 5bzB6X/NSH1NL2ZquVJFIdb1yBJcSkDpJknEAqko/MmEffHN7m9cRMu+afFjULIh9DYS 6x9UL0PhAOTnFpQDF/v5nvg1TpQ4vtpYhbqe42GkT5T3PRx7pR0skTRIh4vXimgr8AkB ECnAScK/mLSZ9Kg9AU+qeUNPEKToMHcqslGOh9G8Avt2gsMX2IIQgWLGnqN0lmuKjAys C1hRioehmJbHrCaSBFI0zD4YNV6OV6cIe/gfb0UsC4iAdEjBC1+HrxJP0Ken3ltrPXMk NxGw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ziepe.ca header.s=google header.b=aqGNfI4a; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id r6si3341751otq.95.2020.02.14.11.24.24; Fri, 14 Feb 2020 11:24:37 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@ziepe.ca header.s=google header.b=aqGNfI4a; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387603AbgBNTYP (ORCPT + 99 others); Fri, 14 Feb 2020 14:24:15 -0500 Received: from mail-qt1-f196.google.com ([209.85.160.196]:43824 "EHLO mail-qt1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729542AbgBNTYO (ORCPT ); Fri, 14 Feb 2020 14:24:14 -0500 Received: by mail-qt1-f196.google.com with SMTP id d18so7713587qtj.10 for ; Fri, 14 Feb 2020 11:24:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=Ha43rM3KNl2ywTmmquarsRVleo66vDOJWPO8lRx+MyE=; b=aqGNfI4aJe6xDeKXsjDHuhKN9r+mjkz/Rst3N5oxOuWvENMfU9cGCfvUBhz8S+Kb8Z cHLKkkZ5Qh7lQo5mHL05Lh1s8w24MZx53if6/eOzvv9nVn493wbVZeebMd3KSvdOgagl 2DBQgZjfupeuiQh4RqLF5ipSNH3I3cDNM8d+OvM9XIEnNIShIkQHrPLGTjQLyThumlJK CIf4biddyc8fOzHgf5d84F0YCqoX+1I3Zrmcq4ai/wc/qEnandR7j8j3eutDqZO0K1Hb KskAziz6xoiiJJwaym5T4gK5l4L4KwX2BalnxcEz/1hbQx6lApRZlGlumjDKwtgDJX8g 19YQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=Ha43rM3KNl2ywTmmquarsRVleo66vDOJWPO8lRx+MyE=; b=aKf3JSi18hkwTe6cDtJNKjJT+bVAGVQNjQ9OxJbs8926LydR2S+abEBzrKdgMGwJoD uAwmo7brn/tQnWZn3A5DFZmVApMfglDANFPXP0R/OcFIazka55wwYGvu5J5gNeHVHQOm MavTFP0VXrR6MBagflfOxONtBCKH8jrOdibEbXzWu/ZW+OYS+I/BJEsAcuUif/fKkHiO gK954pvzt0dt9MfsSWrYJzYEx/GCqZGgg73AHiJUb44dhh+LLJf1iK/9cDKc8yc46n0z qDYAGvMy6XNIaDRXvJStZ9Kk5HnZGlrug934BrYhYeqPx1Ri3qSfm4LKGXbm3EJeUpkG buJQ== X-Gm-Message-State: APjAAAXXM1xI7JYs4HASEJJZA8QreKmyrCZcQC6kRA5dD4N1y+liCCvM SBw9m2Bzo5PcUON3DBLpHNmrog== X-Received: by 2002:ac8:4a16:: with SMTP id x22mr3825965qtq.339.1581708252247; Fri, 14 Feb 2020 11:24:12 -0800 (PST) Received: from ziepe.ca (hlfxns017vw-142-68-57-212.dhcp-dynamic.fibreop.ns.bellaliant.net. [142.68.57.212]) by smtp.gmail.com with ESMTPSA id q6sm3726913qkm.46.2020.02.14.11.24.10 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 14 Feb 2020 11:24:10 -0800 (PST) Received: from jgg by mlx.ziepe.ca with local (Exim 4.90_1) (envelope-from ) id 1j2gZO-0000bY-GB; Fri, 14 Feb 2020 15:24:10 -0400 Date: Fri, 14 Feb 2020 15:24:10 -0400 From: Jason Gunthorpe To: Alexander Lobakin Cc: Leon Romanovsky , Doug Ledford , Yishai Hadas , Maxim Mikityanskiy , linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH rdma] IB/mlx5: Fix linkage failure on 32-bit arches Message-ID: <20200214192410.GW31668@ziepe.ca> References: <20200214191309.155654-1-alobakin@dlink.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200214191309.155654-1-alobakin@dlink.ru> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Feb 14, 2020 at 10:13:09PM +0300, Alexander Lobakin wrote: > Commit f164be8c0366 ("IB/mlx5: Extend caps stage to handle VAR > capabilities") introduced a straight "/" division of the u64 > variable "bar_size", which emits an __udivdi3() libgcc call on > 32-bit arches and certain GCC versions: > > error: "__udivdi3" [drivers/infiniband/hw/mlx5/mlx5_ib.ko] undefined! [1] > > Replace it with the corresponding div_u64() call. > Compile-tested on ARCH=mips 32r2el_defconfig BOARDS=ocelot. > > [1] https://lore.kernel.org/linux-mips/CAMuHMdXM9S1VkFMZ8eDAyZR6EE4WkJY215Lcn2qdOaPeadF+EQ@mail.gmail.com/ > > Fixes: f164be8c0366 ("IB/mlx5: Extend caps stage to handle VAR > capabilities") > Signed-off-by: Alexander Lobakin > --- > drivers/infiniband/hw/mlx5/main.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) Randy beat you too it.. https://lore.kernel.org/linux-rdma/20200206143201.GF25297@ziepe.ca/ But it seems patchwork missed this somehow. Applied now at least Jason