Received: by 2002:a25:1506:0:0:0:0:0 with SMTP id 6csp2166782ybv; Fri, 14 Feb 2020 12:50:12 -0800 (PST) X-Google-Smtp-Source: APXvYqwyyyp4+0Y2hN2C8iOX9gKGa3N5uU9RbsgVbErnNsupDwJW6ZCNUFLSb0X4exYkgMUcsA8T X-Received: by 2002:aca:ad11:: with SMTP id w17mr3254300oie.85.1581713411962; Fri, 14 Feb 2020 12:50:11 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1581713411; cv=none; d=google.com; s=arc-20160816; b=WwUd2pREdTmfnGqokg5Ljt6lqZjRvyXmnN2Jg7Y2i7hbrPncZRj/jxAtpZety2gzAc 9fabpagK1DuhLT/CIMfSb7tJPENeOaADlJPihpGxMZ/Ge53IDa7MKxcW4VtNTs0fmwGu j1ziT95JF9XJDcmSkBd5GhRedD82dHOvG5kUUy+/W7C7EbPwIsnv9Ohn2d2/BDPPQ8s6 /gNW2fbbKZ+D2a53wKXdvW/GSYAb4I6WcwrG5QgrthwYM6WcVy1acMqd98DIRgccm1zi brh0NaXy5ifX6KrumegD40+98bnvBpufdApeKpksR50ypbf29sJwvaf40sOnB5w6LoP3 nEBQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=cFc8PKAJJ5VAeO0nmRlDEGv7dk9E8dGhNfk7CB3NGUU=; b=VR0e1Yilgc/98gzcZC19dg0SHVEPjnaWVHEwX7cHKZfnq9287NGh+LgWjzF5xAbC3J u8Bxc2XvCIV5czIRSh8sSNhmqt/5oyDL1dNs+NuS6qUY1EevS4sU7xXXRL1SEZSNHhyv rx/zSOmmtuGtXdRQcMOgSDgjWT2EAc3YjRDKH8kW5LQIT46nDt39i/J1foyKaXSvCOyU lhREUFMj8+F17EhPwI932QbXR9klDRb6pAKxWla8mFo1WKAYYFhr6P/VPpMuT0XyE/JE BOAL9lkZEUEA+I+gGdutKUTVpMrbX++gpT3u0TOi2K7vl2gV50DL8Mm/7+A2G6bbFwnd +XBw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=YX+mqKG9; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id q6si3965801otg.248.2020.02.14.12.50.00; Fri, 14 Feb 2020 12:50:11 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=YX+mqKG9; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389594AbgBNUte (ORCPT + 99 others); Fri, 14 Feb 2020 15:49:34 -0500 Received: from mail-wr1-f68.google.com ([209.85.221.68]:42439 "EHLO mail-wr1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389029AbgBNUtG (ORCPT ); Fri, 14 Feb 2020 15:49:06 -0500 Received: by mail-wr1-f68.google.com with SMTP id k11so12452559wrd.9; Fri, 14 Feb 2020 12:49:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=cFc8PKAJJ5VAeO0nmRlDEGv7dk9E8dGhNfk7CB3NGUU=; b=YX+mqKG9mNGRcsGMGcNEKbXt9zOda190gqOQKhJIjbyvdOyACGNGtDV9WTacdTyPy4 zuLwZxHWpmw36B3ElZ4kskcj7MKflXisP5ilzgjv9UrR6Q3IUjeFE5PVEhrCiQCZNktx KGuYOUIntkaf3U90SaajiycN+cPvusAoWC1Shx/gI66VkWD38jnKShuOVGrnSE4zVQ08 B4KCaS0/bF5SdAbMPDY7Xv9r5RWk+XMFUUv+eCil90LIO8DOBdZm3c1TBn6Y4RHUjc// 8DRQgT+WzbDLxwAPvO4PmyZzaYmJigiO2ZS0287DSzLNlsTXhCpO7p8t4Ai+p/fHf38o VBfQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=cFc8PKAJJ5VAeO0nmRlDEGv7dk9E8dGhNfk7CB3NGUU=; b=oBREP/4eJcPMTgYFHQMOvW2jb9gG9PiI+DExSA92swb1EDwGLLut8CgQhWEp88dkAk SH94HS7eqCTgybCdDSXApSDU7hxwON7J7yPGckY8sdXRb8KSmNEss28PeviBf/7sDXBw Q0VTnGn0YfvyuX+17U/uk7enU5rf0kQMQdMaAh5t7qaMEJo8+0JXtToqRuTgvosA1eEU WZ7mlMP7g3c8dPJto1gEZKNt1hLVPrACt/wAkFGYF4az7m6AnKPXpIMOh2oScqQui2A9 AA+qsdZh3BTCYyhYkrztuuawZ76jpRn3ecWF8+QmrLma1zxEBWJde8LByMVRuFoUEsuL /gHw== X-Gm-Message-State: APjAAAVfOArlP5W73QzPKzvyEhLXccO9q0Lsw1n99mktiYpF4sGgs/ue T9wbziuCkjMuHssfN2bX304TrCjtALh2 X-Received: by 2002:adf:df0f:: with SMTP id y15mr5738077wrl.26.1581713344463; Fri, 14 Feb 2020 12:49:04 -0800 (PST) Received: from ninjahost.lan (host-2-102-13-223.as13285.net. [2.102.13.223]) by smtp.googlemail.com with ESMTPSA id y12sm8660782wmj.6.2020.02.14.12.49.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 14 Feb 2020 12:49:04 -0800 (PST) From: Jules Irenge To: linux-kernel@vger.kernel.org Cc: boqun.feng@gmail.com, Jules Irenge , Jon Maloy , Ying Xue , "David S. Miller" , Jakub Kicinski , netdev@vger.kernel.org (open list:TIPC NETWORK LAYER), tipc-discussion@lists.sourceforge.net (open list:TIPC NETWORK LAYER) Subject: [PATCH 28/30] tipc: Add missing annotation for tipc_node_write_unlock() Date: Fri, 14 Feb 2020 20:47:39 +0000 Message-Id: <20200214204741.94112-29-jbi.octave@gmail.com> X-Mailer: git-send-email 2.24.1 In-Reply-To: <20200214204741.94112-1-jbi.octave@gmail.com> References: <0/30> <20200214204741.94112-1-jbi.octave@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Sparse reports a warning at tipc_node_write_unlock() warning: context imbalance in tipc_node_write_unlock - unexpected unlock The root cause is the missing annotation at tipc_node_write_unlock() Add the missing __releases(&n->lock) annotation Signed-off-by: Jules Irenge --- net/tipc/node.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/tipc/node.c b/net/tipc/node.c index cc656b2205db..c3b810427d24 100644 --- a/net/tipc/node.c +++ b/net/tipc/node.c @@ -372,7 +372,7 @@ static void tipc_node_write_unlock_fast(struct tipc_node *n) write_unlock_bh(&n->lock); } -static void tipc_node_write_unlock(struct tipc_node *n) +static void tipc_node_write_unlock(struct tipc_node *n) __releases(&n->lock) { struct net *net = n->net; u32 addr = 0; -- 2.24.1