Received: by 2002:a25:1506:0:0:0:0:0 with SMTP id 6csp2167092ybv; Fri, 14 Feb 2020 12:50:34 -0800 (PST) X-Google-Smtp-Source: APXvYqxizvaA84i4PO7S/nxY/vPjagFd5CbfTZPSrpujY2ec/58weFN1nE7hlSXfvl2z1xIySQHF X-Received: by 2002:a9d:2ae5:: with SMTP id e92mr3795444otb.72.1581713434593; Fri, 14 Feb 2020 12:50:34 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1581713434; cv=none; d=google.com; s=arc-20160816; b=Ixzs4SWyR0gvgcRoMHCT1mUgjrhKeJSklwc9kkXYnV5JCVb9ZoZPC6eQQS+37AyomG noZD6K6RwTSIbslSXIYN050cMfMrsY/z071zcCJpM3wzZPiUxmiRnO+DwhWKlVnYBQxf d/EQ1LA470wEAG4wnoLYOY2zB1BEB/D5gh8xKbYERYI8tYlF3T1FCTRRz/MAj6p9yaR0 XwIZzG8dIKpGVK43UXRhuSmrdVeN8hCfDjEQ1aG47jdRmhbCMoOHghI1jx0+EhiMGKtH 2V6HIqDi8sRuJE51t0gBK8Pmbr9+7epWC59VmrP8CMB3ZzbEZP8TvRlX0eZ8g3nylsyp pLvg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=GovDwGSGIzG2rCMfZqhL482njrRJvSxaatNaopkmVCo=; b=dTaG+hNm0/MwQGOReqbKzneWP/7qAnM2Ml00cFuKAeGs9VN1Kg+91U9baof+CLlcFf h4M9tUkgsjDBNUuFlwgz/Xvjz0DwLEvfUBw3+DLwc3p8nlPtvFUAGkKix7wBqf5hkI4S j6qAxPu8c0fUrVChjwvyl5EWoTfUippu/BBSnzrGXyfoR9CEAM6d/v7pbL2qnhc7NX9g +O4+PRoTXcNUzPUJDwbxk7FHYNcf7Wx8d6SN0xZnOSdvP7YeSNwZK1YAGZUeDED9UYK7 Hd6/iCXVdLQl/I7dBRa+9aVuogoSDi7ODeiOR3vxonyNmT9OX4F6iTwyIsndjve9dJXf SMSA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=sz6ZBGi0; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id z206si3455341oia.142.2020.02.14.12.50.22; Fri, 14 Feb 2020 12:50:34 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=sz6ZBGi0; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389724AbgBNUtv (ORCPT + 99 others); Fri, 14 Feb 2020 15:49:51 -0500 Received: from mail-wr1-f65.google.com ([209.85.221.65]:32913 "EHLO mail-wr1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388816AbgBNUtC (ORCPT ); Fri, 14 Feb 2020 15:49:02 -0500 Received: by mail-wr1-f65.google.com with SMTP id u6so12514062wrt.0; Fri, 14 Feb 2020 12:49:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=GovDwGSGIzG2rCMfZqhL482njrRJvSxaatNaopkmVCo=; b=sz6ZBGi0oZSsy/wtLxkE8rOdKw1g2xsCm3CJe2becCd/G6DHi7qEQxt2zEROlGeet3 k+iqhz2xbQglNhOr8OVbLvfx2JGA1qq6IvwmQ/3J4CaXSHaaKK1ENM2HcMb/6cmMGVC5 ffW70Vr6sVt7fhMvDes0FeDZueSPyErRG/1nyhc6CkyPYqEGH6eE1lADHsLBZk1746Nv TrsjEZ8aD1TLZVe2jwRMZ/HobYZIXlB6ctBXE33DvWjmQnXtPYGEl2d+hdLmScjVbwXq vructeZzSjQQN2WiZxrcXu2tmHZLMIonSBIUBB2F64k35C59s1IttoCdRYi8JWNvFZpK CczA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=GovDwGSGIzG2rCMfZqhL482njrRJvSxaatNaopkmVCo=; b=aBox9/j130Syl9ziNk7geHuFx5vEDMFAYE+eLShoRIeeAvF556huOIdxWWywEmjCbT 9hZ+TP7xWRUcO2Mbg5PZfG0N4zkOjEh9Ogi+lPolsjaWTzIHubtwmHCxlxdbNpUNj1U9 toS7p+M6Fq88RN8GvRMlEhUlqtl+GgNlBOIkfSQAAukDNFC7jV7iCSBkib1FUlxXrf6T EBVA2eQ04EhOihxq+rhL5i8c2od1YCuHZrwqxu7AAFufNqmedff62zGMnqn5cDMbGxge qISX6gMA33Au2//1MQAHFsGOHm0MvYxbWRVJkfFdIIg0zpQhZg1siZlxPzostWLp3YhN +TlQ== X-Gm-Message-State: APjAAAVFPd1QVBE+bEgsDiNjamA25pzOIR4BWfJIB0H7CaD4Lk+uz4Jv P3jO3w2CYqMW6mjMWxqOjoHJonbAiSiL X-Received: by 2002:a5d:4709:: with SMTP id y9mr5814590wrq.412.1581713340279; Fri, 14 Feb 2020 12:49:00 -0800 (PST) Received: from ninjahost.lan (host-2-102-13-223.as13285.net. [2.102.13.223]) by smtp.googlemail.com with ESMTPSA id y12sm8660782wmj.6.2020.02.14.12.48.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 14 Feb 2020 12:48:59 -0800 (PST) From: Jules Irenge To: linux-kernel@vger.kernel.org Cc: boqun.feng@gmail.com, Jules Irenge , Jon Maloy , Ying Xue , "David S. Miller" , Jakub Kicinski , netdev@vger.kernel.org (open list:TIPC NETWORK LAYER), tipc-discussion@lists.sourceforge.net (open list:TIPC NETWORK LAYER) Subject: [PATCH 24/30] tipc: Add missing annotation for tipc_node_read_lock() Date: Fri, 14 Feb 2020 20:47:35 +0000 Message-Id: <20200214204741.94112-25-jbi.octave@gmail.com> X-Mailer: git-send-email 2.24.1 In-Reply-To: <20200214204741.94112-1-jbi.octave@gmail.com> References: <0/30> <20200214204741.94112-1-jbi.octave@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Sparse reports a warning at tipc_node_read_lock() warning: context imbalance in tipc_node_read_lock - wrong count at exit The root cause is the missing annotation at tipc_node_read_lock() Add the missing __acquires(&n->lock) annotattion Signed-off-by: Jules Irenge --- net/tipc/node.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/tipc/node.c b/net/tipc/node.c index 99b28b69fc17..4e267ed94a2a 100644 --- a/net/tipc/node.c +++ b/net/tipc/node.c @@ -351,7 +351,7 @@ static struct tipc_node *tipc_node_find_by_id(struct net *net, u8 *id) return found ? n : NULL; } -static void tipc_node_read_lock(struct tipc_node *n) +static void tipc_node_read_lock(struct tipc_node *n) __acquires(&n->lock) { read_lock_bh(&n->lock); } -- 2.24.1