Received: by 2002:a25:1506:0:0:0:0:0 with SMTP id 6csp2167496ybv; Fri, 14 Feb 2020 12:51:07 -0800 (PST) X-Google-Smtp-Source: APXvYqw6kQDNECWaiV5nvppOGnAAlzsfUExbIhmd3ojG+awu3TqZ2KA+7DSdz0263LalzHb6Ntjj X-Received: by 2002:a9d:75da:: with SMTP id c26mr3807530otl.40.1581713467482; Fri, 14 Feb 2020 12:51:07 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1581713467; cv=none; d=google.com; s=arc-20160816; b=N7MMNavSMR5BFWOpwY4YQh0Y5FyRAgL+mQU72GxtDh3CMKqrixySPojzBsX5WZ3jCq N1OW0ShsjpnKe4jgj+amj6/I3H4T6gAjIyTJYWDyBvI7M/Zyy8Peq/BYiHJhgFqwh37B ls9Y/cjTSVvRrmLhLQ1qTRADqqgoXdhYM91BJvqXLgeY3WuyaxMUsIzmVblmH5YYeH+X /edobvum3qjDEyFSB7TXMSkRhQ3UbbGjxSVGcSPnDy8B9UWCjt4I1S8wjZmI2o0qJKNn 4a8xOLwVGPoUtz+4JsK5fKKO/N8jfCxtnLWGXYKqpfIgkKW4c9SDCn9HO5YJjYZhx+DY 9NfA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=xuZKU7LjmXWLYQI/wtTpyWHlvqjYehwlyKEt0Tnztc4=; b=j8g/YANT9q5KPEOULO369adVcqJu8ugXw4OqTDcWPwWUVcy2Rx6wtFSrJZlX8k+t2q RbhSZBAkgV6oRs7/ZBkUO0QKcYVKRHmff3wXmX3QvJeVbr0jSsQzgdbFOk8dTHzqNQJq 6Y2UOjGECkN9LliSPBA3NjPef0YxLBKR2Jluq/6MmxHwxUpdlKk4rmSaAjRKi34/3/Nh 3q9kEdZOM7NoIxtdva4LDfT/FiQX9sK40qHftRX5uFki5Gem02qtkQjV1q6mmEUazvbm WAWXducTJn3R+TMlgIvVKWrH7n+cG7kJ2LnSxMPUJH9o+F6YKRWT32JKrYROcoNJ3eA0 /M3A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=fn8INV2O; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id x11si3240169otp.285.2020.02.14.12.50.55; Fri, 14 Feb 2020 12:51:07 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=fn8INV2O; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388784AbgBNUtA (ORCPT + 99 others); Fri, 14 Feb 2020 15:49:00 -0500 Received: from mail-wr1-f65.google.com ([209.85.221.65]:40968 "EHLO mail-wr1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388432AbgBNUsx (ORCPT ); Fri, 14 Feb 2020 15:48:53 -0500 Received: by mail-wr1-f65.google.com with SMTP id c9so12475511wrw.8 for ; Fri, 14 Feb 2020 12:48:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=xuZKU7LjmXWLYQI/wtTpyWHlvqjYehwlyKEt0Tnztc4=; b=fn8INV2ODKBl+bG/dtdZOpRB8nT5T8itpwEPSR0z27GWAYSVu1s+fYw6/0zv6k28a7 tZA1dQbPfL+m+lO91btmj/u7dynyGdCwSnCvJ6+L7Wn/iOsXg9yvIeQZfugEaozwGMTO KNZBDqjYZRrPr750JIsMLiNvYlkEVSA84TRMO81Pt4ZsxlLYmJqsVtjCfqQem1Pgc1k1 3wBvXxOcpBiOssy1gzPJBOv/0wJnOwPaT2qXfFT+RUHATT+PpHmZ6Ph1APJVHDn/tlez QUAKymRjOEDOppyFluLHU1/65qetfcs2joTiF8+4zhypXrOaqvzVmpx1LmoAg1IS/X/K bd0Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=xuZKU7LjmXWLYQI/wtTpyWHlvqjYehwlyKEt0Tnztc4=; b=ZKi7NTbX9keVH8oAy+a0GBbl3YkmPhCYsqsIb+A8MHHG6e6LaKTgPaJIFy/e7UpnCG 0UPvoytCXyaaQu/ws1Fg6NNveYwMTlsyoA6solZIi829Jgs08b4PGXMGQj/JJ7ZR9BzD SbSNstY8bpx7+EH6bVHnjUZNPgXzr9507kLB6iF8FFjmWoikddOEcEHS+yFXE/a3FDcY Ou0HN8Jiqk605goo9Y9JWTOLQINQDv1tJuDI15OvJ9493ldzFMFzs3SgVfQLpCbkjDxK kxB2+lNwma5VPrbD5PVlwf1NouiGuKuq5ywFpGROmXbxSRLRwT+kqrEyHKNCGAy6FPet 9wVA== X-Gm-Message-State: APjAAAVT7X+H/nWrl2wzkXUl4mb/Qa9fLAEufwDUsqnBXE0vfDNsxYbP Mwki8OirUF0rGGbCFgeHaZ5ICNGrjWKD X-Received: by 2002:a5d:4b88:: with SMTP id b8mr5775564wrt.343.1581713330706; Fri, 14 Feb 2020 12:48:50 -0800 (PST) Received: from ninjahost.lan (host-2-102-13-223.as13285.net. [2.102.13.223]) by smtp.googlemail.com with ESMTPSA id y12sm8660782wmj.6.2020.02.14.12.48.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 14 Feb 2020 12:48:50 -0800 (PST) From: Jules Irenge To: linux-kernel@vger.kernel.org Cc: boqun.feng@gmail.com, Jules Irenge , Boris Ostrovsky , Juergen Gross , Stefano Stabellini , Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H. Peter Anvin" , x86@kernel.org (maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)), xen-devel@lists.xenproject.org (moderated list:XEN HYPERVISOR INTERFACE) Subject: [PATCH 15/30] x86/xen: Add missing annotation for xen_pte_unlock() Date: Fri, 14 Feb 2020 20:47:26 +0000 Message-Id: <20200214204741.94112-16-jbi.octave@gmail.com> X-Mailer: git-send-email 2.24.1 In-Reply-To: <20200214204741.94112-1-jbi.octave@gmail.com> References: <0/30> <20200214204741.94112-1-jbi.octave@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Sparse reports warning at xen_pte_unlock() warning: context imbalance in xen_pte_unlock() - unexpected unlock The root cause is the missing annotation at xen_pte_unlock() Add the missing __releases(ptl) annotation Signed-off-by: Jules Irenge --- arch/x86/xen/mmu_pv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/x86/xen/mmu_pv.c b/arch/x86/xen/mmu_pv.c index 352f0c80cfcf..777008f8c668 100644 --- a/arch/x86/xen/mmu_pv.c +++ b/arch/x86/xen/mmu_pv.c @@ -707,7 +707,7 @@ static spinlock_t *xen_pte_lock(struct page *page, struct mm_struct *mm) return ptl; } -static void xen_pte_unlock(void *v) +static void xen_pte_unlock(void *v) __releases(ptl) { spinlock_t *ptl = v; spin_unlock(ptl); -- 2.24.1