Received: by 2002:a25:1506:0:0:0:0:0 with SMTP id 6csp2168502ybv; Fri, 14 Feb 2020 12:52:42 -0800 (PST) X-Google-Smtp-Source: APXvYqx5CmOoU1cmnrONPrHDIZilqVSXJENqCTl9ni/tsQhlbkQSRefxHvco9r0dDDH1sj+82Oe5 X-Received: by 2002:a05:6830:1555:: with SMTP id l21mr3564561otp.41.1581713561938; Fri, 14 Feb 2020 12:52:41 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1581713561; cv=none; d=google.com; s=arc-20160816; b=l6EiT5rm2ayYG+NwJ7daCknz/Q8519XwiAel9zO/X/YHXvv+NrlyUDywa1Lw3uD2vB LGFIog4ZJy7QHNXutgm6qbsJS4KGkUyhyVdEAXZSNmgrtWmxn3AAu8fzHMYE42jlilte yVDJBjj93PSFFpUKC5j62Pu8uZR8UpkqdWMKwbdU2V295CA3X2l8B86cPgV1ChWmgwoF EoOpGakjFiKWj12Vn/5+7ZSPcRz6KZlu+mlcZ8roAvkwIw5UdOgvwf8VFz+ZroWR5t0y iDLto1A4nQw9BLzWd+MpW5u5Mcilc9aB9q5ls/p9oBPee4Jr1JQzDv2FjaKTBvSdGtVE xNGw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=zbKpGMSoVKA6ipuIlX/H9vVMKswet6nu7tSTBdHVCw8=; b=CGMxRwzn9F4FimA6/eZVcBHDtJJgy6EZ6GptpeFXI6jVZw7uWYKwO6CtGKMDUQ62CB df7Ezy8wVioj4dyJwG0kRxxwMgm/tWVUGwxPZv/Ur7UXKGMNdZvhKEdB49w+epNjTlub +fCsyNFWwWkj8mus8+1vq1myOrEwoNXbcTqJwAjuw4g22U0wMnLprjm+RVHD7WItjpxe liFJH8+TJZAhWa6SlLh+i8AKlQo7LjDvdysg9Ox8kgH0mXZ2/Zh/aji5xWoBuo3SW6Ib SEMp2goRuBpgAlepUeeQSbQejTFXGlPhIjAFql4iEPUvrtllVmR9wp8oIvOnT6cFFs5Y SIQQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=oZeJR0XK; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d3si2980249oia.236.2020.02.14.12.52.28; Fri, 14 Feb 2020 12:52:41 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=oZeJR0XK; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388053AbgBNUso (ORCPT + 99 others); Fri, 14 Feb 2020 15:48:44 -0500 Received: from mail-wr1-f65.google.com ([209.85.221.65]:42401 "EHLO mail-wr1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387607AbgBNUsn (ORCPT ); Fri, 14 Feb 2020 15:48:43 -0500 Received: by mail-wr1-f65.google.com with SMTP id k11so12451691wrd.9 for ; Fri, 14 Feb 2020 12:48:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=zbKpGMSoVKA6ipuIlX/H9vVMKswet6nu7tSTBdHVCw8=; b=oZeJR0XKxsoiCnEdTnBkwNVH6KmYLfcqU7z64jO6jr7N3n52TyE4Cq4oK7pVw/o2sQ 06VwqKCHMrca6/WQZRQG2fwZioTw7mqPXoqdiKQ3xQDiUEPKVOVPjoHtc9Sns9TJphH+ bmqSY9OQ+hOShC1PmmM3lzsOgqyDUcbxP2zxYpWJyvdZ1Mj2HWJ5kF0HoBdYGXL3zC3q DdeOqTHCghWARj+ZeXcQLv/CHlO/QQ2OaP14+Lu7Xky6BokK1Fi8eWBsjQlKdNx69ndM dQrQKBBqA9YBpLHuGN1mJczWIVDKZOTCxZdZIoX/6zMawKiL0DLOky+BWTcijCzVXe/d 6fIA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=zbKpGMSoVKA6ipuIlX/H9vVMKswet6nu7tSTBdHVCw8=; b=uLlQuOKEDxHhFTkCEwOr+sLn++6tbSXbo8ewP++CMu/oHKNBiFCu1PfE9RR1s4TODw Jm3i+CbG0ofPCj01FUbWLl7hCtD2wfWJJNR71V61k4AR4Vngp8I5S8BQSbXNSWm6jDQa yX5Jmm9iISuBwlnaR4h36JnMzZRVwhKv9a17H1SeVWLYev+4lbUSDLGeZbRLEBTYekCE DSNZUKseGg9ygxNIq5rh3FEhrAdQdN9o8uuv5infGdNzcSE/29cm1vFi3uOW1muVuQBv 4R1npNk95h9Ij7agR767nmjSqDQE1N8cfXZ6J+Hjm4tPMtnd/WClqf8ZPQvB5fZxUFiu tS1g== X-Gm-Message-State: APjAAAUr86fTDKXpGTi+wr/WBbZL13TlIce6S0u9svnaQLWuippdCVJg Zp97tAShqav7oI8YVVhq6DVpKCimaFn1 X-Received: by 2002:adf:ed8e:: with SMTP id c14mr5840055wro.80.1581713322047; Fri, 14 Feb 2020 12:48:42 -0800 (PST) Received: from ninjahost.lan (host-2-102-13-223.as13285.net. [2.102.13.223]) by smtp.googlemail.com with ESMTPSA id y12sm8660782wmj.6.2020.02.14.12.48.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 14 Feb 2020 12:48:41 -0800 (PST) From: Jules Irenge To: linux-kernel@vger.kernel.org Cc: boqun.feng@gmail.com, Jules Irenge , Andrew Morton , linux-mm@kvack.org (open list:MEMORY MANAGEMENT) Subject: [PATCH 07/30] mm/mempolicy: Add missing annotation for queue_pages_pmd() Date: Fri, 14 Feb 2020 20:47:18 +0000 Message-Id: <20200214204741.94112-8-jbi.octave@gmail.com> X-Mailer: git-send-email 2.24.1 In-Reply-To: <20200214204741.94112-1-jbi.octave@gmail.com> References: <0/30> <20200214204741.94112-1-jbi.octave@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Sparse reports a warning at queue_pages_pmd() context imbalance in queue_pages_pmd() - unexpected unlock The root cause is the missing annotation at queue_pages_pmd() Add the missing __releases(ptl) Signed-off-by: Jules Irenge --- mm/mempolicy.c | 1 + 1 file changed, 1 insertion(+) diff --git a/mm/mempolicy.c b/mm/mempolicy.c index 977c641f78cf..bb0755228150 100644 --- a/mm/mempolicy.c +++ b/mm/mempolicy.c @@ -442,6 +442,7 @@ static inline bool queue_pages_required(struct page *page, */ static int queue_pages_pmd(pmd_t *pmd, spinlock_t *ptl, unsigned long addr, unsigned long end, struct mm_walk *walk) + __releases(ptl) { int ret = 0; struct page *page; -- 2.24.1