Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Sat, 15 Feb 2020 08:46:20 +0800
From:   Kevin Hao <haokexin@gmail.com>
To:     Sasha Levin <sashal@kernel.org>
Cc:     linux-kernel@vger.kernel.org, stable@vger.kernel.org,
        kbuild test robot <lkp@intel.com>,
        Linus Walleij <linus.walleij@linaro.org>,
        linux-gpio@vger.kernel.org
Subject: Re: [PATCH AUTOSEL 5.4 332/459] gpio: Fix the no return statement
 warning
Message-ID: <20200215004620.GB499724@pek-khao-d2.corp.ad.wrs.com>
References: <20200214160149.11681-1-sashal@kernel.org>
 <20200214160149.11681-332-sashal@kernel.org>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="5I6of5zJg18YgZEa"
Content-Disposition: inline
In-Reply-To: <20200214160149.11681-332-sashal@kernel.org>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


--5I6of5zJg18YgZEa
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, Feb 14, 2020 at 10:59:42AM -0500, Sasha Levin wrote:
> From: Kevin Hao <haokexin@gmail.com>
>=20
> [ Upstream commit 9c6722d85e92233082da2b3623685bba54d6093e ]
>=20
> In commit 242587616710 ("gpiolib: Add support for the irqdomain which
> doesn't use irq_fwspec as arg") we have changed the return type of
> gpiochip_populate_parent_fwspec_twocell/fourcell() from void to void *,
> but forgot to add a return statement for these two dummy functions.
> Add "return NULL" to fix the build warnings.
>=20
> Reported-by: kbuild test robot <lkp@intel.com>
> Signed-off-by: Kevin Hao <haokexin@gmail.com>
> Link: https://lore.kernel.org/r/20200116095003.30324-1-haokexin@gmail.com
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> Signed-off-by: Sasha Levin <sashal@kernel.org>
> ---
>  include/linux/gpio/driver.h | 2 ++
>  1 file changed, 2 insertions(+)
>=20
> diff --git a/include/linux/gpio/driver.h b/include/linux/gpio/driver.h
> index 5dd9c982e2cbe..d7dc2b425532e 100644
> --- a/include/linux/gpio/driver.h
> +++ b/include/linux/gpio/driver.h
> @@ -545,6 +545,7 @@ static inline void gpiochip_populate_parent_fwspec_tw=
ocell(struct gpio_chip *chi
>  						    unsigned int parent_hwirq,
>  						    unsigned int parent_type)
>  {
> +	return NULL;

Hi Sasha,

This commit shouldn't go to the v5.4.x kernel. This is a fix for the=20
commit 242587616710, but that commit doesn't exist in the v5.4.x kernel,
then it will trigger a build warning due to the wrong returning type.      =
                                                                           =
                                       =20

Thanks,
Kevin
>  }
> =20
>  static inline void gpiochip_populate_parent_fwspec_fourcell(struct gpio_=
chip *chip,
> @@ -552,6 +553,7 @@ static inline void gpiochip_populate_parent_fwspec_fo=
urcell(struct gpio_chip *ch
>  						     unsigned int parent_hwirq,
>  						     unsigned int parent_type)
>  {
> +	return NULL;
>  }
> =20
>  #endif /* CONFIG_IRQ_DOMAIN_HIERARCHY */
> --=20
> 2.20.1
>=20

--5I6of5zJg18YgZEa
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCAAdFiEEHc6qFoLCZqgJD98Zk1jtMN6usXEFAl5HP1wACgkQk1jtMN6u
sXFjBAf9HJVjCr0SihI4ekE3g+yTdTEkNc3DNI0tCJMgjjEB5Jai7YvCWDsxRWpQ
w1Ibx5b8foGIRc1NUsBBYrblvNG1n53JFWYLtamZiBFBPaMLH0Q/krVSBBFkcFgv
92SU//b78eYlh+RQx4w/8ty+wA6J2WiJJywqCXeb0ie+lXm1n54v7U4Q3UMN3g8F
BdzZ+/LpRH4rdnwNNJGoiNboKhjSyFN6WF2BYyPpqJ1WlixxKX9vz24K67ulqBP1
dDnuzi+3XblIoVo/Qzoa/eK60mG3MC4SzLLD8VEGs0Kh8vi4amVW5SG/TepkQC19
XeY2/Gu6tNvm1C993bSGGTzPE+YeXA==
=M8Oq
-----END PGP SIGNATURE-----

--5I6of5zJg18YgZEa--