Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Sun, 16 Feb 2020 21:03:33 +0900
From:   Masami Hiramatsu <mhiramat@kernel.org>
To:     Qiujun Huang <hqjagain@gmail.com>
Cc:     akpm@linux-foundation.org, mhiramat@kernel.org,
        rostedt@goodmis.org, keescook@chromium.org, rppt@linux.ibm.com,
        linux@dominikbrodowski.net, nivedita@alum.mit.edu,
        nadav.amit@gmail.com, glider@google.com,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] init/main.c: mark boot_config_checksum static
Message-Id: <20200216210333.b5e911feafb3acfae4a1b89b@kernel.org>
In-Reply-To: <1581852511-14163-1-git-send-email-hqjagain@gmail.com>
References: <1581852511-14163-1-git-send-email-hqjagain@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Sun, 16 Feb 2020 19:28:31 +0800
Qiujun Huang <hqjagain@gmail.com> wrote:

> In fact, this function is only used in this file, so mark it with 'static'.

Good catch!

Acked-by: Masami Hiramatsu <mhiramat@kernel.org>

Thank you!

> 
> Signed-off-by: Qiujun Huang <hqjagain@gmail.com>
> ---
>  init/main.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/init/main.c b/init/main.c
> index f95b014..534589f 100644
> --- a/init/main.c
> +++ b/init/main.c
> @@ -335,7 +335,7 @@ static char * __init xbc_make_cmdline(const char *key)
>  	return new_cmdline;
>  }
>  
> -u32 boot_config_checksum(unsigned char *p, u32 size)
> +static u32 boot_config_checksum(unsigned char *p, u32 size)
>  {
>  	u32 ret = 0;
>  
> -- 
> 1.8.3.1
> 


-- 
Masami Hiramatsu <mhiramat@kernel.org>