Received: by 2002:a25:1506:0:0:0:0:0 with SMTP id 6csp3738461ybv; Sun, 16 Feb 2020 04:41:25 -0800 (PST) X-Google-Smtp-Source: APXvYqx+bYk5h8aPeMOy3QT71w8oXTT5YGka8+1LY41tGUW7QaoAhdo06N8Tpzh0Lr0prkkBGzvE X-Received: by 2002:a9d:7f98:: with SMTP id t24mr9256534otp.338.1581856885412; Sun, 16 Feb 2020 04:41:25 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1581856885; cv=none; d=google.com; s=arc-20160816; b=V6p501r+VALsdiXBbmp4pj/kwmciJIvcllZEfylXfz7H0ClJDreqL0NvHiFd1gUwD4 F/ZHRZnVdIaWL6A11CGBff0PqQHrlIPX9HNhPZ3+uHpLce3z0fgn1L5wJx+MaOIx4XZE xB2e436B01Lwy8GtyXWadZWvgnTiY8kiRFG+sRoZ4e+oDM4sVAyLyQaKVMaozWaiLdXH 4r1MBPqIqUNTEh5jJ1tzjJOh15+KxRHsi84rph9KyBSM3fJ84G4k/B2A7NVivlBnnujZ +fyqIGStzaxd4HDU0u0VPFYKsUIMHL5djvJ+9hw878sjCydtYYPa8EsGhIJAJMAq5VPp 80Ng== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:content-transfer-encoding :mime-version:references:in-reply-to:date:cc:to:from:subject; bh=vcb8DD7v0uRdLQYMgJaxZUzAmU6DHqqp877PSr7ykZU=; b=IF4K2hy9Vjyckgp2x2Pc/H4Cq3AYf/wk76X+5hkxiaI1Z74NeWZ4sGBfH9FIEgSJRB KSWzErFuiRwkUGcvGR+K4CTYyxvxi9iK7kgaxpCHD1S7VnsNhoZaVI/11KfkL8NWGG9q jg2YJlU6s0GLVYkmemR7WTHFIq+Vn6eemI0nf191DAGKnDg5zwKNJZba9A6yh/bdsiKd eLUh7RboiN1432/T1N55q6+ayCxQkj8adlZjiUemtcCDgnrU+ISZdL84q+sSpiJatc/N jqj4eOUEPYsSvH1MjCWJtOg4ENhdAC6x0YEBqENPkEwYOVKMwQzGagnXpCMwNPLeAckK CaAg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id c5si6114643oto.74.2020.02.16.04.41.11; Sun, 16 Feb 2020 04:41:25 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728165AbgBPMkt (ORCPT + 99 others); Sun, 16 Feb 2020 07:40:49 -0500 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:28518 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1728009AbgBPMkt (ORCPT ); Sun, 16 Feb 2020 07:40:49 -0500 Received: from pps.filterd (m0098420.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 01GCY0fv162664 for ; Sun, 16 Feb 2020 07:40:48 -0500 Received: from e06smtp03.uk.ibm.com (e06smtp03.uk.ibm.com [195.75.94.99]) by mx0b-001b2d01.pphosted.com with ESMTP id 2y6dq4vhut-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Sun, 16 Feb 2020 07:40:48 -0500 Received: from localhost by e06smtp03.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Sun, 16 Feb 2020 12:40:46 -0000 Received: from b06cxnps3074.portsmouth.uk.ibm.com (9.149.109.194) by e06smtp03.uk.ibm.com (192.168.101.133) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Sun, 16 Feb 2020 12:40:43 -0000 Received: from d06av26.portsmouth.uk.ibm.com (d06av26.portsmouth.uk.ibm.com [9.149.105.62]) by b06cxnps3074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 01GCeg5n50987206 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sun, 16 Feb 2020 12:40:42 GMT Received: from d06av26.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 2959BAE053; Sun, 16 Feb 2020 12:40:42 +0000 (GMT) Received: from d06av26.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id CB468AE051; Sun, 16 Feb 2020 12:40:40 +0000 (GMT) Received: from localhost.localdomain (unknown [9.85.138.53]) by d06av26.portsmouth.uk.ibm.com (Postfix) with ESMTP; Sun, 16 Feb 2020 12:40:40 +0000 (GMT) Subject: Re: [PATCH v4 0/3] IMA: improve log messages From: Mimi Zohar To: Tushar Sugandhi , joe@perches.com, skhan@linuxfoundation.org, linux-integrity@vger.kernel.org Cc: sashal@kernel.org, nramas@linux.microsoft.com, linux-kernel@vger.kernel.org Date: Sun, 16 Feb 2020 07:40:40 -0500 In-Reply-To: <20200215014709.3006-1-tusharsu@linux.microsoft.com> References: <20200215014709.3006-1-tusharsu@linux.microsoft.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.20.5 (3.20.5-1.fc24) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 x-cbid: 20021612-0012-0000-0000-000003874F80 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 20021612-0013-0000-0000-000021C3D9E3 Message-Id: <1581856840.8515.168.camel@linux.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.138,18.0.572 definitions=2020-02-16_02:2020-02-14,2020-02-16 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 malwarescore=0 priorityscore=1501 lowpriorityscore=0 suspectscore=0 impostorscore=0 spamscore=0 mlxlogscore=921 bulkscore=0 phishscore=0 clxscore=1015 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2001150001 definitions=main-2002160115 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2020-02-14 at 17:47 -0800, Tushar Sugandhi wrote: > The log messages from IMA subsystem should be consistent for better > diagnosability and discoverability. The change isn't limited to IMA. I would change "IMA" to "integrity" in the Subject line and in this patch description. > This patch set improves the logging by removing duplicate log formatting > macros, adding a consistent prefix to the log messages, and adding new > log messages where necessary. Much better! thanks, Mimi