Received: by 2002:a25:1506:0:0:0:0:0 with SMTP id 6csp4041627ybv; Sun, 16 Feb 2020 12:12:14 -0800 (PST) X-Google-Smtp-Source: APXvYqy6Eha62nQ0qAqR4KRfY1DQcxRLyjYZzh7RH5M0AqowwS1gyHhHyzSFFIqyqrVbfiDxsrMQ X-Received: by 2002:a05:6830:4a4:: with SMTP id l4mr9952458otd.91.1581883934180; Sun, 16 Feb 2020 12:12:14 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1581883934; cv=none; d=google.com; s=arc-20160816; b=GTeFj6rBpoyj7F0TbLwpc0nJ/Mq3eZ48GbFCPzvSMnCa14UmJvK4HDgx9BVWV1FIsv dbZhDbqo7U2v2Gs5dadfk70U8js+9UDCRZt/Lid2nUPRGXprBpfTu2hhlLyT+DLqJ7OO +YKvo1u7wW8TksZAznTTgEsWlV0sC25huDuGTQOrQjGfh9NOOqBKtEaam8v1pxf8clIQ 9nw4tSOjUnUBKUwLkvD/aVKdsgdla3KEEbInEmbV5Fo77SweAOgO9+q01vCWns1O2hdx d6T1lIm2Udk5lsKAgnUNlpOwxePmaf5akRVcTWWbEHpKdbOjJPmnePnXEJE8fzHpuntd vfcg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:dkim-signature:content-language :content-transfer-encoding:in-reply-to:mime-version:user-agent:date :message-id:references:cc:to:from:subject; bh=Awt+ihOoct+OrP2HO2ZD3ViOAPVjWWowdplwq9xWlR8=; b=WvBldM8ziEg8c+JhCAlERMuaOdqayMl0mMEknroq+p4nO4onek/WHIWWCUi4WpCxyD BBlDGWTVwOiTPNWdbAxEeXi+M6tIIYGqtPEEQ9bukFzNc92kcmu/KHXvziUKU6+TrOzg LBPmQqWF8cpMyD4vyE7U0wSgIQXC9oAfd01TDjC3Ge6tXVoEeqYcWJhsfuZRmBVZfnz3 MR/lC9AYwaXYokozNRiyk21TT/UTTJUjGdgh9IL6+5LmJmRxw+BxKHm0CT48vFMTBv3f w143mfmRW8QxtQlP8K+DeJAVGcCG4Dr6axd9aLKxM3cjxxcuxiVeJlNqzT/MoJzcZgJK o6GA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@nvidia.com header.s=n1 header.b=VCbEhHeV; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id p19si4755094otq.296.2020.02.16.12.12.02; Sun, 16 Feb 2020 12:12:14 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@nvidia.com header.s=n1 header.b=VCbEhHeV; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727329AbgBPULt (ORCPT + 99 others); Sun, 16 Feb 2020 15:11:49 -0500 Received: from hqnvemgate24.nvidia.com ([216.228.121.143]:14413 "EHLO hqnvemgate24.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726036AbgBPULt (ORCPT ); Sun, 16 Feb 2020 15:11:49 -0500 Received: from hqpgpgate101.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate24.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA) id ; Sun, 16 Feb 2020 12:10:39 -0800 Received: from hqmail.nvidia.com ([172.20.161.6]) by hqpgpgate101.nvidia.com (PGP Universal service); Sun, 16 Feb 2020 12:11:47 -0800 X-PGP-Universal: processed; by hqpgpgate101.nvidia.com on Sun, 16 Feb 2020 12:11:47 -0800 Received: from [10.2.163.245] (10.124.1.5) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Sun, 16 Feb 2020 20:11:46 +0000 Subject: Re: [RFC PATCH v3 4/6] media: tegra: Add Tegra210 Video input driver From: Sowjanya Komatineni To: Hans Verkuil , , , , , CC: , , , , References: <1581704608-31219-1-git-send-email-skomatineni@nvidia.com> <1581704608-31219-5-git-send-email-skomatineni@nvidia.com> <30e417ba-84e1-63d2-de74-22cfe859bddb@xs4all.nl> <920b4276-b2ca-646c-a21b-ca0b9bacf471@nvidia.com> Message-ID: <6bb124db-681c-55c1-e328-6e1f766a8bb3@nvidia.com> Date: Sun, 16 Feb 2020 12:11:53 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <920b4276-b2ca-646c-a21b-ca0b9bacf471@nvidia.com> X-Originating-IP: [10.124.1.5] X-ClientProxiedBy: HQMAIL111.nvidia.com (172.20.187.18) To HQMAIL107.nvidia.com (172.20.187.13) Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: quoted-printable Content-Language: en-US DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1581883839; bh=Awt+ihOoct+OrP2HO2ZD3ViOAPVjWWowdplwq9xWlR8=; h=X-PGP-Universal:Subject:From:To:CC:References:Message-ID:Date: User-Agent:MIME-Version:In-Reply-To:X-Originating-IP: X-ClientProxiedBy:Content-Type:Content-Transfer-Encoding: Content-Language; b=VCbEhHeVDRg/e9ho4DHZ5m/ybIyTH3MMoFSo1A5FijORbs8hX2TKWXDm+YVOmZX0E o+cyzmIr6f9yHvIZ5nqn3vNvtXJTECJVvmcju3BaTfgUcWvXP0JZ480BXKo/AgO3k/ epHUIcF/1pGHxLgQXR75EJjTy176wBrJbiKyfbn1M1zEa0e0OiRSyORO5GoW0QGTsl 4c4xVVmmYMYTBR9kzki4wO+84q/VBCpQQOWvu/lchbmKwcESH75FtDPJdQtfW9898Q ZmhdS/nr/xKm1D4qKq8ITMMz9YU2Z9Dg5tR+4S+2Tbf0xqdxb3fMLcvDhRK9QM5aQ/ kplRBvKKVBOlQ== Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2/16/20 11:54 AM, Sowjanya Komatineni wrote: > > On 2/16/20 3:03 AM, Hans Verkuil wrote: >> External email: Use caution opening links or attachments >> >> >> On 2/14/20 7:23 PM, Sowjanya Komatineni wrote: >>> Tegra210 contains a powerful Video Input (VI) hardware controller >>> which can support up to 6 MIPI CSI camera sensors. >>> >>> Each Tegra CSI port can be one-to-one mapped to VI channel and can >>> capture from an external camera sensor connected to CSI or from >>> built-in test pattern generator. >>> >>> Tegra210 supports built-in test pattern generator from CSI to VI. >>> >>> This patch adds a V4L2 media controller and capture driver support >>> for Tegra210 built-in CSI to VI test pattern generator. >>> >>> Signed-off-by: Sowjanya Komatineni >>> --- >>> =C2=A0 drivers/staging/media/Kconfig=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 |=C2=A0=C2=A0=C2=A0 2 + >>> =C2=A0 drivers/staging/media/Makefile=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 |=C2=A0=C2=A0=C2=A0 1 + >>> =C2=A0 drivers/staging/media/tegra/Kconfig=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0 |=C2=A0=C2=A0 10 + >>> =C2=A0 drivers/staging/media/tegra/Makefile=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0 |=C2=A0=C2=A0=C2=A0 8 + >>> =C2=A0 drivers/staging/media/tegra/TODO=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 |=C2=A0=C2=A0 10 + >>> =C2=A0 drivers/staging/media/tegra/tegra-common.h |=C2=A0 239 +++++++ >>> =C2=A0 drivers/staging/media/tegra/tegra-csi.c=C2=A0=C2=A0=C2=A0 |=C2= =A0 374 ++++++++++ >>> =C2=A0 drivers/staging/media/tegra/tegra-csi.h=C2=A0=C2=A0=C2=A0 |=C2= =A0 115 ++++ >>> =C2=A0 drivers/staging/media/tegra/tegra-vi.c=C2=A0=C2=A0=C2=A0=C2=A0 |= 1019=20 >>> ++++++++++++++++++++++++++++ >>> =C2=A0 drivers/staging/media/tegra/tegra-vi.h=C2=A0=C2=A0=C2=A0=C2=A0 |= =C2=A0=C2=A0 79 +++ >>> =C2=A0 drivers/staging/media/tegra/tegra-video.c=C2=A0 |=C2=A0 118 ++++ >>> =C2=A0 drivers/staging/media/tegra/tegra-video.h=C2=A0 |=C2=A0=C2=A0 32= + >>> =C2=A0 drivers/staging/media/tegra/tegra210.c=C2=A0=C2=A0=C2=A0=C2=A0 |= =C2=A0 767=20 >>> +++++++++++++++++++++ >>> =C2=A0 drivers/staging/media/tegra/tegra210.h=C2=A0=C2=A0=C2=A0=C2=A0 |= =C2=A0 190 ++++++ >>> =C2=A0 14 files changed, 2964 insertions(+) >>> =C2=A0 create mode 100644 drivers/staging/media/tegra/Kconfig >>> =C2=A0 create mode 100644 drivers/staging/media/tegra/Makefile >>> =C2=A0 create mode 100644 drivers/staging/media/tegra/TODO >>> =C2=A0 create mode 100644 drivers/staging/media/tegra/tegra-common.h >>> =C2=A0 create mode 100644 drivers/staging/media/tegra/tegra-csi.c >>> =C2=A0 create mode 100644 drivers/staging/media/tegra/tegra-csi.h >>> =C2=A0 create mode 100644 drivers/staging/media/tegra/tegra-vi.c >>> =C2=A0 create mode 100644 drivers/staging/media/tegra/tegra-vi.h >>> =C2=A0 create mode 100644 drivers/staging/media/tegra/tegra-video.c >>> =C2=A0 create mode 100644 drivers/staging/media/tegra/tegra-video.h >>> =C2=A0 create mode 100644 drivers/staging/media/tegra/tegra210.c >>> =C2=A0 create mode 100644 drivers/staging/media/tegra/tegra210.h >>> >> >> >>> +/* >>> + * videobuf2 queue operations >>> + */ >>> +static int tegra_channel_queue_setup(struct vb2_queue *vq, >>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 unsigned int *nbuffe= rs, >>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 unsigned int *nplane= s, >>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 unsigned int sizes[]= , >>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 struct device *alloc= _devs[]) >>> +{ >>> +=C2=A0=C2=A0=C2=A0=C2=A0 struct tegra_vi_channel *chan =3D vb2_get_drv= _priv(vq); >>> + >>> +=C2=A0=C2=A0=C2=A0=C2=A0 if (*nplanes) >>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0 return sizes[0] < chan->format.sizeimage ? -EINVAL : 0; >>> + >>> +=C2=A0=C2=A0=C2=A0=C2=A0 *nplanes =3D 1; >>> +=C2=A0=C2=A0=C2=A0=C2=A0 sizes[0] =3D chan->format.sizeimage; >>> +=C2=A0=C2=A0=C2=A0=C2=A0 alloc_devs[0] =3D chan->vi->dev; >>> + >>> +=C2=A0=C2=A0=C2=A0=C2=A0 /* >>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 * allocate min 3 buffers in queue to av= oid race between DMA >>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 * writes and userspace reads. >>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 */ >>> +=C2=A0=C2=A0=C2=A0=C2=A0 if (*nbuffers < 3) >>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0 *nbuffers =3D 3; >> First of all, don't check this here, instead set the struct vb2_queue=20 >> field >> 'min_buffers_needed' to 3 instead. >> >> But the reason given for this check is peculiar: there should not be any >> race at all. Usually the reason for requiring a specific minimum=20 >> number of >> buffers is that the DMA engine needs at least 2 buffers before it can=20 >> start >> streaming: it can't give back a buffer to userspace (vb2_buffer_done()) >> unless there is a second buffer it can start to capture to next. So=20 >> for many >> DMA implementations you need a minimum of 2 buffers: two buffers for the >> DMA engine, one buffer being processed by userspace. >> >> If the driver is starved of buffers it will typically keep capturing to >> the last buffer until a new buffer is queued. >> >> In any case, once the driver releases a buffer via vb2_buffer_done() the >> buffer memory is no longer owned by the driver. >> >> To be precise, buffer ownership is as follows: >> >> userspace -> VIDIOC_QBUF -> vb2 -> buf_queue -> driver ->=20 >> vb2_buffer_done() -> vb2 -> VIDIOC_DQBUF -> userspace >> >> (vb2 =3D=3D videobuf2 framework) >> >> Note that vb2 never touches the buffer memory. >> >> So if you get a race condition in this driver, then there is something >> strange going on. It looks like vb2_buffer_done() is called while DMA is >> still ongoing, or because the driver really needs to keep one buffer >> available at all times. >> >> Regards, >> >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 Hans > > Thanks Hans. > > On running v4l2-compliance streaming tests for longer run, I noticed=20 > kernel reporting unable to write to read-only memory and with debugs I=20 > observed when this error was reported, I see 2 buffers queued and both=20 > using same address. > > for first buffer capture start thread initiates capture and wakes done=20 > thread to wait for memory write ack and once its done buffer is=20 > released to user space but I see upon buffer released to user space=20 > immediate next buffer capture single shot gets issued (as soon as=20 > single shot is issued frame capture data is written to memory by DMA)=20 > and I see this kernel error of unable to write to read-only memory. > > This error happens rare and happens on long run and all the times of=20 > repro's, I see when other thread releases buffer immediate I see=20 > single shot gets issued as 2 buffers are queued up at the same time=20 > with same DMA address. > Just to be clear, I meant all the times when kernel reports error unable=20 to write to read-only memory, I see 2 buffers gets queued and as the=20 capture start thread and done thread are parallel and when capture=20 thread wakes done thread on receiving FS event, done thread for waiting=20 for memory write happens parallel to next frame capture and I see while=20 vb2_buffer_done happens in done thread next frame single shot has been=20 issues by capture start thread in parallel when it hits this error. > With using minimum 3 buffers, this issue doesnt happen at all from=20 > almost 72 hours of testing. > > > Will try with setting vb2 queue field min_buffers_needed as 3 instead=20 > of adding check in queue setup. > > >>> + >>> +=C2=A0=C2=A0=C2=A0=C2=A0 return 0; >>> +}