Received: by 2002:a25:1506:0:0:0:0:0 with SMTP id 6csp4272599ybv; Sun, 16 Feb 2020 18:15:07 -0800 (PST) X-Google-Smtp-Source: APXvYqya9n0zSb41UlI9PQtTXP5KkM3kiDUH6D26Mh6rnzyrrx/gVIsZ4F8s+bI+cmpzjJ7VLq6y X-Received: by 2002:a9d:6e98:: with SMTP id a24mr10134357otr.53.1581905707646; Sun, 16 Feb 2020 18:15:07 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1581905707; cv=none; d=google.com; s=arc-20160816; b=Pkhyfsrj7g11z/agd9PVrhawCbLbVIoe4Wvu3mQjJxBKI3g8gdEdLKJOSJEKVgw3AL dricYFEX6G+lLYQaRcBIjAeCFlWZMUBibuaFryOIlJ+YaCQdN7AgdxLgiICGFD3Wqy4S 6Jgjn+gDab6abEv5KvzUIFuMqq2M2F7VBtK7vsd3ng+B9dCtbwe5GjoKxvLnAUy9H0W8 SVeX3d1+shgvUJUUjUSxo93VxNprBzfbzzpWThp3/wbtBnKKs9A4sRXZmFUnu/uB8I7n +NEojR3huxMlD5DXN7A3o7koeOR7vym0xUX52q491uKSm4K5nCuS3u9nBgO0OrcGficd XUyg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:in-reply-to :mime-version:user-agent:date:message-id:from:cc:references:to :subject; bh=RS6TaYOh7+UkJtKWPUb3gqUfu/zeWsy14u/JiUiEozY=; b=VjK/WG/JPVTcwoVhuuly3jwL2WtBThkvaFxbFGhTOS/m0aBEpteY6AUnkPuSRXaLpD uCaDCmDqvehIpmhCJ98llOPkvadeHXKjB6eLB9eLg73vEuCBjVvbtiIAulSp72kpC2qL fzB5UW8rwhxp/4NYsOQJuCrQ/WcOBB1gGyt/MT5Vn47EsS+VjibN9R8/2lX+ZmLdS5G+ xueBHouKHXVi+w9eEWghAOt1+EiCCjUDBClvhT7tgRhipcafBa313X366v/YLMLqWG8f RZTri2h5a1AzYM/U1yW8eZhOtInm2BRyPmWdvCqVHlmWF/3rb1uYHua2xrdW6U7QudIH J0AA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id s7si6500732otd.280.2020.02.16.18.14.42; Sun, 16 Feb 2020 18:15:07 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726485AbgBQCLq (ORCPT + 99 others); Sun, 16 Feb 2020 21:11:46 -0500 Received: from szxga04-in.huawei.com ([45.249.212.190]:10624 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726251AbgBQCLq (ORCPT ); Sun, 16 Feb 2020 21:11:46 -0500 Received: from DGGEMS404-HUB.china.huawei.com (unknown [172.30.72.60]) by Forcepoint Email with ESMTP id BB6A29D15348A178E034; Mon, 17 Feb 2020 10:11:24 +0800 (CST) Received: from [127.0.0.1] (10.133.205.80) by DGGEMS404-HUB.china.huawei.com (10.3.19.204) with Microsoft SMTP Server id 14.3.439.0; Mon, 17 Feb 2020 10:11:23 +0800 Subject: Re: [PATCH for 4.19-stable] padata: fix null pointer deref of pd->pinst To: Sasha Levin , Daniel Jordan References: <20200214182821.337706-1-daniel.m.jordan@oracle.com> <20200215150118.B22262084E@mail.kernel.org> CC: Greg Kroah-Hartman , Herbert Xu , Steffen Klassert , , From: Yang Yingliang Message-ID: <5E49F64A.2070904@huawei.com> Date: Mon, 17 Feb 2020 10:11:22 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <20200215150118.B22262084E@mail.kernel.org> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.133.205.80] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 2020/2/15 23:01, Sasha Levin wrote: > Hi, > > [This is an automated email] > > This commit has been processed because it contains a "Fixes:" tag, > fixing commit: dc34710a7aba ("padata: Remove broken queue flushing"). > > The bot has tested the following trees: v5.5.3, v5.4.19, v4.19.103. > > v5.5.3: Build failed! Errors: > kernel/padata.c:460:4: error: ‘struct parallel_data’ has no member named ‘pinst’ > > v5.4.19: Build failed! Errors: > kernel/padata.c:460:4: error: ‘struct parallel_data’ has no member named ‘pinst’ > > v4.19.103: Build OK! > > NOTE: The patch will not be queued to stable trees until it is upstream. > > How should we proceed with this patch? The commit bbefa1dd6a6d ("crypto: pcrypt - Avoid deadlock by using per-instance padata queues") that merged on linux-5.4.y and linux-5.5.y changes struct parallel_data, so this patch it's only needed on linux-4.19.y. >