Received: by 2002:a25:1506:0:0:0:0:0 with SMTP id 6csp4300643ybv;
        Sun, 16 Feb 2020 18:56:21 -0800 (PST)
X-Google-Smtp-Source: APXvYqx7rwRFEBv38FU//SSfUYRSzKpBtb1VN87rDRCB5gqzkRhkoXUI3Lp9//z++tQDmB8Y0kpe
X-Received: by 2002:a05:6808:8e1:: with SMTP id d1mr8613911oic.68.1581908181173;
        Sun, 16 Feb 2020 18:56:21 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; t=1581908181; cv=none;
        d=google.com; s=arc-20160816;
        b=rnChneLcMvd05mBh/pvsDvRoJfWJpZmRn/oJIhajbqtPNj9EP1SycLhQdUEdSRrvRs
         XXIzt26V3Tjpvh4aOdmmrvbyBnb285m1JnZnElh7e8+wMUG8sucHu14nqQMki0T9tDUR
         w81+g6mxEl1Jp0FZ0P/C19ox0dK4jUyEFBypwK4RHLeE4wDCekEzVO3yvdBRYNNPQmOq
         4fP+g1oDH4pShjnDCaGEbfF5dlfNBY28dKXuJ/UdB+bdDvNbUup/mDNuXXp7xz8RsGzS
         vACq1XVqHnolJrM9OHrTjx0+zQGJ6V50IIMtdpzyca99BkJK+8bWK8JmoYBZ2GhMU3B8
         nXYw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:sender:content-transfer-encoding:mime-version
         :references:in-reply-to:from:subject:cc:to:message-id:date;
        bh=3LUemSfy3CqGZUpwHSvnsGe6UBJNsT+HREXNr1YfUkU=;
        b=JUJKPFyc3lwtg7tG3R1MaXc4h9hfzd6TFmTdZH+Clj8J47ThE9G4Gm0PDQ1QxXrBZA
         z6bCy6SVQj6JGHgwq7NMWTmAmHPhFw8+EaKpdTWSr/GU8F+aGK9pLqf2JwU4Oy4SiV05
         0mz1PfB2Wb89U/fAUMdQQ7BkAzPYJihowVonqolYOwUziIPKBscVYk92PVoH73OkToNj
         7e+Qgz893ABxx+WiQ6FMdTObHhAD4Wgfy07665AirnO48ugsNE9awJOx0LqNRKVLh6jU
         H9vZ4sEwahnV1rMpGhoONfKhKCcJrmM5NP/d1uM22ica6dNplmzk5PxK3S86ZCGMqjbc
         CvXA==
ARC-Authentication-Results: i=1; mx.google.com;
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67])
        by mx.google.com with ESMTP id l65si5735301oih.23.2020.02.16.18.56.07;
        Sun, 16 Feb 2020 18:56:21 -0800 (PST)
Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Authentication-Results: mx.google.com;
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1726786AbgBQC4B (ORCPT <rfc822;patchstalker@gmail.com>
        + 99 others); Sun, 16 Feb 2020 21:56:01 -0500
Received: from shards.monkeyblade.net ([23.128.96.9]:47990 "EHLO
        shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1726498AbgBQC4B (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Sun, 16 Feb 2020 21:56:01 -0500
Received: from localhost (unknown [IPv6:2601:601:9f00:477::3d5])
        (using TLSv1 with cipher AES256-SHA (256/256 bits))
        (Client did not present a certificate)
        (Authenticated sender: davem-davemloft)
        by shards.monkeyblade.net (Postfix) with ESMTPSA id E6806153DF5F0;
        Sun, 16 Feb 2020 18:56:00 -0800 (PST)
Date:   Sun, 16 Feb 2020 18:56:00 -0800 (PST)
Message-Id: <20200216.185600.43507558643527863.davem@davemloft.net>
To:     manivannan.sadhasivam@linaro.org
Cc:     kuba@kernel.org, bjorn.andersson@linaro.org,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] net: qrtr: Migrate nameservice to kernel from
 userspace
From:   David Miller <davem@davemloft.net>
In-Reply-To: <20200213091427.13435-2-manivannan.sadhasivam@linaro.org>
References: <20200213091427.13435-1-manivannan.sadhasivam@linaro.org>
        <20200213091427.13435-2-manivannan.sadhasivam@linaro.org>
X-Mailer: Mew version 6.8 on Emacs 26.1
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Sun, 16 Feb 2020 18:56:01 -0800 (PST)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Date: Thu, 13 Feb 2020 14:44:26 +0530

> +static int service_announce_new(struct sockaddr_qrtr *dest,
> +				struct qrtr_server *srv)
> +{
> +	struct qrtr_ctrl_pkt pkt;
> +	struct msghdr msg = { };
> +	struct kvec iv = { &pkt, sizeof(pkt) };

Please use reverse christmas tree ordering for local variables.

Please fix this for your entire submission.