Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: Linux 5.6-rc2
To:     Linus Torvalds <torvalds@linux-foundation.org>,
        Dave Jones <davej@codemonkey.org.uk>,
        Filipe Manana <fdmanana@suse.com>,
        David Sterba <dsterba@suse.com>
Cc:     Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
References: <CAHk-=wgqwiBLGvwTqU2kJEPNmafPpPe_K0XgBU-A58M+mkwpgQ@mail.gmail.com>
 <20200217020840.GA24821@codemonkey.org.uk>
 <CAHk-=wg5AkQk-9By-QeyT+5H_t6DLZD=25uOz-ujnV8oEv1Y5Q@mail.gmail.com>
From:   Josef Bacik <josef@toxicpanda.com>
Message-ID: <8025e1bf-4834-83c6-d12c-4e817f875776@toxicpanda.com>
Date:   Sun, 16 Feb 2020 22:02:01 -0500
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:68.0)
 Gecko/20100101 Thunderbird/68.5.0
MIME-Version: 1.0
In-Reply-To: <CAHk-=wg5AkQk-9By-QeyT+5H_t6DLZD=25uOz-ujnV8oEv1Y5Q@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 2/16/20 9:24 PM, Linus Torvalds wrote:
> On Sun, Feb 16, 2020 at 6:08 PM Dave Jones <davej@codemonkey.org.uk> wrote:
>>
>> This didn't happen in rc1, but showed up when I booted into rc2 and
>> tried to and pull some stuff with rsync.
>>
>> [   70.794783] BUG: sleeping function called from invalid context at mm/slab.h:565
>> [   70.795459]  kmem_cache_alloc+0x1d3/0x290
>> [   70.795471]  alloc_extent_state+0x22/0x1c0
>> [   70.795544]  __clear_extent_bit+0x3ba/0x580
>> [   70.795569]  btrfs_truncate_inode_items+0x339/0xe50
>> [   70.795647]  btrfs_evict_inode+0x269/0x540
> 
> At a guess (just by functions involved, and the timing between rc1 and
> rc2 - no actual analysis), this is probably due to
> 
>      28553fa992cb ("Btrfs: fix race between shrinking truncate and fiemap")
> 
> which is also marked for stable, so... Filipe?
> 

I assume Filipe wrote this based on my patch here

https://git.kernel.org/pub/scm/linux/kernel/git/josef/btrfs-next.git/commit/?id=c821555d2b9733d8f483c9e79481c7209e1c1fb0

which makes it so we can allocate safely in this context, but that patch hasn't 
made it's way to you yet.  Do you want it now?  It was prep for a much less safe 
patchset, but is fine by itself.  Thanks,

Josef