Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030614AbWBHX2V (ORCPT ); Wed, 8 Feb 2006 18:28:21 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1030615AbWBHX2V (ORCPT ); Wed, 8 Feb 2006 18:28:21 -0500 Received: from omx1-ext.sgi.com ([192.48.179.11]:46791 "EHLO omx1.americas.sgi.com") by vger.kernel.org with ESMTP id S1030614AbWBHX2U (ORCPT ); Wed, 8 Feb 2006 18:28:20 -0500 Date: Wed, 8 Feb 2006 15:28:02 -0800 (PST) From: Christoph Lameter To: Andrew Morton cc: Andi Kleen , pj@sgi.com, linux-kernel@vger.kernel.org Subject: Re: Terminate process that fails on a constrained allocation In-Reply-To: <20060208133909.183f19ea.akpm@osdl.org> Message-ID: References: <200602082201.12371.ak@suse.de> <20060208130351.fc1c759c.pj@sgi.com> <200602082221.35671.ak@suse.de> <20060208133909.183f19ea.akpm@osdl.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 628 Lines: 16 On Wed, 8 Feb 2006, Andrew Morton wrote: > > I think it should be put into 2.6.16. Andrew? > > Does every single caller of __alloc_pages(__GFP_FS) correctly handle a NULL > return? I doubt it, in which case this patch will cause oopses and hangs. If a caller cannot handle NULL then __GFP_NOFAIL has to be set, right? So we will never get to the piece of code under discussion. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/