Received: by 2002:a25:1506:0:0:0:0:0 with SMTP id 6csp4448126ybv; Sun, 16 Feb 2020 22:46:15 -0800 (PST) X-Google-Smtp-Source: APXvYqwdIeqaS0zp+wDUNW1yEo9x1JPyJkqbcCWGkaUASlV3TBzmW63vTPTndkChC100Gr5Y9K+D X-Received: by 2002:a9d:7511:: with SMTP id r17mr9491744otk.154.1581921975233; Sun, 16 Feb 2020 22:46:15 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1581921975; cv=none; d=google.com; s=arc-20160816; b=m7MbfRYLw8MhnRunbDGWtNv0qnAWJsI5rF6rWuoEKlzcX5K09fv0gODYZrDBVMAzQ9 NRqEB2H3CbuPWw/yTicral6Wll3yFeYNRavo/BjpRpJWhPgfnZCpEJraN/X9CVxBhHbJ IlClpXIby6uzpv8Ot/WUqNGSLQPsXXD1hnnkInl99cI1cI4snOgngoxn1pu2RWVhdfBv if1nxoZlL7VlQqkr0o15ftm9mjJAKb09EEOqUUq60fU/7C6L0aU00gwm66dEv8wjfRsB SvbR/xJvlUDK5u2tx/SEYrt3sMeH//ROBMTqfocZVXXRruw2jkgvdHnYKkMeAi4Hliob gxCg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:to:subject:dkim-signature; bh=EaltpDTgnTrDBrsgY6UJWwdsZ8tEVbQgtxpz7LvsQrs=; b=c3IinCTa0zS27bKRVxqLoubGEzYoQMh27R2gCHWAZOPy/NdU4Tj3BKhK4LeS3s6HzC n58I0u+ilFVvoguH5szgN67jSlWM/rdLJn00tZHilqKEYTLcfrvdJXjHfa6FtNkbCrAv 9CKLgUqK/nVsOo9V2Yh5HzEnPLjiDXzZl3sayZTEp2BqteWWmtlJLvh3USCj7e8XOTVE Yk78Sb9HfZwYhwQmwBfVxOPFwFbXEIIL6mUzmyi6DVLfezVmAB4rtn/bArnc0kWOZCjp Qn7i3ZP7Di8lfwNm6PCAofLNRbxGS7+z5oxVhxarliD4qOBAA9iIDEwUtUuhy8Ry2GwH GCUA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@c-s.fr header.s=mail header.b=Jkfz6bJu; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id v7si6310020oic.208.2020.02.16.22.46.03; Sun, 16 Feb 2020 22:46:15 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@c-s.fr header.s=mail header.b=Jkfz6bJu; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726823AbgBQGps (ORCPT + 99 others); Mon, 17 Feb 2020 01:45:48 -0500 Received: from pegase1.c-s.fr ([93.17.236.30]:36272 "EHLO pegase1.c-s.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726185AbgBQGps (ORCPT ); Mon, 17 Feb 2020 01:45:48 -0500 Received: from localhost (mailhub1-int [192.168.12.234]) by localhost (Postfix) with ESMTP id 48LZHp5ycKz9tyTQ; Mon, 17 Feb 2020 07:45:42 +0100 (CET) Authentication-Results: localhost; dkim=pass reason="1024-bit key; insecure key" header.d=c-s.fr header.i=@c-s.fr header.b=Jkfz6bJu; dkim-adsp=pass; dkim-atps=neutral X-Virus-Scanned: Debian amavisd-new at c-s.fr Received: from pegase1.c-s.fr ([192.168.12.234]) by localhost (pegase1.c-s.fr [192.168.12.234]) (amavisd-new, port 10024) with ESMTP id 2CQ5mQXasQID; Mon, 17 Feb 2020 07:45:42 +0100 (CET) Received: from messagerie.si.c-s.fr (messagerie.si.c-s.fr [192.168.25.192]) by pegase1.c-s.fr (Postfix) with ESMTP id 48LZHp4Ys7z9tyTL; Mon, 17 Feb 2020 07:45:42 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=c-s.fr; s=mail; t=1581921942; bh=EaltpDTgnTrDBrsgY6UJWwdsZ8tEVbQgtxpz7LvsQrs=; h=Subject:To:References:From:Date:In-Reply-To:From; b=Jkfz6bJu21tolva67YXh2dk19yfmBfDCJTRJwnnZdeKJSj2QkUXlcEAPDSQqDVduo PPmHS5kfH8tLAt5DnL9UwxC4nWXDOogfv4OMZXGRl9BNZ2g1VYBb+M5199VUcWsmbj 1RZ2vD+qrTlc0QaZPEdth7m+baweLU1QKzSHI/cI= Received: from localhost (localhost [127.0.0.1]) by messagerie.si.c-s.fr (Postfix) with ESMTP id 0942F8B79C; Mon, 17 Feb 2020 07:45:47 +0100 (CET) X-Virus-Scanned: amavisd-new at c-s.fr Received: from messagerie.si.c-s.fr ([127.0.0.1]) by localhost (messagerie.si.c-s.fr [127.0.0.1]) (amavisd-new, port 10023) with ESMTP id zPiOIOz8XNJK; Mon, 17 Feb 2020 07:45:46 +0100 (CET) Received: from [172.25.230.102] (unknown [172.25.230.102]) by messagerie.si.c-s.fr (Postfix) with ESMTP id D32F58B755; Mon, 17 Feb 2020 07:45:46 +0100 (CET) Subject: Re: [PATCH v7 4/4] powerpc: Book3S 64-bit "heavyweight" KASAN support To: Michael Neuling , Daniel Axtens , linux-kernel@vger.kernel.org, linux-mm@kvack.org, linuxppc-dev@lists.ozlabs.org, kasan-dev@googlegroups.com, aneesh.kumar@linux.ibm.com, bsingharora@gmail.com References: <20200213004752.11019-1-dja@axtens.net> <20200213004752.11019-5-dja@axtens.net> <66bd9d8eb682cda2d22bea0fd4035ea8e0a3c1fb.camel@neuling.org> From: Christophe Leroy Message-ID: Date: Mon, 17 Feb 2020 07:45:46 +0100 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 MIME-Version: 1.0 In-Reply-To: <66bd9d8eb682cda2d22bea0fd4035ea8e0a3c1fb.camel@neuling.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: fr Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Le 17/02/2020 à 00:08, Michael Neuling a écrit : > Daniel. > > Can you start this commit message with a simple description of what you are > actually doing? This reads like you've been on a long journey to Mordor and > back, which as a reader of this patch in the long distant future, I don't care > about. I just want to know what you're implementing. > > Also I'm struggling to review this as I don't know what software or hardware > mechanisms you are using to perform sanitisation. KASAN is standard, it's simply using GCC ASAN in kernel mode, ie kernel is built with -fsanitize=kernel-address (https://gcc.gnu.org/onlinedocs/gcc/Instrumentation-Options.html) You have more details there: https://www.kernel.org/doc/html/latest/dev-tools/kasan.html Christophe