Date: Wed, 8 Feb 2006 19:40:57 -0800
From: Pete Zaitcev <zaitcev@redhat.com>
To: Marc Koschewski <marc@osknowledge.org>
Cc: zaitcev@redhat.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH GIT] drivers/block/ub.c - misc. cleanup/indentation,
 removed unneeded return
Message-Id: <20060208194057.55b02719.zaitcev@redhat.com>
In-Reply-To: <mailman.1139418724.17734.linux-kernel2news@redhat.com>
References: <mailman.1139418724.17734.linux-kernel2news@redhat.com>
Organization: Red Hat, Inc.
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 875
Lines: 22

On Wed, 8 Feb 2006 10:29:15 +0100, Marc Koschewski <marc@osknowledge.org> wrote:

> I created this little patch while reading through drivers/block/ub.c. It fixes
> some indentation/whitespace as well as some empty commenting, an hardcoded
> module name and an unneeded return.

I strongly disagree.

The only segment which has some merit is the one which replaces the .name
with DRV_NAME. It could have been "usb-block" or something, but we probably
won't be using that, so it's all right.

But the rest is quite bad, the worst being indenting the switch statement.

Is there nothing else you can do in the whole kernel?

-- Pete
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/