Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Message-ID: <4177ac465032c043fc2bd2d257cfed1f9b32130f.camel@linux.ibm.com>
Subject: Re: [PATCH 1/1] powerpc/cputable: Remove unnecessary copy of
 cpu_spec->oprofile_type
From:   Leonardo Bras <leonardo@linux.ibm.com>
To:     Michael Neuling <mikey@neuling.org>,
        Benjamin Herrenschmidt <benh@kernel.crashing.org>,
        Paul Mackerras <paulus@samba.org>,
        Michael Ellerman <mpe@ellerman.id.au>,
        Christophe Leroy <christophe.leroy@c-s.fr>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Thomas Gleixner <tglx@linutronix.de>, desnesn@linux.ibm.com
Cc:     linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org
Date:   Mon, 17 Feb 2020 11:15:39 -0300
In-Reply-To: <f61f9a59ddb0f103cd62792e13afde4ca8afa7bb.camel@neuling.org>
References: <20200215053637.280880-1-leonardo@linux.ibm.com>
         <f61f9a59ddb0f103cd62792e13afde4ca8afa7bb.camel@neuling.org>
Content-Type: multipart/signed; micalg="pgp-sha256";
        protocol="application/pgp-signature"; boundary="=-miUKIdMazE7d2FNrQGQu"
User-Agent: Evolution 3.34.3 (3.34.3-1.fc31) 
MIME-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


--=-miUKIdMazE7d2FNrQGQu
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Mon, 2020-02-17 at 09:33 +1100, Michael Neuling wrote:
> On Sat, 2020-02-15 at 02:36 -0300, Leonardo Bras wrote:
> > Before checking for cpu_type =3D=3D NULL, this same copy happens, so do=
ing
> > it here will just write the same value to the t->oprofile_type
> > again.
> >=20
> > Remove the repeated copy, as it is unnecessary.
> >=20
> > Signed-off-by: Leonardo Bras <leonardo@linux.ibm.com>
>=20
> LGTM
>=20
> Reviewed-by: Michael Neuling <mikey@neuling.org>
>=20

Thanks!

> > ---
> >  arch/powerpc/kernel/cputable.c | 1 -
> >  1 file changed, 1 deletion(-)
> >=20
> > diff --git a/arch/powerpc/kernel/cputable.c b/arch/powerpc/kernel/cputa=
ble.c
> > index e745abc5457a..5a87ec96582f 100644
> > --- a/arch/powerpc/kernel/cputable.c
> > +++ b/arch/powerpc/kernel/cputable.c
> > @@ -2197,7 +2197,6 @@ static struct cpu_spec * __init setup_cpu_spec(un=
signed
> > long offset,
> >  		 */
> >  		if (old.oprofile_cpu_type !=3D NULL) {
> >  			t->oprofile_cpu_type =3D old.oprofile_cpu_type;
> > -			t->oprofile_type =3D old.oprofile_type;
> >  		}
> >  	}
> > =20

--=-miUKIdMazE7d2FNrQGQu
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEMdeUgIzgjf6YmUyOlQYWtz9SttQFAl5KoAsACgkQlQYWtz9S
ttSMkBAAloSDxI0JohdkvgvExJbJjNZFsMlB+OpXFavgD0axzhXdgPJGVuJCkS4o
ZdEahayhfkTsHyHEj/JosZGo5FcLlAW7yPtJKWA+HQhqezM+LrvFr0IFqPdV6SjP
RPfta0nf1OOk4KA7bik2fBAFbLZUJ2k2ujxLgFFeIuDinxIa82K661DJ3Kr8MpSc
39CQeRe/rcAIb+x+vpHa7KkL/jB/Nh7DZ5IeTvOnCE0oKoZq/cETSqmEgq3OBiHI
tC0+HgYRr4T4FCTnUktgSp7oomvMy8SB/8rcypxkkrxucN1522mL5vDhcDxa25f+
QxsIK95jjYVrJrVsRUdXccIfush9eSUMtZobyllSGO9AqMZ/8b3HxubyS9gT7Ag8
yGxBM8H8mD0G4ITxv+ylP9I1I3YuNPkT93JD+7nU6OPvGXmD0xnN0x+cgK/1x5SD
0UOwGnbJ4yAeQBIu+1uHT795psAUF0j2t7EN2H+haIWJfAXu4l188ALU9jvtqoOC
KoXcSi0YzG7mEfB5IyQyAVKI/7r3jbrbfl4rDSaf2IhOvZT7ueR/sA3G2u5u3Bw1
8QoP6MjRb6d7R+wbFUvMeW+Rk2IGTfdbEJr7vABlIwUMR0yLGc2LeGIyJ+9+7P+A
BsomQjSu6cPEQsQ2FwWKdBeKbnyQWZRpcjCj2xPhut/XJwS9z1s=
=7iTa
-----END PGP SIGNATURE-----

--=-miUKIdMazE7d2FNrQGQu--