Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Message-ID: <fb103b75cd10397f5325560051164df0d454c80a.camel@linux.ibm.com>
Subject: Re: [PATCH 1/1] powerpc/cputable: Remove unnecessary copy of
 cpu_spec->oprofile_type
From:   Leonardo Bras <leonardo@linux.ibm.com>
To:     Christophe Leroy <christophe.leroy@c-s.fr>,
        Benjamin Herrenschmidt <benh@kernel.crashing.org>,
        Paul Mackerras <paulus@samba.org>,
        Michael Ellerman <mpe@ellerman.id.au>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Thomas Gleixner <tglx@linutronix.de>, desnesn@linux.ibm.com
Cc:     linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org
Date:   Mon, 17 Feb 2020 11:18:39 -0300
In-Reply-To: <0d33a8b2-a7e5-c3e0-b28a-fd39f1231d97@c-s.fr>
References: <20200215053637.280880-1-leonardo@linux.ibm.com>
         <0d33a8b2-a7e5-c3e0-b28a-fd39f1231d97@c-s.fr>
Content-Type: multipart/signed; micalg="pgp-sha256";
        protocol="application/pgp-signature"; boundary="=-/Ntzj7jDLjC/0Tcm/bJ5"
User-Agent: Evolution 3.34.3 (3.34.3-1.fc31) 
MIME-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


--=-/Ntzj7jDLjC/0Tcm/bJ5
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hello Christophe, thank you for the feedback.

On Mon, 2020-02-17 at 07:31 +0100, Christophe Leroy wrote:
> >   		if (old.oprofile_cpu_type !=3D NULL) {
> >   			t->oprofile_cpu_type =3D old.oprofile_cpu_type;
> > -			t->oprofile_type =3D old.oprofile_type;
> >   		}
>=20
> The action being reduced to a single line, the { } should be removed.
>=20
> Christophe

I intentionally let it this way because I just reviewed a patch that
will add more itens here, and should be merged before this one.

This will avoid conflicts.

Best regards,
Leonardo Bras


--=-/Ntzj7jDLjC/0Tcm/bJ5
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEMdeUgIzgjf6YmUyOlQYWtz9SttQFAl5KoL8ACgkQlQYWtz9S
ttRywRAAmWKe+qH1dKQwhG8AZclARH6pVkfKzIS4a133HRlV9CQs8S3+yNi1yzDd
cVeWEN9cRIBm4sxsAxPxdJrY86j4pwH0ZeB6G37cl6YKC2s7WXReaV3oM4vxOXEN
+7mwwRVcLCq/SoS3Mk02NFxwmI13bb5x9mDgPO80TzeDsOWQmcWPhSindHFVgBgG
wQvKCMVss+XbNe1WGsfupOsMApiie2kdNQwMc1F9YNlO6BL5rj7534qagIbNJ7X0
2aM0PNifNLVog6+mr9o1erf7X8zJmKAweJlmP8KJiiIS7Rj1bTVDP7hj/oVnKr5w
v/sG7kfr895tabv7dCIW+JAOkT41XwktXaQxHDpNDE2opDXN0zu8/37zGbZeLcGL
yga+4o4rSZAstdswqkenFy3VH0ffFS1GQt7l68XveTKMZ1+COM8JHlCxPLDW4TL0
F0lp/pky0roQKcMt8ocMKA+8mpiK2q1ie9gbni5lX6vgWVzA8fG42Po0rqgJo1ud
d7KdTDR5d6/jX7ljkmNjRvnGacW7UczK7GrhgcQpInYqRrYoRG/Hf/cSsjM1RGeV
jw9ad+357ZHeOrMLUNv+7iQDXUWEfOvPml5H1Q05fZuhlh6rZEnIqdzqUYNJe6Wn
FcHV3WlDhwo5tS+nst7h0XaJjdKB1iyuooZ3zEDscyq/qsZ8RLU=
=4JiM
-----END PGP SIGNATURE-----

--=-/Ntzj7jDLjC/0Tcm/bJ5--