Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Mon, 17 Feb 2020 12:53:23 -0300
From:   Arnaldo Carvalho de Melo <acme@redhat.com>
To:     Steven Rostedt <rostedt@goodmis.org>, zhe.he@windriver.com
Cc:     rostedt@goodmis.org, tstoyanov@vmware.com, hewenliang4@huawei.com,
        linux-kernel@vger.kernel.org, acme@kernel.org
Subject: Re: [PATCH v2] tools lib traceevent: Take care of return value of
 asprintf
Message-ID: <20200217155323.GB3538@redhat.com>
References: <1581686481-180476-1-git-send-email-zhe.he@windriver.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <1581686481-180476-1-git-send-email-zhe.he@windriver.com>
User-Agent: Mutt/1.5.20 (2009-12-10)
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Em Fri, Feb 14, 2020 at 09:21:21PM +0800, zhe.he@windriver.com escreveu:
> From: He Zhe <zhe.he@windriver.com>
>=20
> According to the API, if memory allocation wasn't possible, or some oth=
er
> error occurs, asprintf will return -1, and the contents of strp below a=
re
> undefined.

Rostedt, did I miss some ack from you?

- Arnaldo
=20
> int asprintf(char **strp, const char *fmt, ...);
>=20
> This patch takes care of return value of asprintf to make it less error
> prone and prevent the following build warning.
>=20
> ignoring return value of =E2=80=98asprintf=E2=80=99, declared with attr=
ibute warn_unused_result [-Wunused-result]
>=20
> Signed-off-by: He Zhe <zhe.he@windriver.com>
> ---
> v2: directly check the return value without saving to a variable
>=20
>  tools/lib/traceevent/parse-filter.c | 35 +++++++++++++++++++++--------=
------
>  1 file changed, 21 insertions(+), 14 deletions(-)
>=20
> diff --git a/tools/lib/traceevent/parse-filter.c b/tools/lib/traceevent=
/parse-filter.c
> index 20eed71..6cd0228 100644
> --- a/tools/lib/traceevent/parse-filter.c
> +++ b/tools/lib/traceevent/parse-filter.c
> @@ -274,8 +274,7 @@ find_event(struct tep_handle *tep, struct event_lis=
t **events,
>  		sys_name =3D NULL;
>  	}
> =20
> -	ret =3D asprintf(&reg, "^%s$", event_name);
> -	if (ret < 0)
> +	if (asprintf(&reg, "^%s$", event_name) < 0)
>  		return TEP_ERRNO__MEM_ALLOC_FAILED;
> =20
>  	ret =3D regcomp(&ereg, reg, REG_ICASE|REG_NOSUB);
> @@ -285,8 +284,7 @@ find_event(struct tep_handle *tep, struct event_lis=
t **events,
>  		return TEP_ERRNO__INVALID_EVENT_NAME;
> =20
>  	if (sys_name) {
> -		ret =3D asprintf(&reg, "^%s$", sys_name);
> -		if (ret < 0) {
> +		if (asprintf(&reg, "^%s$", sys_name) < 0) {
>  			regfree(&ereg);
>  			return TEP_ERRNO__MEM_ALLOC_FAILED;
>  		}
> @@ -1958,7 +1956,8 @@ static char *op_to_str(struct tep_event_filter *f=
ilter, struct tep_filter_arg *a
>  				default:
>  					break;
>  				}
> -				asprintf(&str, val ? "TRUE" : "FALSE");
> +				if (asprintf(&str, val ? "TRUE" : "FALSE") < 0)
> +					str =3D NULL;
>  				break;
>  			}
>  		}
> @@ -1976,7 +1975,8 @@ static char *op_to_str(struct tep_event_filter *f=
ilter, struct tep_filter_arg *a
>  			break;
>  		}
> =20
> -		asprintf(&str, "(%s) %s (%s)", left, op, right);
> +		if (asprintf(&str, "(%s) %s (%s)", left, op, right) < 0)
> +			str =3D NULL;
>  		break;
> =20
>  	case TEP_FILTER_OP_NOT:
> @@ -1992,10 +1992,12 @@ static char *op_to_str(struct tep_event_filter =
*filter, struct tep_filter_arg *a
>  			right_val =3D 0;
>  		if (right_val >=3D 0) {
>  			/* just return the opposite */
> -			asprintf(&str, right_val ? "FALSE" : "TRUE");
> +			if (asprintf(&str, right_val ? "FALSE" : "TRUE") < 0)
> +				str =3D NULL;
>  			break;
>  		}
> -		asprintf(&str, "%s(%s)", op, right);
> +		if (asprintf(&str, "%s(%s)", op, right) < 0)
> +			str =3D NULL;
>  		break;
> =20
>  	default:
> @@ -2011,7 +2013,8 @@ static char *val_to_str(struct tep_event_filter *=
filter, struct tep_filter_arg *
>  {
>  	char *str =3D NULL;
> =20
> -	asprintf(&str, "%lld", arg->value.val);
> +	if (asprintf(&str, "%lld", arg->value.val) < 0)
> +		str =3D NULL;
> =20
>  	return str;
>  }
> @@ -2069,7 +2072,8 @@ static char *exp_to_str(struct tep_event_filter *=
filter, struct tep_filter_arg *
>  		break;
>  	}
> =20
> -	asprintf(&str, "%s %s %s", lstr, op, rstr);
> +	if (asprintf(&str, "%s %s %s", lstr, op, rstr) < 0)
> +		str =3D NULL;
>  out:
>  	free(lstr);
>  	free(rstr);
> @@ -2113,7 +2117,8 @@ static char *num_to_str(struct tep_event_filter *=
filter, struct tep_filter_arg *
>  		if (!op)
>  			op =3D "<=3D";
> =20
> -		asprintf(&str, "%s %s %s", lstr, op, rstr);
> +		if (asprintf(&str, "%s %s %s", lstr, op, rstr) < 0)
> +			str =3D NULL;
>  		break;
> =20
>  	default:
> @@ -2148,8 +2153,9 @@ static char *str_to_str(struct tep_event_filter *=
filter, struct tep_filter_arg *
>  		if (!op)
>  			op =3D "!~";
> =20
> -		asprintf(&str, "%s %s \"%s\"",
> -			 arg->str.field->name, op, arg->str.val);
> +		if (asprintf(&str, "%s %s \"%s\"",
> +			 arg->str.field->name, op, arg->str.val) < 0)
> +			str =3D NULL;
>  		break;
> =20
>  	default:
> @@ -2165,7 +2171,8 @@ static char *arg_to_str(struct tep_event_filter *=
filter, struct tep_filter_arg *
> =20
>  	switch (arg->type) {
>  	case TEP_FILTER_ARG_BOOLEAN:
> -		asprintf(&str, arg->boolean.value ? "TRUE" : "FALSE");
> +		if (asprintf(&str, arg->boolean.value ? "TRUE" : "FALSE") < 0)
> +			str =3D NULL;
>  		return str;
> =20
>  	case TEP_FILTER_ARG_OP:
> --=20
> 2.7.4