Received: by 2002:a25:1506:0:0:0:0:0 with SMTP id 6csp4889582ybv; Mon, 17 Feb 2020 07:54:20 -0800 (PST) X-Google-Smtp-Source: APXvYqxKqUSvG62S99qIBg6iES9cUAdneBqbIhj/GCBa088XjJUIShuqzEb66vvaZmuJ7Ept8mMW X-Received: by 2002:a9d:6e98:: with SMTP id a24mr12069093otr.53.1581954860377; Mon, 17 Feb 2020 07:54:20 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1581954860; cv=none; d=google.com; s=arc-20160816; b=Hd7Np/oTE3qHBW0DfPGgH6qm7Pl6LOUrWlSFfvs3eA6RtTrt9SlLP1CBWYhVi8T5th dljDI0Cu861XQCCluzeN1D7X3uQwA1VVScMry1Eb2jQk3XRuLMlaR0PG/JC0aSF99Yrm aIGsxUeDZS3YyWDX4SejyeRdmpYskca736GuMzdcDqLETsgnFlvElWqFeaDslopzdWCn S7RsxfJl8O7D5AoIvrw0/ul4Hx0m+eWi05+3mvj0dX9Ihv0/VwNpIJ6BCTVcBIxgd74i gfC6y9hgAoluphX5b2S9r2Bw/H/LTbmIDbt8A8MQLXPsByTNkycS39U2//kz5jBYVJiG Zxxw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:content-transfer-encoding :content-language:accept-language:message-id:date:thread-index :thread-topic:subject:cc:to:from; bh=1k/iFAjMNkal4r08fNDl8HWPdd2YB0tHuUw+AAXKOCs=; b=Qxqs3yPBdV1fJiI2IxC0By32sr884XtAxQEDuXsHuhb90lgTguH4pwN7LQxElVH2tH NPYG9eRGxbXVXwJOMQ/hZj7SpsshZWEnzmSsaaAWndm64Tl/udMfLVnrURJX9KSgH8O+ KTBtzzcHGGAgsSyPi59OOHJdc+aaV6w2BPKoEaLQRUxDJyACHuCa5cjGQsSvntGe50I8 qSJWKUrSeEl9k+RDpZ091qMMSEDeVK/hlNVqI43OB1Mz1vuKhzLgIqgnPMRw9oNIWTk9 5J5ZgPUJk0ldH9QmD8OlLAiYOnFwATuQWd3Tv4lswNHGbFN1RBBdC1d5aSurOybFU2Dl h1tA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w5si355426otm.45.2020.02.17.07.54.08; Mon, 17 Feb 2020 07:54:20 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729502AbgBQPxq convert rfc822-to-8bit (ORCPT + 99 others); Mon, 17 Feb 2020 10:53:46 -0500 Received: from skedge04.snt-world.com ([91.208.41.69]:34948 "EHLO skedge04.snt-world.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727553AbgBQPxp (ORCPT ); Mon, 17 Feb 2020 10:53:45 -0500 Received: from sntmail14r.snt-is.com (unknown [10.203.32.184]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by skedge04.snt-world.com (Postfix) with ESMTPS id 6CB0A67A7D3; Mon, 17 Feb 2020 16:53:43 +0100 (CET) Received: from sntmail12r.snt-is.com (10.203.32.182) by sntmail14r.snt-is.com (10.203.32.184) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1913.5; Mon, 17 Feb 2020 16:53:43 +0100 Received: from sntmail12r.snt-is.com ([fe80::e551:8750:7bba:3305]) by sntmail12r.snt-is.com ([fe80::e551:8750:7bba:3305%3]) with mapi id 15.01.1913.005; Mon, 17 Feb 2020 16:53:43 +0100 From: Schrempf Frieder To: Boris Brezillon , Schrempf Frieder , Jeff Kletsky , liaoweixiong , Miquel Raynal CC: "linux-kernel@vger.kernel.org" , "linux-mtd@lists.infradead.org" , "Richard Weinberger" Subject: [PATCH v2 0/3] mtd: spinand: Fix reading and writing of bad block markers Thread-Topic: [PATCH v2 0/3] mtd: spinand: Fix reading and writing of bad block markers Thread-Index: AQHV5apt9QxyjsUEOEmjBs5W5pZDtA== Date: Mon, 17 Feb 2020 15:53:43 +0000 Message-ID: <20200217155213.5594-1-frieder.schrempf@kontron.de> Accept-Language: de-DE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: git-send-email 2.17.1 x-originating-ip: [172.25.9.193] x-c2processedorg: 51b406b7-48a2-4d03-b652-521f56ac89f3 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-SnT-MailScanner-Information: Please contact the ISP for more information X-SnT-MailScanner-ID: 6CB0A67A7D3.A10BF X-SnT-MailScanner: Not scanned: please contact your Internet E-Mail Service Provider for details X-SnT-MailScanner-SpamCheck: X-SnT-MailScanner-From: frieder.schrempf@kontron.de X-SnT-MailScanner-To: bbrezillon@kernel.org, git-commits@allycomm.com, liaoweixiong@allwinnertech.com, linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org, miquel.raynal@bootlin.com, richard@nod.at X-Spam-Status: No Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Frieder Schrempf We were pointed to the issue of bad block markers not being saved to flash on one of our boards with SPI NAND flash. After a bit of investigation it seems like there are two overlapping bugs in the original framework that cause silent failure when writing a bad block marker. This set contains fixes for both of these issues and one more fix (patch 2) that should not affect the actual behavior of the driver. Changes in v2: * Patch 1: Incorporate small improvements proposed by Boris * Patch 1: Add Boris' R-b tag * Patch 2: Add Boris' R-b tag * Patch 3: Instead of waiting for the erase operation to finish, just don't do an erase at all, as it is not needed. Frieder Schrempf (3): mtd: spinand: Stop using spinand->oobbuf for buffering bad block markers mtd: spinand: Explicitly use MTD_OPS_RAW to write the bad block marker to OOB mtd: spinand: Don not erase the block before writing a bad block marker drivers/mtd/nand/spi/core.c | 18 ++++++++---------- 1 file changed, 8 insertions(+), 10 deletions(-) -- 2.17.1