Received: by 2002:a25:1506:0:0:0:0:0 with SMTP id 6csp4890549ybv; Mon, 17 Feb 2020 07:55:45 -0800 (PST) X-Google-Smtp-Source: APXvYqycpz97+7BnBGPcLi/J80SXvLOCLKEa5umfPSyxmWLcw61puRgBlDv+aqpnDiaaa9lpdJU0 X-Received: by 2002:a05:6830:2110:: with SMTP id i16mr12321136otc.337.1581954945141; Mon, 17 Feb 2020 07:55:45 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1581954945; cv=none; d=google.com; s=arc-20160816; b=BseTwrgOKNEvFYEMxCWY8SFbrx3e0cBs/Du/BLgqlx3YzNPdqMZMX24J2B2Q7Pvbdw ZUPnpqru6yfqRcPsa303YRx39sZ5jqnA6Keh9CnhjWT93o32cY/um7+VQ1o9EQp3gm1t 3SgTMK6QGAI85BWHd6uk4PtuJ4VvkYupWIRd2lioDrUQli0xoMv6RgKdoX+G50SPX1Rj nDrO9SUtyuwCheQWzXhZ85FV64D0AaigriIxWQDI2A8c85pAfR5pNYO9rlwC6CmHG9pt uxgTuSSbHvVwWQv/3PuHp8v/0jVZOVwMRva6NuTJ0w6mEVYBrweiVIuS8IiX9xPzXKJ3 AauA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:content-transfer-encoding :content-language:accept-language:in-reply-to:references:message-id :date:thread-index:thread-topic:subject:cc:to:from; bh=eQvnHAGUxlwGUrVIh/EX5XuuYcex/M+XAf6AAWWswE0=; b=AzSOO9fXmP5UUYH/QjJWRvNj1udoWzb4gb9kDonoSic3ICz4aHoxa8piyVWwtr04nI WiymcBzgxztKc8zJueRWtEXQ2t622SBWy3AeT3dAyZNpbW8RL4yw3qR1p2m+VblKrcUG jQnNEDHdYqf9VRlFthoPIGorfNGjAqfWXyiIqo0cLR7i0fJTeECqaON/blsbQSspgHVb 9Bi/OEt0f5Dw7eJ2sUDYrg9Gm6V3qnGnZErzbY7VVELAqgcyrn7imc6KI6c3u3rCt/KX 5aNLwtRtQ6gStKQogiYJnMq4G33a+p5xtkZvD3GPuzkLx7xUOm3NA6epRHoBDE5tPNj+ aWrw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id t24si370050oth.319.2020.02.17.07.55.33; Mon, 17 Feb 2020 07:55:45 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729585AbgBQPyI convert rfc822-to-8bit (ORCPT + 99 others); Mon, 17 Feb 2020 10:54:08 -0500 Received: from skedge04.snt-world.com ([91.208.41.69]:35036 "EHLO skedge04.snt-world.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729555AbgBQPyI (ORCPT ); Mon, 17 Feb 2020 10:54:08 -0500 Received: from sntmail12r.snt-is.com (unknown [10.203.32.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by skedge04.snt-world.com (Postfix) with ESMTPS id DCB4B67A885; Mon, 17 Feb 2020 16:54:02 +0100 (CET) Received: from sntmail12r.snt-is.com (10.203.32.182) by sntmail12r.snt-is.com (10.203.32.182) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1913.5; Mon, 17 Feb 2020 16:54:02 +0100 Received: from sntmail12r.snt-is.com ([fe80::e551:8750:7bba:3305]) by sntmail12r.snt-is.com ([fe80::e551:8750:7bba:3305%3]) with mapi id 15.01.1913.005; Mon, 17 Feb 2020 16:54:02 +0100 From: Schrempf Frieder To: Boris Brezillon , Schrempf Frieder , Jeff Kletsky , liaoweixiong , Miquel Raynal CC: "linux-kernel@vger.kernel.org" , "linux-mtd@lists.infradead.org" , "Richard Weinberger" Subject: [PATCH v2 2/3] mtd: spinand: Explicitly use MTD_OPS_RAW to write the bad block marker to OOB Thread-Topic: [PATCH v2 2/3] mtd: spinand: Explicitly use MTD_OPS_RAW to write the bad block marker to OOB Thread-Index: AQHV5ap5q7QUxB5UN0aFtKTOSCCO3Q== Date: Mon, 17 Feb 2020 15:54:02 +0000 Message-ID: <20200217155213.5594-3-frieder.schrempf@kontron.de> References: <20200217155213.5594-1-frieder.schrempf@kontron.de> In-Reply-To: <20200217155213.5594-1-frieder.schrempf@kontron.de> Accept-Language: de-DE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: git-send-email 2.17.1 x-originating-ip: [172.25.9.193] x-c2processedorg: 51b406b7-48a2-4d03-b652-521f56ac89f3 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-SnT-MailScanner-Information: Please contact the ISP for more information X-SnT-MailScanner-ID: DCB4B67A885.AFDEC X-SnT-MailScanner: Not scanned: please contact your Internet E-Mail Service Provider for details X-SnT-MailScanner-SpamCheck: X-SnT-MailScanner-From: frieder.schrempf@kontron.de X-SnT-MailScanner-To: bbrezillon@kernel.org, git-commits@allycomm.com, liaoweixiong@allwinnertech.com, linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org, miquel.raynal@bootlin.com, richard@nod.at X-Spam-Status: No Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Frieder Schrempf When writing the bad block marker to the OOB area the access mode should be set to MTD_OPS_RAW as it is done for reading the marker. Currently this only works because req.mode is initialized to MTD_OPS_PLACE_OOB (0) and spinand_write_to_cache_op() checks for req.mode != MTD_OPS_AUTO_OOB. Fix this by explicitly setting req.mode to MTD_OPS_RAW. Fixes: 7529df465248 ("mtd: nand: Add core infrastructure to support SPI NANDs") Signed-off-by: Frieder Schrempf Reviewed-by: Boris Brezillon --- Changes in v2: * Add Boris' R-b tag --- drivers/mtd/nand/spi/core.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/mtd/nand/spi/core.c b/drivers/mtd/nand/spi/core.c index de36cd7a5d7e..a94287884453 100644 --- a/drivers/mtd/nand/spi/core.c +++ b/drivers/mtd/nand/spi/core.c @@ -609,6 +609,7 @@ static int spinand_markbad(struct nand_device *nand, const struct nand_pos *pos) .ooboffs = 0, .ooblen = sizeof(marker), .oobbuf.out = marker, + .mode = MTD_OPS_RAW, }; int ret; -- 2.17.1