Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Mon, 17 Feb 2020 11:45:32 -0500
From:   Dave Jones <davej@codemonkey.org.uk>
To:     dsterba@suse.cz, Linus Torvalds <torvalds@linux-foundation.org>,
        Josef Bacik <josef@toxicpanda.com>,
        Filipe Manana <fdmanana@suse.com>,
        David Sterba <dsterba@suse.com>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: Linux 5.6-rc2
Message-ID: <20200217164532.GA3765@codemonkey.org.uk>
Mail-Followup-To: Dave Jones <davej@codemonkey.org.uk>, dsterba@suse.cz,
        Linus Torvalds <torvalds@linux-foundation.org>,
        Josef Bacik <josef@toxicpanda.com>,
        Filipe Manana <fdmanana@suse.com>, David Sterba <dsterba@suse.com>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
References: <CAHk-=wgqwiBLGvwTqU2kJEPNmafPpPe_K0XgBU-A58M+mkwpgQ@mail.gmail.com>
 <20200217020840.GA24821@codemonkey.org.uk>
 <CAHk-=wg5AkQk-9By-QeyT+5H_t6DLZD=25uOz-ujnV8oEv1Y5Q@mail.gmail.com>
 <8025e1bf-4834-83c6-d12c-4e817f875776@toxicpanda.com>
 <CAHk-=wiG+wjLjuDDNiqfL3iLW25yqsMK_gNEWomyMH=8kxOLwQ@mail.gmail.com>
 <20200217123054.GH2902@twin.jikos.cz>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200217123054.GH2902@twin.jikos.cz>
User-Agent: Mutt/1.10.1 (2018-07-13)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, Feb 17, 2020 at 01:30:54PM +0100, David Sterba wrote:
 > On Sun, Feb 16, 2020 at 09:08:18PM -0800, Linus Torvalds wrote:
 > > On Sun, Feb 16, 2020 at 7:02 PM Josef Bacik <josef@toxicpanda.com> wrote:
 > > >
 > > > I assume Filipe wrote this based on my patch here
 > > >
 > > > https://git.kernel.org/pub/scm/linux/kernel/git/josef/btrfs-next.git/commit/?id=c821555d2b9733d8f483c9e79481c7209e1c1fb0
 > > >
 > > > which makes it so we can allocate safely in this context, but that patch hasn't
 > > > made it's way to you yet.  Do you want it now?  It was prep for a much less safe
 > > > patchset, but is fine by itself.  Thanks,
 > > 
 > > I assume it's either that, or revert 28553fa992cb and do it differently..
 > > 
 > > I'll leave that whole decision to the btrfs people who actually know
 > > the code and the situations and what the alternative would look
 > > like...
 > 
 > I'll send a pull request with fix today. The fixes get cherry-picked
 > from development branch to current rc branch and sometimes affect each
 > other. I do test the rc branch independently before sending but I
 > haven't seen the bug Dave reported.

After rebooting, it didn't reproduce, so it did seem to be dependent on
exactly which files rsync was moving around.  Given it doesn't happen
all the time, little surprise it slipped through I guess.

	Dave