Received: by 2002:a25:1506:0:0:0:0:0 with SMTP id 6csp4957919ybv; Mon, 17 Feb 2020 09:12:37 -0800 (PST) X-Google-Smtp-Source: APXvYqxYpQMc7bCFY/QsjPRIqWtw9Ililg90vvLJM1hlKF56fsM+TrJ4pktSpLNhkGlzE4zVnU0h X-Received: by 2002:a9d:2dea:: with SMTP id g97mr12963585otb.33.1581959557184; Mon, 17 Feb 2020 09:12:37 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1581959557; cv=none; d=google.com; s=arc-20160816; b=EW02IXRqv8QCWTghH2NoEj681Si2otfwOaQudveIyygR/+cidZtO08tsZRAElQZmw5 Q9IpzdM1QqvN5pBHOyluDGX39pVzuQG5KvtnlHmFrnwon3sQnCintlunNCydLOq82QYf uQg4aaFhkBt4JHs7azvIsFpfF/LdcwtEzyyJ31x4MyiW67hP0xr/JTjbzoLtycl6PKAS EJEzYksFT2mO2DiDt9OAPMqTRPKnqYk+uZU4x07LUlBrrWKAvZLY2CAJR6HPdyWt2S84 mUwrPReVW6BBIhQIzO9xuaCXfRuetmnPMdvRNYtVEpzhpbvZyhzFk4YQgZ4Zedq4CNOL 4uFg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:autocrypt:from:references:cc:to:subject:dkim-signature; bh=pExjigbiFyjiC9TT47KCL7or17+KCvUqoQghFIlPoAs=; b=F2u72wtBk/wLE4peX2V0RJyAdjd2uxAshwV7g5oytXtHviGIoDjv3sQvW4VXKNKA6A kAPCTuQJ4bP7U21HIpZR2lefe/nQzCPGckzwcD92M9elXcR1j+8kclJmefveOx9k8P1j +gYaVjj3Wri3fEofHbTsY/d/AFhjk4KJeuYBg7X1wykIREec+GBnaRoxeLI3YtkErmwi sWGYdwO0Y3p73EO/3bEf+h+LxF5tFmn4QLFDBmurRqBK3B7T9B1iDdztWDhUT7bnKpYO DrefXGvUcnSoxtnNWqgV/rxoGVPfSFOF/2CivDmK3yypKrG+7V8RYwycjitIEuW7t5tX bFJA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@embeddedor.com header.s=default header.b=nbKgLHwC; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id h7si443732otm.165.2020.02.17.09.12.24; Mon, 17 Feb 2020 09:12:37 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@embeddedor.com header.s=default header.b=nbKgLHwC; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729283AbgBQRJe (ORCPT + 99 others); Mon, 17 Feb 2020 12:09:34 -0500 Received: from gateway20.websitewelcome.com ([192.185.49.40]:36466 "EHLO gateway20.websitewelcome.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727958AbgBQRJd (ORCPT ); Mon, 17 Feb 2020 12:09:33 -0500 Received: from cm16.websitewelcome.com (cm16.websitewelcome.com [100.42.49.19]) by gateway20.websitewelcome.com (Postfix) with ESMTP id 02578400CD680 for ; Mon, 17 Feb 2020 09:55:41 -0600 (CST) Received: from gator4166.hostgator.com ([108.167.133.22]) by cmsmtp with SMTP id 3jtkjevBX8vkB3jtkjbu3T; Mon, 17 Feb 2020 11:09:32 -0600 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=embeddedor.com; s=default; h=Content-Transfer-Encoding:Content-Type: In-Reply-To:MIME-Version:Date:Message-ID:From:References:Cc:To:Subject:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=pExjigbiFyjiC9TT47KCL7or17+KCvUqoQghFIlPoAs=; b=nbKgLHwCiI5ltyzH6CpQqFfavg WCLlVIfIZnNmtMG0ACTZ0osdgDORdo3Flgi7cnKr5c4R0lKAQiXlgd5DSXK6DidVGi9tyYB/5k0/5 0FUtRSxUYlSdqO2huPE5lZmumXaiDkhs8QLqymQrcwbv5rxcCY4BMKVOtiEMlUS9fO3Oek1/LfnaZ yBng5gzq8NmN+WETLxjiZnFrBzN2LqJeiDRCvorwkFoN2EWHPZn67daLSriGbejOqhxYeDEUipdSu qQHFi2iGO7fEDj+CHiem/NTWMbwT5OTNrMrf1+8A5kt7cu0uYtCmWcAbd2beaSw70zfV02KcF2uL9 cvmlPIQA==; Received: from [200.68.140.26] (port=1590 helo=[192.168.43.131]) by gator4166.hostgator.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.92) (envelope-from ) id 1j3jtk-003Lt8-Cn; Mon, 17 Feb 2020 11:09:32 -0600 Subject: Re: [PATCH] usb: host: fhci-hcd: annotate PIPE_CONTROL switch case with fallthrough To: Greg Kroah-Hartman , Rasmus Villemoes Cc: Timur Tabi , Li Yang , Anton Vorontsov , kbuild test robot , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org References: <20200213085401.27862-1-linux@rasmusvillemoes.dk> <20200213125659.GB3325929@kroah.com> From: "Gustavo A. R. Silva" Autocrypt: addr=gustavo@embeddedor.com; keydata= xsFNBFssHAwBEADIy3ZoPq3z5UpsUknd2v+IQud4TMJnJLTeXgTf4biSDSrXn73JQgsISBwG 2Pm4wnOyEgYUyJd5tRWcIbsURAgei918mck3tugT7AQiTUN3/5aAzqe/4ApDUC+uWNkpNnSV tjOx1hBpla0ifywy4bvFobwSh5/I3qohxDx+c1obd8Bp/B/iaOtnq0inli/8rlvKO9hp6Z4e DXL3PlD0QsLSc27AkwzLEc/D3ZaqBq7ItvT9Pyg0z3Q+2dtLF00f9+663HVC2EUgP25J3xDd 496SIeYDTkEgbJ7WYR0HYm9uirSET3lDqOVh1xPqoy+U9zTtuA9NQHVGk+hPcoazSqEtLGBk YE2mm2wzX5q2uoyptseSNceJ+HE9L+z1KlWW63HhddgtRGhbP8pj42bKaUSrrfDUsicfeJf6 m1iJRu0SXYVlMruGUB1PvZQ3O7TsVfAGCv85pFipdgk8KQnlRFkYhUjLft0u7CL1rDGZWDDr NaNj54q2CX9zuSxBn9XDXvGKyzKEZ4NY1Jfw+TAMPCp4buawuOsjONi2X0DfivFY+ZsjAIcx qQMglPtKk/wBs7q2lvJ+pHpgvLhLZyGqzAvKM1sVtRJ5j+ARKA0w4pYs5a5ufqcfT7dN6TBk LXZeD9xlVic93Ju08JSUx2ozlcfxq+BVNyA+dtv7elXUZ2DrYwARAQABzSxHdXN0YXZvIEEu IFIuIFNpbHZhIDxndXN0YXZvQGVtYmVkZGVkb3IuY29tPsLBfQQTAQgAJwUCWywcDAIbIwUJ CWYBgAULCQgHAgYVCAkKCwIEFgIDAQIeAQIXgAAKCRBHBbTLRwbbMZ6tEACk0hmmZ2FWL1Xi l/bPqDGFhzzexrdkXSfTTZjBV3a+4hIOe+jl6Rci/CvRicNW4H9yJHKBrqwwWm9fvKqOBAg9 obq753jydVmLwlXO7xjcfyfcMWyx9QdYLERTeQfDAfRqxir3xMeOiZwgQ6dzX3JjOXs6jHBP cgry90aWbaMpQRRhaAKeAS14EEe9TSIly5JepaHoVdASuxklvOC0VB0OwNblVSR2S5i5hSsh ewbOJtwSlonsYEj4EW1noQNSxnN/vKuvUNegMe+LTtnbbocFQ7dGMsT3kbYNIyIsp42B5eCu JXnyKLih7rSGBtPgJ540CjoPBkw2mCfhj2p5fElRJn1tcX2McsjzLFY5jK9RYFDavez5w3lx JFgFkla6sQHcrxH62gTkb9sUtNfXKucAfjjCMJ0iuQIHRbMYCa9v2YEymc0k0RvYr43GkA3N PJYd/vf9vU7VtZXaY4a/dz1d9dwIpyQARFQpSyvt++R74S78eY/+lX8wEznQdmRQ27kq7BJS R20KI/8knhUNUJR3epJu2YFT/JwHbRYC4BoIqWl+uNvDf+lUlI/D1wP+lCBSGr2LTkQRoU8U 64iK28BmjJh2K3WHmInC1hbUucWT7Swz/+6+FCuHzap/cjuzRN04Z3Fdj084oeUNpP6+b9yW e5YnLxF8ctRAp7K4yVlvA87BTQRbLBwMARAAsHCE31Ffrm6uig1BQplxMV8WnRBiZqbbsVJB H1AAh8tq2ULl7udfQo1bsPLGGQboJSVN9rckQQNahvHAIK8ZGfU4Qj8+CER+fYPp/MDZj+t0 DbnWSOrG7z9HIZo6PR9z4JZza3Hn/35jFggaqBtuydHwwBANZ7A6DVY+W0COEU4of7CAahQo 5NwYiwS0lGisLTqks5R0Vh+QpvDVfuaF6I8LUgQR/cSgLkR//V1uCEQYzhsoiJ3zc1HSRyOP otJTApqGBq80X0aCVj1LOiOF4rrdvQnj6iIlXQssdb+WhSYHeuJj1wD0ZlC7ds5zovXh+FfF l5qH5RFY/qVn3mNIVxeO987WSF0jh+T5ZlvUNdhedGndRmwFTxq2Li6GNMaolgnpO/CPcFpD jKxY/HBUSmaE9rNdAa1fCd4RsKLlhXda+IWpJZMHlmIKY8dlUybP+2qDzP2lY7kdFgPZRU+e zS/pzC/YTzAvCWM3tDgwoSl17vnZCr8wn2/1rKkcLvTDgiJLPCevqpTb6KFtZosQ02EGMuHQ I6Zk91jbx96nrdsSdBLGH3hbvLvjZm3C+fNlVb9uvWbdznObqcJxSH3SGOZ7kCHuVmXUcqoz ol6ioMHMb+InrHPP16aVDTBTPEGwgxXI38f7SUEn+NpbizWdLNz2hc907DvoPm6HEGCanpcA EQEAAcLBZQQYAQgADwUCWywcDAIbDAUJCWYBgAAKCRBHBbTLRwbbMdsZEACUjmsJx2CAY+QS UMebQRFjKavwXB/xE7fTt2ahuhHT8qQ/lWuRQedg4baInw9nhoPE+VenOzhGeGlsJ0Ys52sd XvUjUocKgUQq6ekOHbcw919nO5L9J2ejMf/VC/quN3r3xijgRtmuuwZjmmi8ct24TpGeoBK4 WrZGh/1hAYw4ieARvKvgjXRstcEqM5thUNkOOIheud/VpY+48QcccPKbngy//zNJWKbRbeVn imua0OpqRXhCrEVm/xomeOvl1WK1BVO7z8DjSdEBGzbV76sPDJb/fw+y+VWrkEiddD/9CSfg fBNOb1p1jVnT2mFgGneIWbU0zdDGhleI9UoQTr0e0b/7TU+Jo6TqwosP9nbk5hXw6uR5k5PF 8ieyHVq3qatJ9K1jPkBr8YWtI5uNwJJjTKIA1jHlj8McROroxMdI6qZ/wZ1ImuylpJuJwCDC ORYf5kW61fcrHEDlIvGc371OOvw6ejF8ksX5+L2zwh43l/pKkSVGFpxtMV6d6J3eqwTafL86 YJWH93PN+ZUh6i6Rd2U/i8jH5WvzR57UeWxE4P8bQc0hNGrUsHQH6bpHV2lbuhDdqo+cM9eh GZEO3+gCDFmKrjspZjkJbB5Gadzvts5fcWGOXEvuT8uQSvl+vEL0g6vczsyPBtqoBLa9SNrS VtSixD1uOgytAP7RWS474w== Message-ID: <4fa8a8e9-934d-2962-1daa-fdeea6017ea1@embeddedor.com> Date: Mon, 17 Feb 2020 11:12:13 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: <20200213125659.GB3325929@kroah.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - gator4166.hostgator.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - embeddedor.com X-BWhitelist: no X-Source-IP: 200.68.140.26 X-Source-L: No X-Exim-ID: 1j3jtk-003Lt8-Cn X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: ([192.168.43.131]) [200.68.140.26]:1590 X-Source-Auth: gustavo@embeddedor.com X-Email-Count: 8 X-Source-Cap: Z3V6aWRpbmU7Z3V6aWRpbmU7Z2F0b3I0MTY2Lmhvc3RnYXRvci5jb20= X-Local-Domain: yes Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2/13/20 06:56, Greg Kroah-Hartman wrote: > On Thu, Feb 13, 2020 at 09:54:00AM +0100, Rasmus Villemoes wrote: >> After this was made buildable for something other than PPC32, kbuild >> starts warning >> >> drivers/usb/host/fhci-hcd.c:398:8: warning: this statement may fall >> through [-Wimplicit-fallthrough=] >> >> I don't know this code, but from the construction (initializing size >> with 0 and explicitly using "size +=" in the PIPE_BULK case) I assume >> that fallthrough is indeed intended. >> >> Reported-by: kbuild test robot >> Fixes: 5a35435ef4e6 (soc: fsl: qe: remove PPC32 dependency from CONFIG_QUICC_ENGINE) >> Fixes: a035d552a93b (Makefile: Globally enable fall-through warning) By the way, the "Fixes" tag above makes no sense. There is nothing wrong about that commit. It just enabled the fall-through warning globally. Why would you "fix" that? Thanks -- Gustavo