Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
IronPort-PHdr: =?us-ascii?q?9a23=3AVZ7J/h2bDuOeVSi7smDT+zVfbzU7u7jyIg8e44?=
 =?us-ascii?q?YmjLQLaKm44pD+JxKGt+51ggrPWoPWo7JfhuzavrqoeFRI4I3J8RVgOIdJSw?=
 =?us-ascii?q?dDjMwXmwI6B8vQBUT9LfPucCUSF8VZX1gj9Ha+YgBY?=
From:   "Daniel Walker (danielwa)" <danielwa@cisco.com>
To:     Evgeniy Polyakov <zbr@ioremap.net>
CC:     David Miller <davem@davemloft.net>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] drivers: connector: cn_proc: allow limiting certain
 messages
Thread-Topic: [PATCH] drivers: connector: cn_proc: allow limiting certain
 messages
Thread-Index: AQHV5br7vHcY3LtkzE2GSB4q/RS10w==
Date:   Mon, 17 Feb 2020 17:52:11 +0000
Message-ID: <20200217175209.GM24152@zorba>
References: <20200212192901.6402-1-danielwa@cisco.com>
 <20200216.184443.782357344949548902.davem@davemloft.net>
 <20200217172551.GL24152@zorba>
 <16818701581961475@iva7-8a22bc446c12.qloud-c.yandex.net>
In-Reply-To: <16818701581961475@iva7-8a22bc446c12.qloud-c.yandex.net>
Accept-Language: en-GB, en-US
Content-Language: en-US
received-spf: None (protection.outlook.com: cisco.com does not designate
 permitted sender hosts)
Content-Type: text/plain; charset="us-ascii"
Content-ID: <9CE2DF0A5AC1274EB7C61D079447A354@namprd11.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 45a6d45f-22ae-4bfc-0e71-08d7b3d21dbf
X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Feb 2020 17:52:11.8909
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 5ae1af62-9505-4097-a69a-c1553ef7840e
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 9ZHFmfDnNjrtM9y03OlsQO3Nvdb6+eyyiHuscPSlvyBcTZX1HR7q2veDIAKx7hPH/lZLXlLcifKY4dYtWD79cQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR11MB3125
X-OriginatorOrg: cisco.com
X-Outbound-SMTP-Client: 173.37.102.13, xch-rcd-003.cisco.com
X-Outbound-Node: rcdn-core-6.cisco.com
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Feb 17, 2020 at 08:44:35PM +0300, Evgeniy Polyakov wrote:
>    Hi Daniel, David
>    =20
>    17.02.2020, 20:26, "Daniel Walker (danielwa)" <danielwa@cisco.com>:
>    > On Sun, Feb 16, 2020 at 06:44:43PM -0800, David Miller wrote:
>    >>  This is a netlink based facility, therefore please you should add
>    filtering
>    >>  capabilities to the netlink configuration and communications path.
>    >>
>    >>  Module parameters are quite verboten.
>    >
>    > How about adding in Kconfig options to limit the types of messages? =
The
>    issue
>    > with this interface is that it's very easy for someone to enable the
>    interface
>    > as a listener, then never turn the interface off. Then it becomes a
>    broadcast
>    > interface. It's desirable to limit the more noisy messages in some
>    cases.
>    =20
>    =20
>    Compile-time options are binary switches which live forever after kern=
el
>    config has been created, its not gonna help those who enabled messages=
.
>    Kernel modules are kind of no-go, since it requires reboot to change i=
n
>    some cases.
>    =20
>    Having netlink control from userspace is a nice option, and connector =
has
>    simple userspace->kernelspace channel,
>    but it requires additional userspace utils or programming, which is st=
ill
>    cumbersome.
>    =20
>    What about sysfs interface with one file per message type?

You mean similar to the module parameters I've done, but thru sysfs ? It wo=
uld
work for Cisco. I kind of like Kconfig because it also reduces kernel size =
for
messages you may never want to see.

Daniel=