Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Message-ID: <8b50c93b2556413ce2736e18e939f1b376bf48c7.camel@suse.de>
Subject: Re: [PATCH] usb: xhci-pci: Raspberry Pi FW loader for VIA VL805
From:   Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
To:     Stefan Wahren <stefan.wahren@i2se.com>,
        Mathias Nyman <mathias.nyman@intel.com>,
        Florian Fainelli <f.fainelli@gmail.com>,
        Ray Jui <rjui@broadcom.com>,
        Scott Branden <sbranden@broadcom.com>,
        bcm-kernel-feedback-list@broadcom.com
Cc:     tim.gover@raspberrypi.org, oneukum@suse.com,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-rpi-kernel@lists.infradead.org, phil@raspberrypi.com,
        linux-arm-kernel@lists.infradead.org
Date:   Mon, 17 Feb 2020 20:39:06 +0100
In-Reply-To: <bf77d351-ca8c-d9fd-e5ea-71441ac00ab3@i2se.com>
References: <20200217100701.19949-1-nsaenzjulienne@suse.de>
         <bf77d351-ca8c-d9fd-e5ea-71441ac00ab3@i2se.com>
Content-Type: multipart/signed; micalg="pgp-sha256";
        protocol="application/pgp-signature"; boundary="=-ogkfL5d9U8ZLHgULSlCK"
User-Agent: Evolution 3.34.3 
MIME-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


--=-ogkfL5d9U8ZLHgULSlCK
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Mon, 2020-02-17 at 18:47 +0100, Stefan Wahren wrote:
> > +
> > +	dev_addr =3D pdev->bus->number << 20 | PCI_SLOT(pdev->devfn) << 15 |
> > +		   PCI_FUNC(pdev->devfn) << 12;
> > +
> > +	ret =3D rpi_firmware_property(fw, RPI_FIRMWARE_NOTIFY_XHCI_RESET,
> > +				    &dev_addr, sizeof(dev_addr));
> > +	if (ret)
> > +		return ret;
> not sure, but there could be a corner case which should be handled
> differently. In case the Raspberry Pi 4 has an EEPROM for the VL805
> firmware but the firmware is too old to handle
> RPI_FIRMWARE_NOTIFY_XHCI_RESET, we should return with 0. I don't know
> there is a change to detect this reliable. I just want to mention this.

Ouch, good point, that can be problematic. I'll test that scenario tomorrow=
.

> > diff --git a/include/soc/bcm2835/raspberrypi-firmware.h
> > b/include/soc/bcm2835/raspberrypi-firmware.h
> > index 7800e12ee042..cc9cdbc66403 100644
> > --- a/include/soc/bcm2835/raspberrypi-firmware.h
> > +++ b/include/soc/bcm2835/raspberrypi-firmware.h
> > @@ -90,7 +90,7 @@ enum rpi_firmware_property_tag {
> >  	RPI_FIRMWARE_SET_PERIPH_REG =3D                         0x00038045,
> >  	RPI_FIRMWARE_GET_POE_HAT_VAL =3D                        0x00030049,
> >  	RPI_FIRMWARE_SET_POE_HAT_VAL =3D                        0x00030050,
> > -
> > +	RPI_FIRMWARE_NOTIFY_XHCI_RESET =3D                      0x00030058,
>=20
> In past we updated the firmware mailbox property interface in a bunch as
> a separate patch. So we can avoid those gaps.

Ok, I'll change that.

Regards,
Nicolas


--=-ogkfL5d9U8ZLHgULSlCK
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNATURE-----

iQEzBAABCAAdFiEErOkkGDHCg2EbPcGjlfZmHno8x/4FAl5K69oACgkQlfZmHno8
x/564ggAnRR3cI7WWFgxYpBmwwEU6WnQinv4UaaIe0w5g4vjvt8UjgnypPpwGlBI
qqVXlFsvzR1pXNyTDZcjdzkqmYekgCaR4+0ONPYL+ofhQ3SeYg/FwsVgkWTcE0SQ
FmiQRIDZk9qYF1UV5ABz0dPTvD3nBjNEN5+1s2Ti6hjSIb3OIVH/DgsxSUIQfvaK
iL1+4ikVfvckbDrBG/PnCsCfxoiTfQWMC/QoUZROSsO4NVBFojLwyK0nDA+O9k8R
6N/1OMUoJOCzjW27KZ3vUuKf2Vc3pu4UgfPXEY4oeWpAF+5055DHaJBrYDQopEzE
0sJWKha2D5TpFR9/StcAUyp2secwOw==
=+vmi
-----END PGP SIGNATURE-----

--=-ogkfL5d9U8ZLHgULSlCK--