Received: by 2002:a25:1506:0:0:0:0:0 with SMTP id 6csp5084082ybv; Mon, 17 Feb 2020 11:55:47 -0800 (PST) X-Google-Smtp-Source: APXvYqw/n8IUG/KLt3/pPtiIamYtgjAVsJScbCqIcHPp9jQwBzMMT6WUaSnh96Ih3ZGOw6cLsP3U X-Received: by 2002:a9d:6ac2:: with SMTP id m2mr13488163otq.191.1581969347050; Mon, 17 Feb 2020 11:55:47 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1581969347; cv=none; d=google.com; s=arc-20160816; b=z+yXyZFoIdHEX9q0SuG20gGGwpXlYmvwBRs1/d9UETDA8duUFOrE33DAcWNA2LTGQP /4bsSM8JMBKQv9lIVQCHJ3h7L/jsfkezxAJ/YD4EvlQh+ymaJzn+93JzlOlediV5xzYe mWoJSYiqyfqXTxMeXVk+/SmE0+u6deEX1n0QwhM3atFhK+UE2SOWR0ESjeTBpX0Z8gdn Sdz8ZknMq24BWbxEQ6MvqpOw+w7WxQgmk3c7C8s8gKNeGfa3TH5miQ120jIjZUEgMXzV ezEyuuDRGDC8CwfU56IYcY/pGZmwKYxg5P+0oYbrPR6up6PIKOIO272mdqylew2VilCD sfDg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:mail-followup-to:reply-to:message-id :subject:cc:to:from:date:dkim-signature; bh=k22V0NI2T+CODElUbt4W6m1o0DIF8IGREqO+FIqkD2A=; b=nHC/ygaVjiAwm3PJ+/EHJWNL4miO0IKzQWZ6Co4K5CGqCwLowxw85Pgk/8DBpc6m2O u6YD6LufY1FneYngl567khJr4fMx5VcQLV9AtKtIqyBsoj4vSutJpa08x8FTcSz6WNMb XlqYETPhaP3yt6daCbxcVtc0wUqWmGI8c60Le0ltMKRNp2w6bWUarXo4i8oYd5Cwi+H4 CRPpgtZn/1exJ9M5GDwsG5TJ1F9ytnz3omKXK+Y8QUEjktjS3nAfgUJmNV298sQxVoja opHYpmnhwiZvHPQTLYXgu2IrToDKa2u3tuFcimY08kPMe/eRHwIIC3PUz84UbeFPWE9S VaHg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=BsWuDXKC; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f28si644439otc.110.2020.02.17.11.55.34; Mon, 17 Feb 2020 11:55:47 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=BsWuDXKC; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729826AbgBQTy4 (ORCPT + 99 others); Mon, 17 Feb 2020 14:54:56 -0500 Received: from us-smtp-2.mimecast.com ([207.211.31.81]:32021 "EHLO us-smtp-1.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729798AbgBQTyz (ORCPT ); Mon, 17 Feb 2020 14:54:55 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1581969294; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=k22V0NI2T+CODElUbt4W6m1o0DIF8IGREqO+FIqkD2A=; b=BsWuDXKCihuL6/LYVwnidfuXHPaAPR4h70oX4lu2gKoqMqBJ2rVu5KUsDZyP9Tl5gcX7id jl+h3gN5twDfi2WkQ8fEJIkNrvoIHG3JliZR7aPAfZuhuWoUpfSuQHSY7xTifVt738WvUw bxA1+f+945VqtAmcrzJ8qe/8/h87NTQ= Received: from mail-qv1-f71.google.com (mail-qv1-f71.google.com [209.85.219.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-19-R-4SOanxPcWGYd4fm1Tm_g-1; Mon, 17 Feb 2020 14:54:52 -0500 X-MC-Unique: R-4SOanxPcWGYd4fm1Tm_g-1 Received: by mail-qv1-f71.google.com with SMTP id e26so10924280qvb.4 for ; Mon, 17 Feb 2020 11:54:52 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:reply-to :mail-followup-to:references:mime-version:content-disposition :in-reply-to; bh=k22V0NI2T+CODElUbt4W6m1o0DIF8IGREqO+FIqkD2A=; b=nXtX+ELWR4QYkBnfbv4N/NQyg0eGbe24M6cBhXH4qUm5d4Wdqj5hFpEs79gtrw7qw7 CJFL62dbpyRvnLBD/VIzqkDj79tv+ZjS4ZE2OenXSOASfBdzF12B6hLL071uQ6O95fw9 ju1OJMItQy9cSzzlVweW76etF+Ut5NRLS7x10PXcpRvGefxEGBmVBwYZJDfrXzxeuL79 +r4fbUGMwlp50GgtMrlXuJdoc+/Y/9fgC/Pw2R+F2zZi+NCvpDjsJYYUas1uxhmQyWdX xI9KFnKtgrpKzV7HXUHvgkw6glEUx0rJyoYzh/fJsKWqejqLrvkLQHmC0j3yltNQV5Sf N3gg== X-Gm-Message-State: APjAAAXQURknxlorUtQwurQi8dTAYbkw4pe5QE26DRaDJ/ZIoVQeDsdU gFBDztcYRKI/BnjYrNTcUwR9YcsDyS9V/z+y1ByTRiddzFqh55qmGKJS2b15lrU20K2Jr1FwFl8 YAIUQbmPqsxLML1b9X8ru/Hxr X-Received: by 2002:ac8:530c:: with SMTP id t12mr13720560qtn.83.1581969292524; Mon, 17 Feb 2020 11:54:52 -0800 (PST) X-Received: by 2002:ac8:530c:: with SMTP id t12mr13720547qtn.83.1581969292343; Mon, 17 Feb 2020 11:54:52 -0800 (PST) Received: from localhost (ip70-163-223-149.ph.ph.cox.net. [70.163.223.149]) by smtp.gmail.com with ESMTPSA id f7sm678488qtj.92.2020.02.17.11.54.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Feb 2020 11:54:51 -0800 (PST) Date: Mon, 17 Feb 2020 12:54:50 -0700 From: Jerry Snitselaar To: Joerg Roedel Cc: Lu Baolu , David Woodhouse , jroedel@suse.de, iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 5/5] iommu/vt-d: Simplify check in identity_mapping() Message-ID: <20200217195450.hpk5mtxzbhy5p72a@cantor> Reply-To: Jerry Snitselaar Mail-Followup-To: Joerg Roedel , Lu Baolu , David Woodhouse , jroedel@suse.de, iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org References: <20200217193858.26990-1-joro@8bytes.org> <20200217193858.26990-6-joro@8bytes.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Disposition: inline In-Reply-To: <20200217193858.26990-6-joro@8bytes.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon Feb 17 20, Joerg Roedel wrote: >From: Joerg Roedel > >The function only has one call-site and there it is never called with >dummy or deferred devices. Simplify the check in the function to >account for that. > >Signed-off-by: Joerg Roedel Reviewed-by: Jerry Snitselaar