Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH v3] extcon: palmas: hide error messages if gpio returns -EPROBE_DEFER
Mime-Version: 1.0 (Mac OS X Mail 9.3 \(3124\))
Content-Type: text/plain; charset=us-ascii
From:   "H. Nikolaus Schaller" <hns@goldelico.com>
In-Reply-To: <20200217201911.GA168683@lenoch>
Date:   Mon, 17 Feb 2020 21:25:32 +0100
Cc:     MyungJoo Ham <myungjoo.ham@samsung.com>,
        Chanwoo Choi <cw00.choi@samsung.com>,
        linux-kernel@vger.kernel.org, letux-kernel@openphoenux.org,
        kernel@pyra-handheld.com, linux-omap@vger.kernel.org
Content-Transfer-Encoding: quoted-printable
Message-Id: <CEE4951F-085A-4D9C-AD15-F63C80D958EB@goldelico.com>
References: <d5c2826a5f00fcaee62f00662ae2a44dc4a5395d.1581946695.git.hns@goldelico.com> <C3D9F783-EE45-4681-93D9-C1407284CB59@goldelico.com> <20200217182906.GA140676@lenoch> <012228CC-2B49-4AAE-B574-92E44621F0D6@goldelico.com> <20200217190745.GA147152@lenoch> <017C406F-0DD9-478F-8AD5-D950A4000305@goldelico.com> <20200217201911.GA168683@lenoch>
To:     Ladislav Michl <ladis@linux-mips.org>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Ladis,

> Am 17.02.2020 um 21:19 schrieb Ladislav Michl <ladis@linux-mips.org>:
>=20
> Hi Nikolaus,
>=20
> On Mon, Feb 17, 2020 at 08:33:52PM +0100, H. Nikolaus Schaller wrote:
>> Hi Ladis,
>>=20
>>> Am 17.02.2020 um 20:07 schrieb Ladislav Michl =
<ladis@linux-mips.org>:
>>> Linux kernel prints so many lines on bootup and only few of them are
>>> valuable. Lets improve it by printing error value to give a clue
>>> why it failed.
>>=20
>> Hm. The upstream code does already print the error. This feature is =
not removed.
>> But it is also printing an error in the EPROBE_DEFER case as well, =
where it is
>> not needed or not an error.
>=20
> It seems you missed I'm printing also error _value_.

Indeed.

Well, usually there is no error so adding the error number is not of =
much
use (except for debugging)... The most likely one seems to be =
-EPROBE_DEFER.

On the omap5 boards where I have seen the error message being printed =
they were
EPROBE_DEFER.

So your proposal changes the subject (which has a very small focus).

> The rest of discussion
> would need disassembly and I'll do it once I'll be waiting for yet =
another
> long run recompile.

:)

BR and thanks,
Nikolaus