Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Message-ID: <7bd53a3ee156037132e85415589168345461ad7c.camel@suse.de>
Subject: Re: [PATCH] usb: xhci-pci: Raspberry Pi FW loader for VIA VL805
From:   Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
To:     Florian Fainelli <f.fainelli@gmail.com>,
        Mathias Nyman <mathias.nyman@intel.com>,
        Ray Jui <rjui@broadcom.com>,
        Scott Branden <sbranden@broadcom.com>,
        bcm-kernel-feedback-list@broadcom.com
Cc:     oneukum@suse.com, phil@raspberrypi.com, tim.gover@raspberrypi.org,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-rpi-kernel@lists.infradead.org,
        linux-arm-kernel@lists.infradead.org
Date:   Mon, 17 Feb 2020 22:19:20 +0100
In-Reply-To: <185f8cae-9898-ee72-00f1-ec79d98c43f4@gmail.com>
References: <20200217100701.19949-1-nsaenzjulienne@suse.de>
         <185f8cae-9898-ee72-00f1-ec79d98c43f4@gmail.com>
Content-Type: multipart/signed; micalg="pgp-sha256";
        protocol="application/pgp-signature"; boundary="=-6v5SE9lBM19zZDAYXHDY"
User-Agent: Evolution 3.34.3 
MIME-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


--=-6v5SE9lBM19zZDAYXHDY
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Mon, 2020-02-17 at 12:52 -0800, Florian Fainelli wrote:
>=20
> On 2/17/2020 2:07 AM, Nicolas Saenz Julienne wrote:
> > On the Raspberry Pi 4, after a PCI reset, VL805's firmware may either b=
e
> > loaded directly from an EEPROM or, if not present, by the SoC's
> > VideCore.  Inform VideCore that VL805 was just reset, or defer xhci's
> > probe if not yet joinable trough the mailbox interface.
> >=20
> > Based on Tim Gover's downstream implementation.
> >=20
> > Signed-off-by: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
>=20
> Would it work if you registered the firmware loading as pci fixup such
> that you would not even have to mangle xhci-pci.c at all and all the
> logic could be contained within drivers/firmware/raspberrypi.c?

Not that simple, PCI fix-ups don't allow for probe deferring. We depend on =
the
firmware and mailbox drivers to be up prior running this, so it's essential=
. We
could cheat and do the deferring first thing during pcie-brcmstb's probe.

Actually this might be a workable solution (as in upstreamable):
 - Wait for firmware to be up in pcie-brcmstb.c
 - Add firmware code in firmware/raspberrypi.c
 - Perform call in usb's quirk_usb_early_handoff() (usb/host/pci-quirks.c)

Regards,
Nicolas


--=-6v5SE9lBM19zZDAYXHDY
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNATURE-----

iQEzBAABCAAdFiEErOkkGDHCg2EbPcGjlfZmHno8x/4FAl5LA1gACgkQlfZmHno8
x/7pOQf/Rc4PUoWjbSaEnRadMhclCH4wKP/YYX30qB8pP4LdbbBhlVyFrL1pYqsA
7SM/sYXSi77ZudG91Qdw0KZQO+8d8R/sC0AliG5qNe0qkc314TwqjAcu90kXkbEF
lvLFkocleihvGcVPjY9LEwk2bPqSY4ScYt/WhrfGIaqvqyJ/ISqliY6HFlbjJfjq
323xSs7Jp0SXjl8h2yOhL0kgV6HS/NTUbwUrW0lRXvZWjDyi0CM1uyxCgUy4EiRC
wsSutseZ95JKX8Sw78dLrE1H0qQel1cAIbZSNb6/lVOvFinq8lKhh+EJVHmAiwOl
7o2HJ9OsjY6Lb4mqgcvoPqFPVl5/tQ==
=bl1/
-----END PGP SIGNATURE-----

--=-6v5SE9lBM19zZDAYXHDY--