Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <CAHk-=wgqwiBLGvwTqU2kJEPNmafPpPe_K0XgBU-A58M+mkwpgQ@mail.gmail.com>
 <158195649797.19707.10238097810752281104@skylake-alporthouse-com>
In-Reply-To: <158195649797.19707.10238097810752281104@skylake-alporthouse-com>
From:   Linus Torvalds <torvalds@linux-foundation.org>
Date:   Mon, 17 Feb 2020 13:20:27 -0800
Message-ID: <CAHk-=wik6C7uCyPZ_qwv0M29uVUdgrpOdubfaVHF8FVBAsCivA@mail.gmail.com>
Subject: Re: Linux 5.6-rc2
To:     Chris Wilson <chris@chris-wilson.co.uk>
Cc:     "Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, Feb 17, 2020 at 8:22 AM Chris Wilson <chris@chris-wilson.co.uk> wrote:
>
> Quoting Linus Torvalds (2020-02-16 21:32:32)
> > Rafael J. Wysocki (4):
> >       ACPI: EC: Fix flushing of pending work
> >       ACPI: PM: s2idle: Avoid possible race related to the EC GPE
> >       ACPICA: Introduce acpi_any_gpe_status_set()
> >       ACPI: PM: s2idle: Prevent spurious SCIs from waking up the system
>
> Our S0 testing broke on all platforms, so we've reverted
> e3728b50cd9b ("ACPI: PM: s2idle: Avoid possible race related to the EC GPE")
> fdde0ff8590b ("ACPI: PM: s2idle: Prevent spurious SCIs from waking up the system")
>
> There wasn't much in the logs, for example,
> https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5445/fi-kbl-7500u/igt@gem_exec_suspend@basic-s0.html

So the machine suspends, but never comes back?

Do you need to revert both for it to work for you? Or is the revert of
fdde0ff8590b just to avoid the conflict?

I'm assuming you bisected this, and the bisect indicated e3728b50cd9b,
and then to revert it you reverted the other commit too..

Or what?

                     Linus