Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Chris Packham <chris.packham@alliedtelesis.co.nz>
To:     jdelvare@suse.com, linux@roeck-us.net, robh+dt@kernel.org,
        mark.rutland@arm.com
Cc:     logan.shaw@alliedtelesis.co.nz, linux-hwmon@vger.kernel.org,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
        Chris Packham <chris.packham@alliedtelesis.co.nz>
Subject: [PATCH 5/5] hwmon: (adt7475) Add support for inverting pwm output
Date:   Tue, 18 Feb 2020 12:46:57 +1300
Message-Id: <20200217234657.9413-6-chris.packham@alliedtelesis.co.nz>
In-Reply-To: <20200217234657.9413-1-chris.packham@alliedtelesis.co.nz>
References: <20200217234657.9413-1-chris.packham@alliedtelesis.co.nz>
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Add a "invert-pwm" device-tree property to allow hardware designs to use
inverted logic on the PWM output. Preserve the invert PWM output bit if
the property is not found to allow for bootloaders/bios which may have
configured this earlier.

Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz>
---
 drivers/hwmon/adt7475.c | 39 +++++++++++++++++++++++++++++++++++++++
 1 file changed, 39 insertions(+)

diff --git a/drivers/hwmon/adt7475.c b/drivers/hwmon/adt7475.c
index 4a62d633a2f5..dccb1c78a57d 100644
--- a/drivers/hwmon/adt7475.c
+++ b/drivers/hwmon/adt7475.c
@@ -1509,6 +1509,41 @@ static int load_attenuators(const struct i2c_clien=
t *client, int chip,
 	return 0;
 }
=20
+static int adt7475_set_pwm_polarity(struct i2c_client *client)
+{
+	char *prop;
+	int ret, i;
+	u8 val;
+
+	for (i =3D 0; i < ADT7475_PWM_COUNT; i++) {
+		ret =3D adt7475_read(PWM_CONFIG_REG(i));
+		if (ret < 0)
+			return ret;
+		val =3D ret;
+		switch (i) {
+		case 0:
+			prop =3D "invert-pwm1";
+			break;
+		case 1:
+			prop =3D "invert-pwm2";
+			break;
+		case 2:
+			prop =3D "invert-pwm3";
+			break;
+		}
+
+		ret =3D set_property_bit(client, prop, &val, 4);
+		if (ret)
+			continue;
+
+		ret =3D i2c_smbus_write_byte_data(client, PWM_CONFIG_REG(i), val);
+		if (ret)
+			return ret;
+	}
+
+	return 0;
+}
+
 static int adt7475_probe(struct i2c_client *client,
 			 const struct i2c_device_id *id)
 {
@@ -1617,6 +1652,10 @@ static int adt7475_probe(struct i2c_client *client=
,
 	for (i =3D 0; i < ADT7475_PWM_COUNT; i++)
 		adt7475_read_pwm(client, i);
=20
+	ret =3D adt7475_set_pwm_polarity(client);
+	if (ret)
+		dev_err(&client->dev, "Error configuring pwm polarity");
+
 	/* Start monitoring */
 	switch (chip) {
 	case adt7475:
--=20
2.25.0