Received: by 2002:a25:1506:0:0:0:0:0 with SMTP id 6csp5301140ybv; Mon, 17 Feb 2020 17:01:40 -0800 (PST) X-Google-Smtp-Source: APXvYqztlaxXdCzefIf+WPaTvJIMaDA3lT3B79xYF1+/TlXwIIKGVvvpL7xBmHeKziqcY9KPvjb0 X-Received: by 2002:a05:6830:1184:: with SMTP id u4mr13466076otq.221.1581987700441; Mon, 17 Feb 2020 17:01:40 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1581987700; cv=none; d=google.com; s=arc-20160816; b=H1OfajFAzHZ7U3fkqESUvfHs3XGsIlakSFIrCiqD6UVDxht5cvsRqLMMjk6mrm3Z55 bD7JfybZEMNjW/Ow82T32AxiFnTzSmhUazLEcxOQ2Nduywb4h+bG9gGyZ+kCGtgSRcHo qbwgggy3BtDA+IFyr00DidCnbf8sqcqdS7vig7GT8KOm5y8xGuxOc1NlHSKpFgYTZLVt S6cbsBuEcZCRq2y0pWJN2FKAHLsKgUR9omUSgMxsPfEDpOfXgZMkCxDSeLyXuxSDM/Tx 7wYP7MesNeXW19QuW0FTKhDwyWABhXE27YXvJv9NylAFOZZzft4VB8ZP/LeScc479D++ 0lTA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dkim-signature; bh=N3Wa2BGzPuFtAt4Hvp1UfThMFJPTB2GMc1k1np2GKU0=; b=HKMi4PSlrGIA3jiX+PVjM3tRFJpBeEUrBvoiyaIS8yC1Wzi5c6RuC78+5QzAZIWnDj 1Q4gamGPd7VS/Q4OX3+AiqAUWhLciMFSsiSg1ClH8gQU3Ase33ziOaEUxBl2+URVMpVy G9hfOTtlTshxIHyNsfyPHMEER8wFr3G2fVmU+riOL8AV2tM3udGC7w07PpKgs5E4O0+k r1QXZYIAwBxAgNWpkDxhCqMIGr0xpCrp467yELBqwt/uB2O+3kX9Gc0Ym2b2hMxpOnxP DuBD3R7CGY6fDU9vOhLJBGTkF9DE8G05uGrId6XZndIE6XFS48gybY9+wwC/QHaP5vzN GgMw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=sfe5YN1O; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u21si6856083oiv.267.2020.02.17.17.01.27; Mon, 17 Feb 2020 17:01:40 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=sfe5YN1O; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726303AbgBRBAS (ORCPT + 99 others); Mon, 17 Feb 2020 20:00:18 -0500 Received: from mail-lj1-f194.google.com ([209.85.208.194]:43093 "EHLO mail-lj1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726054AbgBRBAS (ORCPT ); Mon, 17 Feb 2020 20:00:18 -0500 Received: by mail-lj1-f194.google.com with SMTP id a13so20904726ljm.10; Mon, 17 Feb 2020 17:00:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=N3Wa2BGzPuFtAt4Hvp1UfThMFJPTB2GMc1k1np2GKU0=; b=sfe5YN1OtoDO+kekL/Xz4/fWFMfVhU6pzKL8YOgzJQD3luNHeLeXmr+NtbNbHzHNfl h18FQuBh6ucdum9WYBnUXurSnMOIOo3TblCnfNS/ccQYsk2SJvl1IeNKXGYG07FV6+bR cfi1uJFeJeqzQ38t5O1sa1j1E/kOKKvT8WZ9BP+uIh6Gq3x1u2fO9QvV8hIXnS71uzqV ruveI2mT8tKWW5IvQjlppD2rsCGC9WwkGeVAglKs+Wj7VFhSaIJO2Vsqbh/ZHWcyj4M6 DXJhh7TexQlxvg90SIt8vXVqe14SKpbTmey9+55/e/D4Q4jD4vz+s5if9U/ErQPfoFS1 I7Xg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=N3Wa2BGzPuFtAt4Hvp1UfThMFJPTB2GMc1k1np2GKU0=; b=H/TtYOP1s/PyW3CV+0ajl1LCj2PztoKmhGn0QMK1EJ5+7pn/MT0mEzzzab2TjSUqEm FkIzc5h+B+ess4Q577JgjVQcsdq7mQosHf6DJcoPkCwJUHYEwjUikG47f707o+f8C35H j+FuedvXVuZfm+/SKV+eJFPhs+jnuFjZePYQzWspK0in084WAUjkBFXshFdSiATH26Vs QWFe8rrKLrGUYu8DeybjiyX9rzCQm10tePN3rpeOszEQNfGf0+S2THt3dGAqa7p+/tt9 jDbIbKktE4FBSsqpXSnWODHaEUW7NA9tIV/vpau6/j79Yo0BFeVn/+ONxRZpphmMPFTS OS5w== X-Gm-Message-State: APjAAAVP+/hDd003yMSylQrAJNhhTgvvKKCLy4uTbq2x0TtV0PUhPiao xsTnwwX0GGg10BqL4xh5HoM= X-Received: by 2002:a2e:809a:: with SMTP id i26mr11565660ljg.108.1581987615650; Mon, 17 Feb 2020 17:00:15 -0800 (PST) Received: from [192.168.2.145] (79-139-233-37.dynamic.spd-mgts.ru. [79.139.233.37]) by smtp.googlemail.com with ESMTPSA id u16sm1315815ljl.34.2020.02.17.17.00.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 17 Feb 2020 17:00:14 -0800 (PST) Subject: Re: [alsa-devel] [PATCH 4/9] ASoC: tegra: add Tegra210 based I2S driver To: Jon Hunter , Sameer Pujar Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org, lgirdwood@gmail.com, linux-kernel@vger.kernel.org, broonie@kernel.org, atalambedu@nvidia.com, tiwai@suse.com, viswanathl@nvidia.com, linux-tegra@vger.kernel.org, robh+dt@kernel.org, thierry.reding@gmail.com, sharadg@nvidia.com, rlokhande@nvidia.com, mkumard@nvidia.com, dramesh@nvidia.com References: <1579530198-13431-1-git-send-email-spujar@nvidia.com> <1579530198-13431-5-git-send-email-spujar@nvidia.com> <0c571858-d72c-97c2-2d6a-ead6fdde06eb@nvidia.com> <444731da-c4cd-8578-a732-c803eef31ef0@gmail.com> <598fe377-5b95-d30a-eb64-89a645166d42@gmail.com> <3f51939d-cf4b-f69b-728a-7eb99bbae458@nvidia.com> <34ac1fd3-ae0f-07f2-555f-a55087a2c9dc@nvidia.com> <1a84b393-938f-8bed-d08e-cc3bb6ed4844@gmail.com> <0fc814c2-0dc6-7741-b954-463381ff7fb9@nvidia.com> <9f73afdf-1e9a-cdbd-f972-a022d503ef51@nvidia.com> <264d3354-8a2e-ee12-44ae-aff69213d551@nvidia.com> <075e476a-36bb-5fee-15bc-76af4474a797@gmail.com> <3b42c858-733b-0d17-f457-8043d97f5058@gmail.com> <62b8ffbc-aa32-ae44-6cb4-b176b8ba9b0e@nvidia.com> From: Dmitry Osipenko Message-ID: <847739f8-6f54-cf64-54b8-94707944850b@gmail.com> Date: Tue, 18 Feb 2020 04:00:13 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.3.0 MIME-Version: 1.0 In-Reply-To: <62b8ffbc-aa32-ae44-6cb4-b176b8ba9b0e@nvidia.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 14.02.2020 17:05, Jon Hunter пишет: > > On 29/01/2020 03:41, Dmitry Osipenko wrote: > > ... > >> The !RPM case isn't supported by Tegra anymore in upstream kernel. I'm >> trying to help to make yours driver better and gave you reasons to >> remove the unneeded code, while you're keep saying that "there is no >> harm to retain it", which is not a reason to clutter up the code. I >> don't feel that it's worthwhile to continue arguing here. > > On further review, it does look like a reasonable argument to get rid of > this now completely. Like you see less clutter and the soc-core should > ensure that the card is shutdown before unloading. OK, so fine with me. And the RPM core ensures that state is synced on disable, sorry if I didn't make it clear before. +1 for less clutter :)