Received: by 2002:a25:1506:0:0:0:0:0 with SMTP id 6csp5490929ybv; Mon, 17 Feb 2020 21:37:26 -0800 (PST) X-Google-Smtp-Source: APXvYqzIICOFO6uk9a7o5H37diC7vY80FsH7P6r4GtGS8H5lvgxR7SO3yJF/QjgXusls7r7mDVcQ X-Received: by 2002:a05:6830:606:: with SMTP id w6mr15029319oti.323.1582004246379; Mon, 17 Feb 2020 21:37:26 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1582004246; cv=none; d=google.com; s=arc-20160816; b=YF6x1YSM1gcz6xvXBnaLhqpVOvEWWjJZIJTUjQLOuiehgilr5FDxSPH84iGqAa97CB 8NaNm3fC7UJTf8rqisUvGZp7Ef+mYha8Jry8BiQyQ5nrQ3+OnQ1r76VMoeAoy1MbmDYt /Z0ZSDjPndyyfM0pdY9OIP4d+AIkOEo3m22NzYAJnMIoEIeBFwwd2wYB6nggrLLr+Os6 sA1gpx0WLvF/q1T0W9BXGkd0jjAn6DrDxK5EucNH/CqM472zuzfFhM7W6sbT32D0RLZ/ jNWQ65KRrLY6iLhN4rQqnVcHJ0NwwOEwxmZIavHWvOAtAUEvqupEvjyZGJzafCi7cpuP +ksA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:cc:to:subject :message-id:date:from:in-reply-to:references:mime-version :dkim-signature; bh=HQqzcFnDoi+mJWHn9CYGpZJAJQhhw/tPMZwi/T/g4NM=; b=Fw6/dhTyHLR5+RGVPtvkztnyVamcyDcsaKBqvgMfgBHsnZybft6NnP3Y+tts41kRi5 clFWRbQ9qvsO7i18Tmg/DK72c2Y39a+HQZB2h8hDgl+VZ88HlqfwiSebhZ6JLHO8smwv LgyhVB+ryj5g6qASgnKhbntitjqoVV3QBEzBEwJbKjEwANRe3inFLvwWtlRPkuWpcYsv /PIZMBJPE5htKSaG8jIH3nfiAXFM6bS4DMtKLGAoHlWvS07oS1jMD35HoOKJmUI00vud IJzHGcY5SWRQFUA9hb1A1fIf3YBXUfCX4yyYZuxaxlVtVj0cXVrukcEhKjv44qzI89zC C8YQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=P9FM9oW0; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id b126si7607077oii.72.2020.02.17.21.37.13; Mon, 17 Feb 2020 21:37:26 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=P9FM9oW0; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726105AbgBRFhE (ORCPT + 99 others); Tue, 18 Feb 2020 00:37:04 -0500 Received: from mail-lj1-f195.google.com ([209.85.208.195]:38928 "EHLO mail-lj1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725954AbgBRFhE (ORCPT ); Tue, 18 Feb 2020 00:37:04 -0500 Received: by mail-lj1-f195.google.com with SMTP id o15so21439085ljg.6 for ; Mon, 17 Feb 2020 21:37:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=HQqzcFnDoi+mJWHn9CYGpZJAJQhhw/tPMZwi/T/g4NM=; b=P9FM9oW0/QQsLJRWErjz3Ro5y5GOJlIV78gyDcdDweIynnwcdvnAAnc15dhRt4y7ja +VO6G09pkHoJihWu8qe9H/MUklPe4uNN7jNB29oBWeOkA9ukiI/SHXTQPVnCRFPvYdv1 C1RgulT8ay5w4vjwXl8Q1IcIUpK6BnmlX+niwuwCUQsCEvXJ8P42MLyG1Mru9bgweta6 t6g8w5oAQG+bm0QmQC43FL4QgdGnrq8pDI6d4LaB7jVjW/dvTNOgMyCTNhhuAxoolwU3 xP+XtDqPnVTCScVk1HOq74hd0SHppRtUCaHdNF+7px2b6rjd9pdpDyV4a4bpDiuzJl03 Z7uQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=HQqzcFnDoi+mJWHn9CYGpZJAJQhhw/tPMZwi/T/g4NM=; b=FEwJxgAINSwK/UDG1/lxZlv34PcXtyfQa4I928G6MogqPjgaIYlo3RuZTYuGhWDxgP DSmJZMuVVizqynpT/OPro2EI27H5pLYCZmuyk2DVSPU+jFLopeLZDO6Uy2tMossVf0oT /kiZNDwMn7+AcAcAuyn+iSLdkz290YOD+7aouN8O2BTAGC1qIBnSo8fnfLQLxOAeNeN7 Kk2/+TcNwiLLE/5VWGeBsIVW6TrEc2VTniOAB3UuoVwti521+OtW5zGuwB60gaNEKsEC zzpEofcjzJJ50tFWV7UJ3oMxJWISC562Wcxf5IgHHRXQl3/pfckXprPDsX32TL+gsUSr SiwQ== X-Gm-Message-State: APjAAAUPKKkVpf/l8FYJTdWI6QKCCvBjMMIoiZUSmNmifZlBnGvWRe1c BEr24lpkEeLicNM4vJ56r50hXxQ7vyt2lffihVA+gg== X-Received: by 2002:a2e:5854:: with SMTP id x20mr11130896ljd.287.1582004222420; Mon, 17 Feb 2020 21:37:02 -0800 (PST) MIME-Version: 1.0 References: <9d4f69cd-fb00-6216-5621-fa6d5b42ce19@linaro.org> In-Reply-To: <9d4f69cd-fb00-6216-5621-fa6d5b42ce19@linaro.org> From: Amit Kucheria Date: Tue, 18 Feb 2020 11:06:50 +0530 Message-ID: Subject: Re: [PATCH v4 0/7] thermal: tsens: Handle critical interrupts To: Daniel Lezcano Cc: Linux Kernel Mailing List , linux-arm-msm , Bjorn Andersson , Stephen Boyd , sivaa@codeaurora.org, Andy Gross , Amit Kucheria , Linux PM list Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Daniel, OK. I will address one last comment as part of the rebase. Regards, Amit On Mon, Feb 17, 2020 at 8:55 PM Daniel Lezcano wrote: > > > Hi Amit, > > can you respin the series against v5.6-rc2? > > Thanks > > -- Daniel > > > On 30/01/2020 14:27, Amit Kucheria wrote: > > TSENS IP v2.x supports critical interrupts and v2.3+ adds watchdog supp= ort > > in case the FSM is stuck. Enable support in the driver. > > > > This series was generated on top of linux-next from 20200130 to integra= te > > some patches that that are queued currently. > > > > Changes from v3: > > - Remove the DTS changes that are already queued > > - Fix review comments by Bjorn > > - Fixup patch description to clarify that we don't use TSENS critical > > interrupts in Linux, but need it for the watchdog support that uses t= he > > same HW irq line. > > - Separate kernel-doc fixes into a separate patch. > > > > Changes from v2: > > - Handle old DTBs w/o critical irq in the same way as fix sent for 5.5 > > > > Changes from v1: > > - Make tsens_features non-const to allow run time detection of features > > - Pass tsens_sensor around as a const > > - Fix a bug to release dev pointer in success path > > - Address review comments from Bjorn and Stephen (thanks for the review= ) > > - Add msm8998 and msm8996 DTSI changes for critical interrupts > > > > > > > > Amit Kucheria (7): > > drivers: thermal: tsens: Pass around struct tsens_sensor as a constan= t > > drivers: thermal: tsens: use simpler variables > > drivers: thermal: tsens: Release device in success path > > drivers: thermal: tsens: Add critical interrupt support > > drivers: thermal: tsens: Add watchdog support > > drivers: thermal: tsens: kernel-doc fixup > > drivers: thermal: tsens: Remove unnecessary irq flag > > > > drivers/thermal/qcom/tsens-8960.c | 2 +- > > drivers/thermal/qcom/tsens-common.c | 191 ++++++++++++++++++++++++---- > > drivers/thermal/qcom/tsens-v2.c | 18 ++- > > drivers/thermal/qcom/tsens.c | 26 +++- > > drivers/thermal/qcom/tsens.h | 94 +++++++++++++- > > 5 files changed, 300 insertions(+), 31 deletions(-) > > > > > -- > Linaro.org =E2=94=82 Open source software for A= RM SoCs > > Follow Linaro: Facebook | > Twitter | > Blog >