Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH v4] tools/perf/metricgroup: Fix printing event names of
 metric group with multiple events incase of overlapping events
To:     Jiri Olsa <jolsa@redhat.com>
Cc:     acme@kernel.org, linux-kernel@vger.kernel.org,
        linux-perf-users@vger.kernel.org, Jiri Olsa <jolsa@kernel.org>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Andi Kleen <ak@linux.intel.com>,
        Kan Liang <kan.liang@linux.intel.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Jin Yao <yao.jin@linux.intel.com>,
        Madhavan Srinivasan <maddy@linux.vnet.ibm.com>,
        Anju T Sudhakar <anju@linux.vnet.ibm.com>,
        Ravi Bangoria <ravi.bangoria@linux.ibm.com>
References: <20200212054102.9259-1-kjain@linux.ibm.com>
 <20200216202143.GA145986@krava>
From:   kajoljain <kjain@linux.ibm.com>
Message-ID: <d4ff2f6d-d3c4-a981-db7f-9becec7e51b2@linux.ibm.com>
Date:   Tue, 18 Feb 2020 11:27:08 +0530
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.8.0
MIME-Version: 1.0
In-Reply-To: <20200216202143.GA145986@krava>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


On 2/17/20 1:51 AM, Jiri Olsa wrote:
> On Wed, Feb 12, 2020 at 11:11:02AM +0530, Kajol Jain wrote:
> 
> SNIP
> 
>>  
>>  	return metric_events[0];
>> @@ -160,6 +161,14 @@ static int metricgroup__setup_events(struct list_head *groups,
>>  	int ret = 0;
>>  	struct egroup *eg;
>>  	struct evsel *evsel;
>> +	bool *evlist_used;
>> +
>> +	evlist_used = (bool *)calloc(perf_evlist->core.nr_entries,
>> +				     sizeof(bool));
>> +	if (!evlist_used) {
>> +		ret = -ENOMEM;
>> +		break;
> 
> hum, how did this compile for you? ;-)
> 
> util/metricgroup.c: In function ‘metricgroup__setup_events’:
> util/metricgroup.c:170:3: error: break statement not within loop or switch
>   170 |   break;
> 
> 
Hi jiri,
        Yes you are right. My bad I send patch from other branch. Will send correct one.
Thanks,
Kajol

> jirka
>