Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   =?iso-2022-jp?B?Tk9NVVJBIEpVTklDSEkoGyRCTG5CPCEhPV8wbBsoQik=?= 
        <junichi.nomura@nec.com>
To:     Yian Chen <yian.chen@intel.com>
CC:     "baolu.lu@linux.intel.com" <baolu.lu@linux.intel.com>,
        "sohil.mehta@intel.com" <sohil.mehta@intel.com>,
        "jroedel@suse.de" <jroedel@suse.de>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "iommu@lists.linux-foundation.org" <iommu@lists.linux-foundation.org>
Subject: Re: [PATCH] iommu/vt-d: Check VT-d RMRR region in BIOS is reported as
 reserved
Thread-Topic: [PATCH] iommu/vt-d: Check VT-d RMRR region in BIOS is reported
 as reserved
Thread-Index: AQHV5jVoNSgznqBn6UOgarRl3H2BRA==
Date:   Tue, 18 Feb 2020 08:28:34 +0000
Message-ID: <64a5843d-850d-e58c-4fc2-0a0eeeb656dc@nec.com>
References: <20191015164932.18185-1-yian.chen@intel.com>
In-Reply-To: <20191015164932.18185-1-yian.chen@intel.com>
Accept-Language: ja-JP, en-US
Content-Language: en-US
received-spf: None (protection.outlook.com: nec.com does not designate
 permitted sender hosts)
Content-Type: text/plain; charset="iso-2022-jp"
Content-ID: <363C0F397BEAC24DA9D3E4725D40A776@jpnprd01.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 9e22ea86-92a2-4cf7-8614-08d7b44c8b57
X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Feb 2020 08:28:34.3278
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: e67df547-9d0d-4f4d-9161-51c6ed1f7d11
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: PsvfrNMjDfzKdrLZ9sQ/VlftO5OlBpgplC1fyiHl1jl0P1vic4UX3f8VPBwBvjVpXnRMkVmdipjT+3JDTlMuPA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: TY2PR01MB3580
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi,

On 10/16/19 1:49 AM, Yian Chen wrote:
> VT-d RMRR (Reserved Memory Region Reporting) regions are reserved
> for device use only and should not be part of allocable memory pool of OS=
.
>=20
> BIOS e820_table reports complete memory map to OS, including OS usable
> memory ranges and BIOS reserved memory ranges etc.
>=20
> x86 BIOS may not be trusted to include RMRR regions as reserved type
> of memory in its e820 memory map, hence validate every RMRR entry
> with the e820 memory map to make sure the RMRR regions will not be
> used by OS for any other purposes.

I found "bad RMRR" warnings starting to appear on some x86 servers
since v5.5-rc1 and it gets even louder since v5.6-rc1.  The "bad"
RMRR is for the area resides in ACPI NVS memory region.  For example,

# dmesg|grep RMRR
DMAR: RMRR base: 0x000000a2290000 end: 0x000000a2292fff
DMAR: [Firmware Bug]: No firmware reserved region can cover this RMRR [0x00=
000000a2290000-0x00000000a2292fff], contact BIOS vendor for fixes
Your BIOS is broken; bad RMRR [0x00000000a2290000-0x00000000a2292fff]

# dmesg|grep NVS
BIOS-e820: [mem 0x00000000a067a000-0x00000000a2a79fff] ACPI NVS
reserve setup_data: [mem 0x00000000a067a000-0x00000000a2a79fff] ACPI NVS
PM: Registering ACPI NVS region [mem 0xa067a000-0xa2a79fff] (37748736 bytes=
)

The warnings come from arch_rmrr_sanity_check() since it checks whether
the region is E820_TYPE_RESERVED.  However, if the purpose of the check
is to detect RMRR has regions that may be used by OS as free memory,
isn't E820_TYPE_NVS safe, too?

--=20
Jun'ichi Nomura, NEC Corporation / NEC Solution Innovators, Ltd.=