Received: by 2002:a25:1506:0:0:0:0:0 with SMTP id 6csp5662431ybv; Tue, 18 Feb 2020 01:31:33 -0800 (PST) X-Google-Smtp-Source: APXvYqxoPFcejSt3q/O3um0d1yV9+maNuW9TLJGetzUAN6h+TjCra5hrcKg559fLq3B+l8twiIyn X-Received: by 2002:aca:1c1a:: with SMTP id c26mr654414oic.75.1582018293046; Tue, 18 Feb 2020 01:31:33 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1582018293; cv=none; d=google.com; s=arc-20160816; b=d+Pial2ZNP15IKQ+lgFlrSL80GJm39etEdNkKZv+JH2VNH0lGYbTbSsoDjNCjr3G8T j+6oZN+z8EejIs/CGNcvADk7p2ubhIcweceJ/z11R//bYt+kzAriw4si3w5sC0Tr27aQ wo78t41vtUcnPxtLRSEI91U1uTgnzXtCf7cbE54qGW+mbCprksId0Plen0F+7pfjiNi0 RpBJJq8RkJk+M7wwUd/TktJKTBQVmzmcccZHrcBCdOi0bHGBIGHS+pAI/m7LhVZRPHjz EELD2K75D8M2KtYCIe/86zx1ETdVt5+sM/gpk/oT98HiHsWR5ZV6g0JlXbCPgdGDiKrz Gl4Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dkim-signature; bh=1GbHA/keOvnRptSZJ6pvFppLAhKvfcqxR9KXptl2KxI=; b=cUjedwNRXN1JcCOuAWoNZZP7uZ2idsaiOGv4H2MbdTpM5E7eNG+mABXCGTrxdb214C CVxLciTvFv3KGrH3bKCoJpo6y/ux+KZDi2p4caDW8D73/X5khVow5Ra8EyeL3VEko9Qv ZfWAEsDHqGbbP4LAjrAhTETamI7unm4sjtR8c5eS414wET+mNX4erK4J2ZPQXpauXaDg vFurfDhB5fPY7TSxCnVfnAj6zET/x6f6ghOWpcN9KlrNhJcaDg0NkYs4btdpByV7Yl7F D8NrpubjtZGqeS4CXKgHvOwROrSoCNoghx7LJrYeRQK5m51oOIOItsUwA1vPpTXK4hXf otTA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=T8LhJhjI; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id s16si1435710otq.253.2020.02.18.01.31.19; Tue, 18 Feb 2020 01:31:33 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=T8LhJhjI; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726402AbgBRJbJ (ORCPT + 99 others); Tue, 18 Feb 2020 04:31:09 -0500 Received: from mail-wm1-f65.google.com ([209.85.128.65]:52390 "EHLO mail-wm1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726293AbgBRJbJ (ORCPT ); Tue, 18 Feb 2020 04:31:09 -0500 Received: by mail-wm1-f65.google.com with SMTP id p9so2015264wmc.2 for ; Tue, 18 Feb 2020 01:31:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=1GbHA/keOvnRptSZJ6pvFppLAhKvfcqxR9KXptl2KxI=; b=T8LhJhjIQAbzufPjIBK8TQGYr8JhDvS3dUQls+djP7N+YkzZjaVIcKB2hN3ehPvIJW pbPOhaK2v+SPkH9Ljwr5RqSNNh2QV7DqTnB09WGoy+SiJ83lTX3TmMBeeM5UQpbaFl/6 NQq7RtvKg4MjIdyyHbeRhEl/eeTNLmPkDHaO/1pAJTWBsUOU7dehQPg8BhIgYW99IyPx BLAu4J21I05uaxMeTb1aSHcsm5fK6b8vtMRgUg0/y6uwW/c973K1GqmjLbO10S3E18uQ FZP54ovNcrFCvy41i/0jDveqygwuchBQmcybtAUm9SXBymGgPRXchmWCSCaB0lkzPO4q KFkw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=1GbHA/keOvnRptSZJ6pvFppLAhKvfcqxR9KXptl2KxI=; b=rv6VF+sFx0M4eX5l/tuKKV0wWNHA62UL5ID6lPqbCinqKfrJc+7I06cIihxLBmdd/G HMIPSjj/05IeP3lDSY2+XURK4iQmxjlB0BlIRLfbArFwMhzUZvEmU5k8xL9PtiTNXPqc bLrlKPOHRFc/yLXfXpjWNiFh/8JIC33EZ5s0AVBKp9GgF7XA7TNKLOqtIlBPl6jua58w +0fPkuOUetNfmHc7c5VzZXjy5qRnbwb+HT+ySffBdvSbUD3xUOHXizM4WauBeTWu+ozx eKDqyYBjjbnXwaadj1JMzMM4eq9IH2Y193aF+7OD1vdIz6XorLGc9B4BtO6uuM1L7G46 ESVA== X-Gm-Message-State: APjAAAUUYP6ZSSFDnaw3P4r0CMzI9w+qkpqGzyF7oc8RDmkq2Xf92UF5 ZU3ga8eO1gYKuqhkey+b3sp0Xg== X-Received: by 2002:a7b:c14e:: with SMTP id z14mr2058482wmi.58.1582018266002; Tue, 18 Feb 2020 01:31:06 -0800 (PST) Received: from [192.168.86.34] (cpc89974-aztw32-2-0-cust43.18-1.cable.virginm.net. [86.30.250.44]) by smtp.googlemail.com with ESMTPSA id d22sm2637983wmd.39.2020.02.18.01.31.04 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 18 Feb 2020 01:31:05 -0800 (PST) Subject: Re: [PATCH 2/6] nvmem: fix memory leak in error path To: Bartosz Golaszewski , Linus Walleij , Khouloud Touil Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Bartosz Golaszewski References: <20200217195435.9309-1-brgl@bgdev.pl> <20200217195435.9309-3-brgl@bgdev.pl> From: Srinivas Kandagatla Message-ID: <207251aa-4f0d-18d4-d14f-ed6bc6fe0fed@linaro.org> Date: Tue, 18 Feb 2020 09:31:04 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <20200217195435.9309-3-brgl@bgdev.pl> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 17/02/2020 19:54, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski > > We need to remove the ida mapping when returning from nvmem_register() > with an error. > > Signed-off-by: Bartosz Golaszewski > --- Applied thanks, --srini