Received: by 2002:a25:1506:0:0:0:0:0 with SMTP id 6csp5775497ybv; Tue, 18 Feb 2020 03:45:25 -0800 (PST) X-Google-Smtp-Source: APXvYqxDWKeYmyliCXPa3H3GV0NnhH/Hkm0mweITQdWWEacFlgP+X6kpcFExv8fxdm/yS0dgWc2g X-Received: by 2002:a9d:6e15:: with SMTP id e21mr1877775otr.289.1582026325747; Tue, 18 Feb 2020 03:45:25 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1582026325; cv=none; d=google.com; s=arc-20160816; b=sBBFR7l9x2c4+Egosvn97BHz2EamD40JzayO9TRjWzxe4GZH9HSS6Z02XikqSJBQ66 UrvQpBXHIrfdVjQBKsRe8lde2mls0MSNki7BoLB9EhXnPE3uPSYWBeBD0lrCRaxzyWRO OnYF/ajOeALhexBSTCPLJbS6zXQLuJA+pYDXeKShfNjzGiOE1QKYYWc+jja5pDFElyKA T3KuDM2PpOFHniJaijL3mAVld9P3sXPic82cv+gS/ks47exRlb8lR9aSWTD0yQN8B1A1 6kFBRvC+VA3WCgVawO6sqAqmTGXzp8n9R2BczASd9SRoPVdSXFA0fiAsqblbU7ZtCmlO as9Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dkim-signature; bh=9ODcbuBq0KSowtL9HqLEZNLZuVdpriDI3R3nICsV+FY=; b=ttdMuMjauLMgGyi9AH3F+kagyUqPxLWZhn7G9SMApXCo+WMlIZs7dCOz3abFZ1kF+8 JMmoZrvlbKepXBqRXm7P6CJeVOs+mcDugPzeK5qDvC7TuZkiYQgnmlSm01WvbAMIhCK7 u3qM3jSHWqqQQiIlp4fb6H1qSF4y7MnDMotNp3VoCdNNCtXWG/Q0Rd4V5IsFASAYSh6l jpukK4cJOoNkabkf69XLDcEG354JcZQCeQQwRP5/DFACLw9gbjHpYYEBYVhYEAt6o0ZR okXZkuPUx+Y7byzlg5ZzJZBmD1ACj+wHTswP4yAoDrzRd/+D/BU9SAdr4BlmzlR5Bta6 ensw== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@hanno.de header.s=default1911 header.b=YrBlPiXe; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id r12si1690268otq.156.2020.02.18.03.45.14; Tue, 18 Feb 2020 03:45:25 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@hanno.de header.s=default1911 header.b=YrBlPiXe; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726549AbgBRLot (ORCPT + 99 others); Tue, 18 Feb 2020 06:44:49 -0500 Received: from www149.your-server.de ([78.47.15.70]:44596 "EHLO www149.your-server.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726437AbgBRLos (ORCPT ); Tue, 18 Feb 2020 06:44:48 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=hanno.de; s=default1911; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=9ODcbuBq0KSowtL9HqLEZNLZuVdpriDI3R3nICsV+FY=; b=YrBlPiXeQy59XycF3VGLBZD/jn wEyqzN3Tk6w4NdpKdrzXRouQQgZ8I2odZgQ2yhCSHbDCeh+HzUJ/yal61HWtQdDmnG+tI9cOIVTI0 y84t56B4wvrGs40/J2ZZ5UIxMpDK/1dp5cMhniigep9XTHCovaVkOM5tk0FCKQQXTrPwl1sWU4dGt vCdE4f1tNK3ri6DHOTMkcMXdYZoqjOOYP1a9bnPCFWKfjHvBqDfgPfmYSiWio8nxXRYdVFVR5V7g8 uDTpaZhk2k6+SkUKEtU4q/2U57hxdFd8bbQOK+c8Mr6lI2KnsoaTofTqL2KTOyJzoUZNVc3R5uSkK QeXb2F9A==; Received: from sslproxy03.your-server.de ([88.198.220.132]) by www149.your-server.de with esmtpsa (TLSv1.3:TLS_AES_256_GCM_SHA384:256) (Exim 4.92.3) (envelope-from ) id 1j415R-0002Uw-EP; Tue, 18 Feb 2020 12:30:45 +0100 Received: from [2a04:4540:680e:4300:a894:29ae:bca2:b322] by sslproxy03.your-server.de with esmtpsa (TLSv1.3:TLS_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1j415R-000GFn-B0; Tue, 18 Feb 2020 12:30:45 +0100 Subject: [PATCH v2 0/3] HID: hid-bigbenff: fixing three crash bugs in a gamepad driver To: Benjamin Tissoires Cc: Jiri Kosina , "open list:HID CORE LAYER" , lkml References: From: Hanno Zulla Message-ID: <74d73ebc-0cff-768d-00b7-57bb9b44124f@hanno.de> Date: Tue, 18 Feb 2020 12:30:44 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Authenticated-Sender: kontakt@hanno.de X-Virus-Scanned: Clear (ClamAV 0.102.1/25726/Mon Feb 17 15:01:07 2020) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Benjamin, > I think the patches are correct (have you tested them with actual HW?). Yes, I did, and am also properly embarrassed that I didn't notice the double free bug in the original driver. > However, checkpatch complains that the From and Signed-off-by email > differ. Can you send a v2 with a fix for that? Here it is. Thanks, Hanno