Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Tue, 18 Feb 2020 14:39:43 +0100
From:   Andrew Lunn <andrew@lunn.ch>
To:     Esben Haabendal <esben@geanix.com>
Cc:     netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-kernel@vger.kernel.org,
        "David S . Miller" <davem@davemloft.net>,
        Michal Simek <michal.simek@xilinx.com>,
        Petr =?utf-8?Q?=C5=A0tetiar?= <ynezz@true.cz>
Subject: Re: [PATCH 8/8] net: ll_temac: Add ethtool support for coalesce
 parameters
Message-ID: <20200218133943.GA10541@lunn.ch>
References: <20200218082741.7710-1-esben@geanix.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200218082741.7710-1-esben@geanix.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Esben

> +	if (ec->tx_coalesce_usecs)
> +		lp->coalesce_delay_tx =
> +			min(255U, (ec->tx_coalesce_usecs * 100) / 512);
> +
> +	pr_info("%d -> %d  %d -> %d\n",
> +		ec->rx_coalesce_usecs, lp->coalesce_delay_rx,
> +		ec->tx_coalesce_usecs, lp->coalesce_delay_tx);

I guess this is left over from debug? You don't actually want it here?

  Andrew