Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Tue, 18 Feb 2020 08:22:43 -0600
From:   Bjorn Helgaas <helgaas@kernel.org>
To:     Nicholas Johnson <nicholas.johnson-opensource@outlook.com.au>
Cc:     "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>
Subject: Re: Stack trace when removing Thunderbolt devices while kernel
 shutting down
Message-ID: <20200218142243.GA190321@google.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <PSXP216MB0438220243C0097569D4B2DB80110@PSXP216MB0438.KORP216.PROD.OUTLOOK.COM>
User-Agent: Mutt/1.10.1 (2018-07-13)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, Feb 18, 2020 at 02:18:40PM +0000, Nicholas Johnson wrote:
> Hi Bjorn,
> 
> If I surprise remove Thunderbolt 3 devices just as the kernel is 
> shutting down, I get stack dumps, when those devices would not normally 
> cause stack dumps if the kernel were not shutting down.
> 
> Because the kernel is shutting down, it makes it difficult to capture 
> the logs without a serial console.
> 
> In your mind, is this cause for concern? There is no harm caused and the 
> kernel still shuts down. The main thing I am worried about is if this 
> means that the locking around the subsystem is not strict enough.
> 
> If you think this is worth looking into, I will try to learn about how 
> the native interrupts are handled and try to investigate, and I will 
> also try to get my serial console working again to capture the details.

Yes, I think this is worth looking into.