Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Esben Haabendal <esben@geanix.com>
To:     Andrew Lunn <andrew@lunn.ch>
Cc:     netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-kernel@vger.kernel.org,
        "David S . Miller" <davem@davemloft.net>,
        Michal Simek <michal.simek@xilinx.com>,
        Petr =?utf-8?Q?=C5=A0tetiar?= <ynezz@true.cz>
Subject: Re: [PATCH 8/8] net: ll_temac: Add ethtool support for coalesce parameters
References: <20200218082741.7710-1-esben@geanix.com>
        <20200218133943.GA10541@lunn.ch>
Date:   Tue, 18 Feb 2020 15:28:13 +0100
In-Reply-To: <20200218133943.GA10541@lunn.ch> (Andrew Lunn's message of "Tue,
        18 Feb 2020 14:39:43 +0100")
Message-ID: <87v9o4gebm.fsf@geanix.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Andrew Lunn <andrew@lunn.ch> writes:

> Hi Esben
>
>> +	if (ec->tx_coalesce_usecs)
>> +		lp->coalesce_delay_tx =
>> +			min(255U, (ec->tx_coalesce_usecs * 100) / 512);
>> +
>> +	pr_info("%d -> %d  %d -> %d\n",
>> +		ec->rx_coalesce_usecs, lp->coalesce_delay_rx,
>> +		ec->tx_coalesce_usecs, lp->coalesce_delay_tx);
>
> I guess this is left over from debug? You don't actually want it here?

Yes, I will remove that in v2.  Thanks.

/Esben