Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Tue, 18 Feb 2020 16:12:11 +0100
From:   Peter Zijlstra <peterz@infradead.org>
To:     Valentin Schneider <valentin.schneider@arm.com>
Cc:     Vincent Guittot <vincent.guittot@linaro.org>, mingo@redhat.com,
        juri.lelli@redhat.com, dietmar.eggemann@arm.com,
        rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de,
        linux-kernel@vger.kernel.org, pauld@redhat.com,
        parth@linux.ibm.com, hdanton@sina.com
Subject: Re: [PATCH v2 4/5] sched/pelt: Add a new runnable average signal
Message-ID: <20200218151211.GE14914@hirez.programming.kicks-ass.net>
References: <20200214152729.6059-1-vincent.guittot@linaro.org>
 <20200214152729.6059-5-vincent.guittot@linaro.org>
 <5ea96f6e-433e-1520-56dc-a10e9a8e63c7@arm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <5ea96f6e-433e-1520-56dc-a10e9a8e63c7@arm.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, Feb 18, 2020 at 02:54:40PM +0000, Valentin Schneider wrote:
> Humph, that's an exact copy of update_tg_cfs_util(). FWIW the following
> eldritch horror compiles...
> 

> +#define DECLARE_UPDATE_TG_CFS_SIGNAL(signal)				\
> +static inline void						\
> +update_tg_cfs_##signal(struct cfs_rq *cfs_rq, struct sched_entity *se, struct cfs_rq *gcfs_rq) \
> +{								\
> +	long delta = gcfs_rq->avg.signal##_avg - se->avg.signal##_avg; \
> +								\
> +	/* Nothing to update */					\
> +	if (!delta)						\
> +		return;						\
> +								\
> +	/*									\
> +	 * The relation between sum and avg is:					\
> +	 *									\
> +	 *   LOAD_AVG_MAX - 1024 + sa->period_contrib				\
> +	 *									\
> +		* however, the PELT windows are not aligned between grq and gse.	\
> +	*/									\
> +	/* Set new sched_entity's runnable */			\
> +	se->avg.signal##_avg = gcfs_rq->avg.signal##_avg;	\
> +	se->avg.signal##_sum = se->avg.signal##_avg * LOAD_AVG_MAX; \
> +								\
> +	/* Update parent cfs_rq signal## */			\
> +	add_positive(&cfs_rq->avg.signal##_avg, delta);		\
> +	cfs_rq->avg.signal##_sum = cfs_rq->avg.signal##_avg * LOAD_AVG_MAX; \
> +}								\
>  
> -	/* Update parent cfs_rq runnable */
> -	add_positive(&cfs_rq->avg.runnable_avg, delta);
> -	cfs_rq->avg.runnable_sum = cfs_rq->avg.runnable_avg * LOAD_AVG_MAX;
> -}
> +DECLARE_UPDATE_TG_CFS_SIGNAL(util);
> +DECLARE_UPDATE_TG_CFS_SIGNAL(runnable);

I'm not sure that's actually better though... :-)