Received: by 2002:a25:1506:0:0:0:0:0 with SMTP id 6csp6125483ybv; Tue, 18 Feb 2020 10:23:02 -0800 (PST) X-Google-Smtp-Source: APXvYqy19PHqM9H5whe8kSd2gULSQCw6N9HRzr5e+3+bYmSpqltcmcG6GIF/ZMhsvmOimp9Eoc5C X-Received: by 2002:a05:6808:8ee:: with SMTP id d14mr1999334oic.138.1582050182225; Tue, 18 Feb 2020 10:23:02 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1582050182; cv=none; d=google.com; s=arc-20160816; b=xgeToTnCJWvhCf6j6fhaRlublff+u9rr+Pyqs90cSvLh+tpUKgDAYBXxNIsmo0JLAb VcPF5siKD3ScimxPbyPORKoTz+5eKCjXcxVu9sWn1SaxNtNOwrYcDXEhHawGQy+PGF34 4EexCl0azv26q7T88VdOn5J+6jbSLh/hSi2A8uCCsJ5wiKz0fiSpv8kXYuX8d67ONcn9 4M+tpSJhasca+rH/Ft7ssyonJwTLUIxPNn2h3eh9KM1I1k9UCRpIfyCC4YsuYzi7OHwa WXUDuNX3SLssVK+oS6gaKZb+aIIq8bO6wDSyOdD9GaFaURS9Gk4aTAiPOdTXpy/+fA5c GOQg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dkim-signature; bh=OA/leHKYo8E0m/uN7yH7vLY6aAq5W71bNQ4zaVt1YAQ=; b=gVLTkXpgxvccmSCkiEHvRz7vmKWwTTG1KHp4EEyaa2JpssJ+dNjBntM0t3TN6RCtuP CTJiXY8MDorzzX9lmMT0gEywvZx3TRoDovaU5KaAaBtFac/wOs6DkQKrjhVg5NbLILdU mzPdzD0SDkb09XCihCJ/u60Zyjwe6Dbf5FTusJZVx0HYYAIx3xmBrg2ZgMgtULtmTWDS gEmBrWdBVbAtHOP3j44VUNHdSC9YQPSXWUfpaMDh5VAL3rY29JK0HLEZ0z+ADm+/GAEn tnTa081AAnciuqfXqJXVbug3VJ6iLwS/Q869ZoJ79+q8DVnw8p42t6hZT6hh1WIpYknN 20EA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel-dk.20150623.gappssmtp.com header.s=20150623 header.b=bMT1cl0A; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id j65si1983954otc.308.2020.02.18.10.22.49; Tue, 18 Feb 2020 10:23:02 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel-dk.20150623.gappssmtp.com header.s=20150623 header.b=bMT1cl0A; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726515AbgBRSWb (ORCPT + 99 others); Tue, 18 Feb 2020 13:22:31 -0500 Received: from mail-pf1-f196.google.com ([209.85.210.196]:40866 "EHLO mail-pf1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726380AbgBRSWb (ORCPT ); Tue, 18 Feb 2020 13:22:31 -0500 Received: by mail-pf1-f196.google.com with SMTP id b185so732859pfb.7 for ; Tue, 18 Feb 2020 10:22:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=OA/leHKYo8E0m/uN7yH7vLY6aAq5W71bNQ4zaVt1YAQ=; b=bMT1cl0A50XBAxT6a4EXDbABdH5yjYLfCj2oSh7ERqVMjMGte8z6xGFRiPmZnReT6f mY8lke2SPH9v2LPaUsqOYhqcrQUHbvIOFcGjopFiJRCkkwSh0log+Yw+t6ruk+iKeQ0t 8V6KqTYhrXPnOCi25MDgfNoCKSf9QlNxpgrhxYW0SFA5ZFqforuH6tfDQylWzP2CWx5A gkLsyVItL1ue5rZpakLGyVuHT8IcVioc4BG7rKmEtRB/b2LmkmeWuttDFCSE5kYypbSo g7FcmHE9xLvfxBairPHO+KXf5j0/XeqVwhPgSRlqlfNYVgEewcZWfQWtGnU1TMAgOSN1 7hMg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=OA/leHKYo8E0m/uN7yH7vLY6aAq5W71bNQ4zaVt1YAQ=; b=GwjtSp4yNjLi8CVGYFzK75QoffCA1fyV8YJPnx/QATffbZrsTXojXcmgb8G+Cv8GZ8 H8679Y5FbgDsQ3poUWv5WYRkGLz15cLO/y05q8KBrzW9prKs8EpGXDRSGXrd4sNbhWjn 8hsnfZhYcfQxhl2dkFX+KAa8lOt+vHts37Tld8+ojhEmclP3utxCig9H7caV8eSmX4Rt INlxZx6r9TVQJYp3E4WUITdF6N41lJdfIWqN7RAwKYyzpgvp+z6MUDUa1j0fNqRuFdmN pANKQlLkuOm0vYvrCYltWJuPQ4mnf0K7h+qC4uU4sMd4i4kx9+CwSSAOyM23rkWt+Zi5 e20A== X-Gm-Message-State: APjAAAVX2hA4bqZ8xI3W159ED8UYEB/8t+5KPIlN/jeiWswxGnmbaY3N Ih+utUII92o7DhAboQXy0SMn2w== X-Received: by 2002:aa7:8502:: with SMTP id v2mr21735685pfn.232.1582050150169; Tue, 18 Feb 2020 10:22:30 -0800 (PST) Received: from ?IPv6:2605:e000:100e:8c61:e155:33dd:95af:8080? ([2605:e000:100e:8c61:e155:33dd:95af:8080]) by smtp.gmail.com with ESMTPSA id l26sm5389586pgn.46.2020.02.18.10.22.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 18 Feb 2020 10:22:29 -0800 (PST) Subject: Re: [PATCH] io_uring: remove unnecessary NULL checks To: Dan Carpenter Cc: Alexander Viro , io-uring@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org References: <20200217143945.ua4lawkg22ggfihr@kili.mountain> From: Jens Axboe Message-ID: <93921160-d063-83d3-1064-a70247def2ac@kernel.dk> Date: Tue, 18 Feb 2020 10:22:27 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: <20200217143945.ua4lawkg22ggfihr@kili.mountain> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2/17/20 7:39 AM, Dan Carpenter wrote: > The "kmsg" pointer can't be NULL and we have already dereferenced it so > a check here would be useless. Applied, thanks Dan. -- Jens Axboe