Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH v4 1/3] IMA: Update KBUILD_MODNAME for IMA files to ima
From:   Tushar Sugandhi <tusharsu@linux.microsoft.com>
To:     zohar@linux.ibm.com, joe@perches.com, skhan@linuxfoundation.org,
        linux-integrity@vger.kernel.org
Cc:     sashal@kernel.org, nramas@linux.microsoft.com,
        linux-kernel@vger.kernel.org
References: <20200215014709.3006-1-tusharsu@linux.microsoft.com>
 <20200215014709.3006-2-tusharsu@linux.microsoft.com>
Message-ID: <857c8dc6-d09c-423e-c520-53bb85c6d46c@linux.microsoft.com>
Date:   Tue, 18 Feb 2020 11:25:56 -0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.4.1
MIME-Version: 1.0
In-Reply-To: <20200215014709.3006-2-tusharsu@linux.microsoft.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Mimi,

On 2020-02-14 5:47 p.m., Tushar Sugandhi wrote:
> The kbuild Makefile specifies object files for vmlinux in the $(obj-y)
> lists. These lists depend on the kernel configuration[1].
> 
> The kbuild Makefile for IMA combines the object files for IMA into a
> single object file namely ima.o. All the object files for IMA should be
> combined into ima.o. But certain object files are being added to their
> own $(obj-y). This results in the log messages from those modules getting
> prefixed with their respective base file name, instead of "ima". This is
> inconsistent with the log messages from the IMA modules that are combined
> into ima.o.
> 
> This change fixes the above issue.
> 
> [1] Documentation\kbuild\makefiles.rst
> 
Is there any feedback on this patch description?
I can address it in the next iteration.

Thanks,
Tushar