Received: by 2002:a25:1506:0:0:0:0:0 with SMTP id 6csp6203783ybv; Tue, 18 Feb 2020 11:59:33 -0800 (PST) X-Google-Smtp-Source: APXvYqxvEV2EEAog99tbHS69TlSw9opIpQgRrIGD8kGcF8vofn0jxa972AO8Ws4SxZnbtX8b395c X-Received: by 2002:aca:3354:: with SMTP id z81mr2395569oiz.129.1582055972780; Tue, 18 Feb 2020 11:59:32 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1582055972; cv=none; d=google.com; s=arc-20160816; b=eK/12CoXJeLRVUeE216jxGgfuqbb0zxvK/dYysFTb3m6Dk+a7pdDUJXQWZS7Ibp5fl 2l80qrhKf6NSH4vdpiAU3tO395NHcY+HLzXCJT5zTD5c6lDD4bPvCa8JdYj+3g2N8yHe MK1cZNqfEY6pv7hUumTTch+IvpVZiB1kxwCY9Xv4pcpbYFe53bmaPM2esucBliCBndIc TjvQPrsysONBT2zxNQPjvOtdTvSgxbbObQPQHsYryY7jmcEQ4HtYEkAsjTaeVZ4y889G p79NeJwwH2U+fhWW+esF2hdD0GMo9PPYlxDYr+KTMXlBOPBPEjmXAdvqy9qpFn5jHcae 0D/A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=sCTEEDgI0WEj5AFX33qT2fLXcGgNA2Wuo3L0eygIWUI=; b=SpIBWZKq7x2Ttp2Na04kJ8km8+KDB9sa49j9mzb+jYAnhVFAhaGpwM2Vp354QOz2uk s95mYggHFAbCWOVn9eotirSOKMHxQYPhpEfsBT2T0d5RI7rMH0o+S1Po8y+2GogZPbUd YHeUDA7g6WZPs2vjTVeTyf7gybnNvrYbgA7L+jrFp9iS9fSAkJ4peqCwBn+zl6rBBLUn 9oSCuYZaeJz94Meu5xgnHNVAFYtcCHjU9qQammtOVO/ANf6fY2ioyoge0jJ08mQz0zyw 3u2w66MijoV79wBPqRFxBS8RUEGd0pjXISZGQxeXymV02aRxrJszJD88fYGtLNKls9HX pmfA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=lzJHH1+e; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id k19si2307970otp.33.2020.02.18.11.59.20; Tue, 18 Feb 2020 11:59:32 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=lzJHH1+e; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727785AbgBRT67 (ORCPT + 99 others); Tue, 18 Feb 2020 14:58:59 -0500 Received: from mail.kernel.org ([198.145.29.99]:36894 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728324AbgBRT64 (ORCPT ); Tue, 18 Feb 2020 14:58:56 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id D524320659; Tue, 18 Feb 2020 19:58:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1582055935; bh=QmdDR5zvXy6PIgNyuxthXmWql3YpnD4Coiu30lyUMZg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=lzJHH1+ejCf+/Tc7XqRpp20l0Rd/jqov1XetEG6IhPqjyY9DazpPuklycpcsYOwtG CQCfrKMPBrBUYeGd5uoZMJTYVHoH7dJJyf5sexafXlpRPQ6d0sJ9S+576myuLJWqZg IwP1sPolQegwBIHYr0apSG1cVNHq4rA/+Ok+p/Ps= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Sujith Pandel , David Milburn , Yi Zhang , Keith Busch , Jens Axboe Subject: [PATCH 5.4 37/66] nvme: fix the parameter order for nvme_get_log in nvme_get_fw_slot_info Date: Tue, 18 Feb 2020 20:55:04 +0100 Message-Id: <20200218190431.468890354@linuxfoundation.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200218190428.035153861@linuxfoundation.org> References: <20200218190428.035153861@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Yi Zhang commit f25372ffc3f6c2684b57fb718219137e6ee2b64c upstream. nvme fw-activate operation will get bellow warning log, fix it by update the parameter order [ 113.231513] nvme nvme0: Get FW SLOT INFO log error Fixes: 0e98719b0e4b ("nvme: simplify the API for getting log pages") Reported-by: Sujith Pandel Reviewed-by: David Milburn Signed-off-by: Yi Zhang Signed-off-by: Keith Busch Signed-off-by: Jens Axboe Signed-off-by: Greg Kroah-Hartman --- drivers/nvme/host/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/nvme/host/core.c +++ b/drivers/nvme/host/core.c @@ -3853,7 +3853,7 @@ static void nvme_get_fw_slot_info(struct if (!log) return; - if (nvme_get_log(ctrl, NVME_NSID_ALL, 0, NVME_LOG_FW_SLOT, log, + if (nvme_get_log(ctrl, NVME_NSID_ALL, NVME_LOG_FW_SLOT, 0, log, sizeof(*log), 0)) dev_warn(ctrl->device, "Get FW SLOT INFO log error\n"); kfree(log);