Received: by 2002:a25:1506:0:0:0:0:0 with SMTP id 6csp6210116ybv; Tue, 18 Feb 2020 12:05:28 -0800 (PST) X-Google-Smtp-Source: APXvYqzZ3GnWDpyJrT99CBL0hcLzCj6mp7NTZC5XjWoNP0o7w0gM+kjkYuE0YjqUTWiJ7A9snQeH X-Received: by 2002:a9d:806:: with SMTP id 6mr16298009oty.90.1582056328482; Tue, 18 Feb 2020 12:05:28 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1582056328; cv=none; d=google.com; s=arc-20160816; b=UY3VQ85vWy5wqZ3Hbc7D2Q8+21eCnjg6bcj33wK5zTVKtku7N+0qY5m3ozlzDBbiL+ 26qOiNyt0IVaQedrskAY/UwNkRbnS8Zsr0OoKkd/qQMRyo7P5JbBrt40IK9UaIgviHB0 VsynBTs3LB0+B8OQ3x41mRsVCLQ3or9cf1Gso1ErVLDi5WnZ7sznuAjOc9JIHhgRH4xt uYKmK9PmcmXKRLu3JZqnjXz71BHYkx2/PVwEd5Wcj4ZWhcNWmfSp3qQah25SnEbMt67B o5cjK3smOw1hJNMlOW9QUqw2SLBUxmippyBDZMWMFKQVLVmon2bR3+2WUr0elrR84ePD HoJg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=/d5X5i57SvsrBe+lNFX5E0e5ffrXQawiF9FM5cR9QlA=; b=G7AFtOt9lYbfHgVVfTHMxXXq5ItmBv4EvQWdvyfCPP9xPA5yUfDhg6EjvvGLN/oFzH +ovPC9rCuXKP3haICwMh5Y3P7F6p/vBqSj3dTlamL22vdQ9qRpEqPxbYlkKP8JDvr+zt +qEkUCnizkWA4saxLjIvPat/Q5XyfPLkk5Bc416X8RwX3wfv9UNqTfIEab75cLtybaET JRKEK/HW8gKEO7LeO+dn4CX1HJkfK1ryAZElx3ZoXW4//d/S7ZXEclzuZfu+Mh/mdM4M gJ1q1bxMlL+FPWC6kzeIYG0vWv6nLQUZLaXka41+ka/NB/cj2zNPB9BzsJ6X9zU5OjKH CPPw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=1KAGgf12; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id k66si8260468oih.200.2020.02.18.12.05.16; Tue, 18 Feb 2020 12:05:28 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=1KAGgf12; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728194AbgBRUCK (ORCPT + 99 others); Tue, 18 Feb 2020 15:02:10 -0500 Received: from mail.kernel.org ([198.145.29.99]:42252 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728868AbgBRUCI (ORCPT ); Tue, 18 Feb 2020 15:02:08 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 19EAD24672; Tue, 18 Feb 2020 20:02:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1582056128; bh=l4P5wzIuHe9TK/p1Lf98jBjZh1puwj7i0tmg6bUuEOY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=1KAGgf12SaXVK4xSznOw4AibHrpbL3yEsW4ib0vWP73yfB2SeBjt+ep71j8rmQxwn Ly32Utg8H1ans4bI4sbhkXSj2u+Ei/lygPmj0jPG8nN6HcwZwbFXOeKkexPnm1Za3y w4HQNiO8zZ3M0If/YwQT+KKyz8h7rjEnc1q33zuw= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Sujith Pandel , David Milburn , Yi Zhang , Keith Busch , Jens Axboe Subject: [PATCH 5.5 46/80] nvme: fix the parameter order for nvme_get_log in nvme_get_fw_slot_info Date: Tue, 18 Feb 2020 20:55:07 +0100 Message-Id: <20200218190436.723495694@linuxfoundation.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200218190432.043414522@linuxfoundation.org> References: <20200218190432.043414522@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Yi Zhang commit f25372ffc3f6c2684b57fb718219137e6ee2b64c upstream. nvme fw-activate operation will get bellow warning log, fix it by update the parameter order [ 113.231513] nvme nvme0: Get FW SLOT INFO log error Fixes: 0e98719b0e4b ("nvme: simplify the API for getting log pages") Reported-by: Sujith Pandel Reviewed-by: David Milburn Signed-off-by: Yi Zhang Signed-off-by: Keith Busch Signed-off-by: Jens Axboe Signed-off-by: Greg Kroah-Hartman --- drivers/nvme/host/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/nvme/host/core.c +++ b/drivers/nvme/host/core.c @@ -3867,7 +3867,7 @@ static void nvme_get_fw_slot_info(struct if (!log) return; - if (nvme_get_log(ctrl, NVME_NSID_ALL, 0, NVME_LOG_FW_SLOT, log, + if (nvme_get_log(ctrl, NVME_NSID_ALL, NVME_LOG_FW_SLOT, 0, log, sizeof(*log), 0)) dev_warn(ctrl->device, "Get FW SLOT INFO log error\n"); kfree(log);