Received: by 2002:a25:1506:0:0:0:0:0 with SMTP id 6csp6221119ybv; Tue, 18 Feb 2020 12:17:58 -0800 (PST) X-Google-Smtp-Source: APXvYqzw/I3OEfVwpsBvFU1UWszFW8jqpN3vm82YmmdI+zFbRdp2RXZPDzC0ltqm0Hs0Z5wMPTmE X-Received: by 2002:a05:6808:18:: with SMTP id u24mr2466207oic.10.1582057078125; Tue, 18 Feb 2020 12:17:58 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1582057078; cv=none; d=google.com; s=arc-20160816; b=CyyQhYs4NYxE2lt5thc8nDMsemOQvp7lW//TEd5eMOaoDVpKeD4H+RQuWX4xCAFdRg T2sBo2+ItpGo373OFBOgE9vrL+161iM1/MGFuzU/OzTwdzgIEHn3IZW59lkvz8sZkPoS 5WMlO6bvh9/fdaFW22co7cDRuyLqL2l7OAmkr03PFXCQaC/lQGlQnCSO3QbZ73Q70uoq 0uIUP+oH5qswS5hdRWeAz17iFg8ZZ3ZJujeQ4Mn1yTnTgg2CAXEtBg9OqHUY3H76Q9UJ /VhokG9dcdZ/wQ0jqDMEXMZVA2Fq4ZK5Z+DQqRnaPA7vgVqaiyHdLdorxG/68iuB7Lbl HUgw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:references:cc:to:from:subject:dkim-signature; bh=JbsLBIjey08BbMjYFR6nJwXmiiRgfHCLvVuuHl3uFUI=; b=yHpRXaQou+3fGb/wawIAI3Q/iZtO60g9V77qFUg2MG3oTAgstlqb9Y25hjHo3JmMu+ in3PrQFqGOpGMocF1Ba/yMhoz2TSQgp01eSKU1+cuGAM0CvuablmCv6H66mwYzeG4qLO JzWIwX5gM0x3dklD4EsThyc5NwJ6dIUL8d2VzKeoKTsfd/D5Yg+X00IhL/+/xKAEKvFJ bjZwWBb89K34cPT/a7JW/I+xyanMMza+r3GTzUgKVtJMfv7yrmKMBklfNiP9oCaFA/P5 q4NBrg5+8qxzoaXKM8VOP4H9MffU0Dca7fuwqEywLJKuUbvZMW0pgZeFaLfOse22f6wS dhDg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=Rinj2lVT; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id t11si8342257oih.187.2020.02.18.12.17.45; Tue, 18 Feb 2020 12:17:58 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=Rinj2lVT; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726710AbgBRUQO (ORCPT + 99 others); Tue, 18 Feb 2020 15:16:14 -0500 Received: from mail-wm1-f66.google.com ([209.85.128.66]:38617 "EHLO mail-wm1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726403AbgBRUQN (ORCPT ); Tue, 18 Feb 2020 15:16:13 -0500 Received: by mail-wm1-f66.google.com with SMTP id a9so4329980wmj.3; Tue, 18 Feb 2020 12:16:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:from:to:cc:references:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=JbsLBIjey08BbMjYFR6nJwXmiiRgfHCLvVuuHl3uFUI=; b=Rinj2lVTWNz7/BNm1zAxBIspri2k1m14YWUmAPlw7jt/8CCHBQSR5Dbk/02hp8P6X9 tgJ2kdvS8tG8qqlB0ZjvaayEFISKmKclWsZQkds47pEc4+bKJkZzeeN706uNtH4B03Oe WHJX3/eYAM7VavLRXdpNBS025IBlEkiQVDNQPqD7BAdl2wbNqGpukdIp60clYjW/ugAU Ktq36jx1SiM+3w5TGg3ycKXe+992MGlCeU38o/CP/1ShA4FzOQl0wGxfaOpCN1ZwEs5O LTXU6ytVHGc01+vr7xEX+6UySWu+C1PIyFHJ5Ncj/mtljJMXbyg8py8Rw3G8d7X+yZiS D3AQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:from:to:cc:references:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=JbsLBIjey08BbMjYFR6nJwXmiiRgfHCLvVuuHl3uFUI=; b=GB5zp7M4NB9kR1Lizs29dWVTxla+yOPXt5U+RRw6Rp2GVmSnZyKg7vB4/4sDvIbJIP Q+chRS8KR+FdKrELGnpXrrxSDk0Pgf2HIGs9T35+6exVvpnvquG17hB5Fgu4OOtqpJ2f bdXIj+NGVFa16bYY08yC+tQrsNyCckdQb3396TzgBaRSsQBIzT5fAhZB2DN8Jhtcndlo eF9Px0J+O87rb66PzDImz06VKt5rt0zIGAzbmJ89SQHkT79oO5C+FRu/evPFq+P4DWMk 1EYaAKX/p2vZHzRv20lTh9ew0MwZaIwu0WwJvwSrXIcRnFTqAGBmtLS2+zpnJEylO96Q Ky9g== X-Gm-Message-State: APjAAAX85m8ujm75fgRt8rn8MX5CCOOSOkn8BFVgHdX7OSw5GHZFXGFk F2qtFC1Eq5ub6cAqiiVdO5uelPg9 X-Received: by 2002:a1c:a382:: with SMTP id m124mr4906128wme.90.1582056971147; Tue, 18 Feb 2020 12:16:11 -0800 (PST) Received: from ?IPv6:2003:ea:8f29:6000:5cb0:582f:968:ec00? (p200300EA8F2960005CB0582F0968EC00.dip0.t-ipconnect.de. [2003:ea:8f29:6000:5cb0:582f:968:ec00]) by smtp.googlemail.com with ESMTPSA id f8sm7651895wru.12.2020.02.18.12.16.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 18 Feb 2020 12:16:10 -0800 (PST) Subject: [PATCH net-next v2 03/13] net: atheros: use new helper tcp_v6_gso_csum_prep From: Heiner Kallweit To: David Miller , Jay Cliburn , Chris Snook Cc: "netdev@vger.kernel.org" , Linux Kernel Mailing List References: Message-ID: <45c910c2-36ed-2557-ac35-cb978e44cbf4@gmail.com> Date: Tue, 18 Feb 2020 20:59:55 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Use new helper tcp_v6_gso_csum_prep in additional network drivers. Signed-off-by: Heiner Kallweit --- drivers/net/ethernet/atheros/alx/main.c | 5 +---- drivers/net/ethernet/atheros/atl1c/atl1c_main.c | 6 ++---- 2 files changed, 3 insertions(+), 8 deletions(-) diff --git a/drivers/net/ethernet/atheros/alx/main.c b/drivers/net/ethernet/atheros/alx/main.c index 1dcbc486e..b9b4edb91 100644 --- a/drivers/net/ethernet/atheros/alx/main.c +++ b/drivers/net/ethernet/atheros/alx/main.c @@ -1416,10 +1416,7 @@ static int alx_tso(struct sk_buff *skb, struct alx_txd *first) 0, IPPROTO_TCP, 0); first->word1 |= 1 << TPD_IPV4_SHIFT; } else if (skb_is_gso_v6(skb)) { - ipv6_hdr(skb)->payload_len = 0; - tcp_hdr(skb)->check = ~csum_ipv6_magic(&ipv6_hdr(skb)->saddr, - &ipv6_hdr(skb)->daddr, - 0, IPPROTO_TCP, 0); + tcp_v6_gso_csum_prep(skb); /* LSOv2: the first TPD only provides the packet length */ first->adrl.l.pkt_len = skb->len; first->word1 |= 1 << TPD_LSO_V2_SHIFT; diff --git a/drivers/net/ethernet/atheros/atl1c/atl1c_main.c b/drivers/net/ethernet/atheros/atl1c/atl1c_main.c index 4c0b1f855..0d67b951c 100644 --- a/drivers/net/ethernet/atheros/atl1c/atl1c_main.c +++ b/drivers/net/ethernet/atheros/atl1c/atl1c_main.c @@ -2025,10 +2025,8 @@ static int atl1c_tso_csum(struct atl1c_adapter *adapter, "IPV6 tso with zero data??\n"); goto check_sum; } else - tcp_hdr(skb)->check = ~csum_ipv6_magic( - &ipv6_hdr(skb)->saddr, - &ipv6_hdr(skb)->daddr, - 0, IPPROTO_TCP, 0); + tcp_v6_gso_csum_prep(skb); + etpd->word1 |= 1 << TPD_LSO_EN_SHIFT; etpd->word1 |= 1 << TPD_LSO_VER_SHIFT; etpd->pkt_len = cpu_to_le32(skb->len); -- 2.25.1