Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
From:   Andy Lutomirski <luto@amacapital.net>
Mime-Version: 1.0 (1.0)
Subject: Re: [RFC] #MC mess
Date:   Tue, 18 Feb 2020 15:17:18 -0800
Message-Id: <A3AAF46E-437D-420C-BF0C-C2394B48C9F4@amacapital.net>
References: <20200218200200.GE11457@worktop.programming.kicks-ass.net>
Cc:     "Luck, Tony" <tony.luck@intel.com>, Borislav Petkov <bp@alien8.de>,
        Steven Rostedt <rostedt@goodmis.org>,
        Andy Lutomirski <luto@kernel.org>, x86-ml <x86@kernel.org>,
        lkml <linux-kernel@vger.kernel.org>
In-Reply-To: <20200218200200.GE11457@worktop.programming.kicks-ass.net>
To:     Peter Zijlstra <peterz@infradead.org>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


> On Feb 18, 2020, at 12:02 PM, Peter Zijlstra <peterz@infradead.org> wrote:=

>=20
> =EF=BB=BFOn Tue, Feb 18, 2020 at 06:20:38PM +0000, Luck, Tony wrote:
>>> Anything else I'm missing? It is likely...
>>=20
>> +    hw_breakpoint_disable();
>> +    static_key_disable(&__tracepoint_read_msr.key);
>> +    tracing_off();
>> +
>>    ist_enter(regs);
>>=20
>> How about some code to turn all those back on for a recoverable (where we=
 actually recovered) #MC?
>=20
> Then please rewrite the #MC entry code to deal with nested exceptions
> unmasking the MCE, very similr to NMI.
>=20
> The moment you allow tracing, jump_labels or anything else you can
> expect #PF, #BP and probably #DB while inside #MC, those will then IRET
> and re-enable the #MC.

Huh?  As I understand it, there is no such thing as MCE masking.  There are t=
wo states:

CR4.MCE=3D1: MCE is delivered when it occurs.

CR4.MCE=3D0: MCE causes shutdown

MC delivery sets MCE=3D0.

So, basically, without LMCE, we are irredeemably screwed.  With LMCE, we are=
 still hosed if we nest an MCE inside a recoverable MCE.  We can play some g=
ames to make the OOPS more reliable, but we are still mostly screwed.

The x86 MCE architecture sucks.

>=20
> The current situation is completely and utterly buggered.