Received: by 2002:a25:1506:0:0:0:0:0 with SMTP id 6csp6359972ybv; Tue, 18 Feb 2020 15:25:19 -0800 (PST) X-Google-Smtp-Source: APXvYqy7juL++0B2qx9IXnMw9Hz25sYuB4n7uKywCCUUwgLkaggDEuv+lzqRiOI2043TDkANe3G5 X-Received: by 2002:aca:5fc6:: with SMTP id t189mr3050839oib.166.1582068318935; Tue, 18 Feb 2020 15:25:18 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1582068318; cv=none; d=google.com; s=arc-20160816; b=IjzDNwSPa+3CcQvP2xPCNn5f2jjzbXSwvbQRzEZs4HBuL1rp5X8sj+SN1BRqh3Ese1 +9otveK4Owcj/c6noPf8sSvfg+5T9ib9FgmsxX9EMpBbskN083LN1xSdyPiad7SAJza1 C2Fmewhn1MrA0u3XFJvnK7G91v2JH6sahZMPyz9ILbvI0AQL7HamNlGibFUH1rawOAHH bvlUc0wF+Q6xr7nJlZrf7BVT43moFRgOoA0aicFnAc9HleokwB1iaEBSTpunU7YbGlUB tuViHWoB+M4VtjegoHJQOSblxc7AhnI4qKTJR3n9UnppRWF4nPuyxU1LD2lxRCR0aTOX 9QNg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=tIzAEJsuLi1rhHTq8tVU+ryOfNddGx9piIKavCdaTgI=; b=k+Bh48bDqQhx01HMYnFrgtvYZldhXnDCLdbgi4RgOcBRTFl5CqT5XHt89YUPmj33tp sqvO/l4XlMEZ5WZl9vA3NJA/WEZmRlm4OECE4z8x5IRx3lsgKCSg+PYwOJOUcvHn7Yl/ um1j+9gTIyqCuawf64luou0DA5BWfjo9n2fMf/dVg90XJ9WSIEtuBw9apnTTtLtSqdLO ZJsjsoqOeTp17GQixVE0pegDN7FCNEMBf1Yth8IVfqzZxpSSUorqtyTxXOcNCwhiW1GE 6spcTXWTKGjEbqnQhoo/ZRDhl/8NG4fChncgcbfVYfoa/yTk+yNdkkQTHhqt+hwN58di twVA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="zsp/4FRD"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u25si7927487oic.160.2020.02.18.15.25.05; Tue, 18 Feb 2020 15:25:18 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="zsp/4FRD"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727980AbgBRXYP (ORCPT + 99 others); Tue, 18 Feb 2020 18:24:15 -0500 Received: from mail.kernel.org ([198.145.29.99]:40102 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727930AbgBRXYO (ORCPT ); Tue, 18 Feb 2020 18:24:14 -0500 Received: from localhost (unknown [104.132.1.66]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 1B5F024655; Tue, 18 Feb 2020 23:24:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1582068254; bh=cE1KL7ESu7HCICcE8VORkQLYSFi1c/bNZgc87tvL56Q=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=zsp/4FRD1CWCCkP19KOIGA2baZ6zLP1vyNzO4mvzKrtGjtLqeHFRIYQeEnd2esFwO wbMHNod93deJ4d6Ail3dsW7kuEAu0Sdp0li82EdFJJEEBZHNaUbstYpaYm3H1kKvvn C3m/D9fZth1r/Hq9e3B5rjhKACO4QK2KwIjn63eU= Date: Tue, 18 Feb 2020 15:24:13 -0800 From: Jaegeuk Kim To: Chao Yu Cc: linux-f2fs-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org, chao@kernel.org Subject: Re: [PATCH 3/4] f2fs: clean up lfs/adaptive mount option Message-ID: <20200218232413.GA10213@google.com> References: <20200214094413.12784-1-yuchao0@huawei.com> <20200214094413.12784-3-yuchao0@huawei.com> <20200214184150.GB60913@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/17, Chao Yu wrote: > On 2020/2/15 2:41, Jaegeuk Kim wrote: > >> diff --git a/fs/f2fs/f2fs.h b/fs/f2fs/f2fs.h > >> index 5152e9bf432b..d2d50827772c 100644 > >> --- a/fs/f2fs/f2fs.h > >> +++ b/fs/f2fs/f2fs.h > >> @@ -91,8 +91,6 @@ extern const char *f2fs_fault_name[FAULT_MAX]; > >> #define F2FS_MOUNT_FORCE_FG_GC 0x00004000 > >> #define F2FS_MOUNT_DATA_FLUSH 0x00008000 > >> #define F2FS_MOUNT_FAULT_INJECTION 0x00010000 > >> -#define F2FS_MOUNT_ADAPTIVE 0x00020000 > >> -#define F2FS_MOUNT_LFS 0x00040000 > > > > I don't think we can remove this simply. > > > >> #define F2FS_MOUNT_USRQUOTA 0x00080000 > >> #define F2FS_MOUNT_GRPQUOTA 0x00100000 > >> #define F2FS_MOUNT_PRJQUOTA 0x00200000 > > You mean getting rid of this change or we need to fill F2FS_MOUNT_* hole as below: nvm. So, we can reuse the removed bits later in other features. > > #define F2FS_MOUNT_FAULT_INJECTION 0x00010000 > -#define F2FS_MOUNT_ADAPTIVE 0x00020000 > -#define F2FS_MOUNT_LFS 0x00040000 > +#define F2FS_MOUNT_USRQUOTA 0x00020000 > +#define F2FS_MOUNT_GRPQUOTA 0x00040000 > ... > > Thanks,