Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <CGME20200213123953epcas1p45c39830a9ec6bd535f5370702f603806@epcas1p4.samsung.com>
 <20200213123934.10841-1-dafna.hirschfeld@collabora.com> <a1bc262f-d8af-9590-105b-1db0b16f2861@samsung.com>
In-Reply-To: <a1bc262f-d8af-9590-105b-1db0b16f2861@samsung.com>
From:   Rob Herring <robh+dt@kernel.org>
Date:   Tue, 18 Feb 2020 20:20:22 -0600
Message-ID: <CAL_JsqJvCmwfA7tnyv05McZi+Gh=u8G9Kc2mb-VKbON9TPhKgQ@mail.gmail.com>
Subject: Re: [PATCH v4] dt-bindings: extcon: usbc-cros-ec: convert
 extcon-usbc-cros-ec.txt to yaml format
To:     Chanwoo Choi <cw00.choi@samsung.com>
Cc:     Dafna Hirschfeld <dafna.hirschfeld@collabora.com>,
        devicetree@vger.kernel.org,
        MyungJoo Ham <myungjoo.ham@samsung.com>,
        Mark Rutland <mark.rutland@arm.com>,
        Benson Leung <bleung@chromium.org>,
        Enric Balletbo i Serra <enric.balletbo@collabora.com>,
        Guenter Roeck <groeck@chromium.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Helen Koike <helen.koike@collabora.com>,
        Ezequiel Garcia <ezequiel@collabora.com>,
        Collabora Kernel ML <kernel@collabora.com>, dafna3@gmail.com
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, Feb 17, 2020 at 4:30 AM Chanwoo Choi <cw00.choi@samsung.com> wrote:
>
> On 2/13/20 9:39 PM, Dafna Hirschfeld wrote:
> > convert the binding file extcon-usbc-cros-ec.txt to
> > yaml format extcon-usbc-cros-ec.yaml
> >
> > This was tested and verified on ARM with:
> > make dt_binding_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/extcon/extcon-usbc-cros-ec.yaml
> > make dtbs_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/extcon/extcon-usbc-cros-ec.yaml
> >
> > Signed-off-by: Dafna Hirschfeld <dafna.hirschfeld@collabora.com>
> > Reviewed-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
> > ---
> > Changes since v1:
> > 1 - changing the license to (GPL-2.0-only OR BSD-2-Clause)
> > 2 - changing the maintainers
> > 3 - changing the google,usb-port-id property to have minimum 0 and maximum 255
> >
> > Changes since v2:
> > 1 - Changing the patch subject to start with "dt-bindings: extcon: usbc-cros-ec:"
> > 2 - In the example, adding a parent isp node, a reg field to cros-ec@0
> > and adding nodes 'extcon0/1' instead of one node 'extcon'.
> >
> > Changes since v3:
> > in the example, changing the node isp1 to spi0
> >
> >  .../bindings/extcon/extcon-usbc-cros-ec.txt   | 24 --------
> >  .../bindings/extcon/extcon-usbc-cros-ec.yaml  | 56 +++++++++++++++++++
> >  2 files changed, 56 insertions(+), 24 deletions(-)
> >  delete mode 100644 Documentation/devicetree/bindings/extcon/extcon-usbc-cros-ec.txt
> >  create mode 100644 Documentation/devicetree/bindings/extcon/extcon-usbc-cros-ec.yaml
> >
> > diff --git a/Documentation/devicetree/bindings/extcon/extcon-usbc-cros-ec.txt b/Documentation/devicetree/bindings/extcon/extcon-usbc-cros-ec.txt
> > deleted file mode 100644
> > index 8e8625c00dfa..000000000000
> > --- a/Documentation/devicetree/bindings/extcon/extcon-usbc-cros-ec.txt
> > +++ /dev/null
> > @@ -1,24 +0,0 @@
> > -ChromeOS EC USB Type-C cable and accessories detection
> > -
> > -On ChromeOS systems with USB Type C ports, the ChromeOS Embedded Controller is
> > -able to detect the state of external accessories such as display adapters
> > -or USB devices when said accessories are attached or detached.
> > -
> > -The node for this device must be under a cros-ec node like google,cros-ec-spi
> > -or google,cros-ec-i2c.
> > -
> > -Required properties:
> > -- compatible:                Should be "google,extcon-usbc-cros-ec".
> > -- google,usb-port-id:        Specifies the USB port ID to use.
> > -
> > -Example:
> > -     cros-ec@0 {
> > -             compatible = "google,cros-ec-i2c";
> > -
> > -             ...
> > -
> > -             extcon {
> > -                     compatible = "google,extcon-usbc-cros-ec";
> > -                     google,usb-port-id = <0>;
> > -             };
> > -     }
> > diff --git a/Documentation/devicetree/bindings/extcon/extcon-usbc-cros-ec.yaml b/Documentation/devicetree/bindings/extcon/extcon-usbc-cros-ec.yaml
> > new file mode 100644
> > index 000000000000..9c5849b341ea
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/extcon/extcon-usbc-cros-ec.yaml
> > @@ -0,0 +1,56 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: https://protect2.fireeye.com/url?k=d3c63a24-8e5dc647-d3c7b16b-0cc47a31cdbc-e8d8e2b7806aed8e&u=http://devicetree.org/schemas/extcon/extcon-usbc-cros-ec.yaml#
> > +$schema: https://protect2.fireeye.com/url?k=04f78247-596c7e24-04f60908-0cc47a31cdbc-1b9a3937c161a4b6&u=http://devicetree.org/meta-schemas/core.yaml#

^^^

> > +
> > +title: ChromeOS EC USB Type-C cable and accessories detection
> > +
> > +maintainers:
> > +  - Benson Leung <bleung@chromium.org>
> > +  - Enric Balletbo i Serra <enric.balletbo@collabora.com>
> > +
> > +description: |
> > +  On ChromeOS systems with USB Type C ports, the ChromeOS Embedded Controller is
> > +  able to detect the state of external accessories such as display adapters
> > +  or USB devices when said accessories are attached or detached.
> > +  The node for this device must be under a cros-ec node like google,cros-ec-spi
> > +  or google,cros-ec-i2c.
> > +
> > +properties:
> > +  compatible:
> > +    const: google,extcon-usbc-cros-ec
> > +
> > +  google,usb-port-id:
> > +    allOf:
> > +      - $ref: /schemas/types.yaml#/definitions/uint32
> > +    description: the port id
> > +    minimum: 0
> > +    maximum: 255
> > +
> > +required:
> > +  - compatible
> > +  - google,usb-port-id
> > +
> > +additionalProperties: false
> > +
> > +examples:
> > +  - |
> > +    spi0 {
> > +        #address-cells = <1>;
> > +        #size-cells = <0>;
> > +        cros-ec@0 {
> > +            compatible = "google,cros-ec-spi";
> > +            reg = <0>;
> > +
> > +            usbc_extcon0: extcon0 {
> > +                compatible = "google,extcon-usbc-cros-ec";
> > +                google,usb-port-id = <0>;
> > +            };
> > +
> > +            usbc_extcon1: extcon1 {
> > +                compatible = "google,extcon-usbc-cros-ec";
> > +                google,usb-port-id = <1>;
> > +            };
> > +        };
> > +    };
> >
>
> Applied it. Thanks.

And once again corrupted it when applying it:

Documentation/devicetree/bindings/Makefile:12: recipe for target
'Documentation/devicetree/bindings/extcon/extcon-usbc-cros-ec.example.dts'
failed
Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/jsonschema/validators.py",
line 774, in resolve_from_url
  document = self.store[url]
  File "/usr/local/lib/python3.6/dist-packages/jsonschema/_utils.py",
line 22, in __getitem__
  return self.store[self.normalize(uri)]
KeyError: 'https://protect2.fireeye.com/url?k=04f78247-596c7e24-04f60908-0cc47a31cdbc-1b9a3937c161a4b6&u=http://devicetree.org/meta-schemas/core.yaml'