Received: by 2002:a25:1506:0:0:0:0:0 with SMTP id 6csp132482ybv; Tue, 18 Feb 2020 19:29:06 -0800 (PST) X-Google-Smtp-Source: APXvYqxa4Xu4igaadlSRH7IMKglQVzq9z/+eboqhMDf25B9gOXmuc+6YF7ny/papr6NQscDYsyIk X-Received: by 2002:a9d:6c8d:: with SMTP id c13mr18494985otr.277.1582082946808; Tue, 18 Feb 2020 19:29:06 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1582082946; cv=none; d=google.com; s=arc-20160816; b=W4K0ZOVE2Br1LjPCeViKuFam/sHEDJERQmRG1WrrAmDmPZILtzihxnT/tFajlKRsMn i/twsBHJv0k7w0kovv7ylNW5LlACcDs1U9XXMDGZY9v4SsE2/vQ3BRIUCkT2bv8lvCJ7 7+t1FeEdR9eRuQvauamoXXRjCu/K/OSZi4CNaTtDbvbyRi3Kc4aQQM3tdZlp13uLh3QV nRPnZl9TH13PyyxlvGpNLleUPrXv0xl5KharFOmkSOfHiOTr/S+xj1a6AEYNicNdo/w0 OZGJftwawpf/kcfAD22I795MlgsRq5lS6mSgYFDNtIldoT+A3UHYs39FjkEZzPRyD4oS HrAg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:dkim-signature:content-language :content-transfer-encoding:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject; bh=cyoNazDtmT/h6DgHu5pqneFWToIbbP0fvPs2dxTlGMQ=; b=POTn2q8HJb8VVP3wiIRCdfj71XS6D7gaTJ+on4DbUsuwYnbnHCqJfE+TLYmbJRicGQ LyvVcMwTNEjsdFfrAoc5mFpYGi/sRhUCfST3wvuWhyqwsZSCKuQvL2VQwZtHVSsWrRBH mu/76YU9a0jX7V7TYLCiSCtVDSzenyYmEa99dZ8Xb6HYZFqih9b16XLzb+ZBd+zYHnX1 bEtCfNbyEPFKo3zv+SPJaC0FvsKuXwFOtnngF8jTNE7DW33S6pg5Hh/NVszwIXoLkSeO Mp3hjP//cshngGkaFnKoTqBcHFukiFcDmg2Dd7gvmWYC8QN2ZqZit5k1ZDcpxLOiMLhv 15zQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@nvidia.com header.s=n1 header.b=CdpmAVZE; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id v26si501095otj.0.2020.02.18.19.28.55; Tue, 18 Feb 2020 19:29:06 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@nvidia.com header.s=n1 header.b=CdpmAVZE; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726682AbgBSD2f (ORCPT + 99 others); Tue, 18 Feb 2020 22:28:35 -0500 Received: from hqnvemgate25.nvidia.com ([216.228.121.64]:10618 "EHLO hqnvemgate25.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726346AbgBSD2e (ORCPT ); Tue, 18 Feb 2020 22:28:34 -0500 Received: from hqpgpgate101.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate25.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA) id ; Tue, 18 Feb 2020 19:28:01 -0800 Received: from hqmail.nvidia.com ([172.20.161.6]) by hqpgpgate101.nvidia.com (PGP Universal service); Tue, 18 Feb 2020 19:28:33 -0800 X-PGP-Universal: processed; by hqpgpgate101.nvidia.com on Tue, 18 Feb 2020 19:28:33 -0800 Received: from [10.2.163.58] (10.124.1.5) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Wed, 19 Feb 2020 03:28:32 +0000 Subject: Re: [RFC PATCH v3 3/6] dt-binding: tegra: Add VI and CSI bindings To: Rob Herring CC: , , , , , , , , , , References: <1581704608-31219-1-git-send-email-skomatineni@nvidia.com> <1581704608-31219-4-git-send-email-skomatineni@nvidia.com> <20200218231503.GA19099@bogus> From: Sowjanya Komatineni Message-ID: <5948bf42-9be2-8cf0-1c28-80f69b708c65@nvidia.com> Date: Tue, 18 Feb 2020 19:28:36 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <20200218231503.GA19099@bogus> X-Originating-IP: [10.124.1.5] X-ClientProxiedBy: HQMAIL111.nvidia.com (172.20.187.18) To HQMAIL107.nvidia.com (172.20.187.13) Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1582082881; bh=cyoNazDtmT/h6DgHu5pqneFWToIbbP0fvPs2dxTlGMQ=; h=X-PGP-Universal:Subject:To:CC:References:From:Message-ID:Date: User-Agent:MIME-Version:In-Reply-To:X-Originating-IP: X-ClientProxiedBy:Content-Type:Content-Transfer-Encoding: Content-Language; b=CdpmAVZEN1+rPUXrq9ZTWHWteIUNLSIzWrA/h8Q6AVwCh3Xe4Ldg0Ae3e+GxK7GcY WacUUqIeiFWQEZwv0nLL99pvzd7yUg5NLPubTPS2AdWA9TN8XbQJ5bJzJhlHt8RWiJ 6TtgMMo7qUbLyfXy4x+CGr20WXD3ZKfZtjAwmfiJbSKnFl580R/kSRv7HVRDeRfjs+ DG1NxmOr8BuAAqNiKBcjMuDvb6+c8RLy2qK8dxdArj863jZSvKQewH3SZODclwBXVd vmrRmSBURvYrfXz/xK9kY16Mw5IA3TJfGDN44vMmxj06JQg/J89pX6dCvGDarNLTJx Ln17zs2CfuKFQ== Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2/18/20 3:15 PM, Rob Herring wrote: > External email: Use caution opening links or attachments > > > On Fri, Feb 14, 2020 at 10:23:25AM -0800, Sowjanya Komatineni wrote: >> Tegra contains VI controller which can support up to 6 MIPI CSI >> camera sensors. >> >> Each Tegra CSI port from CSI unit can be one-to-one mapper to >> VI channel and can capture from an external camera sensor or >> from built-in test pattern generator. >> >> This patch adds dt-bindings for Tegra VI and CSI. >> >> Signed-off-by: Sowjanya Komatineni >> --- >> .../display/tegra/nvidia,tegra20-host1x.txt | 55 ++++++++++++++++++---- >> 1 file changed, 47 insertions(+), 8 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/display/tegra/nvidia,tegra20-host1x.txt b/Documentation/devicetree/bindings/display/tegra/nvidia,tegra20-host1x.txt >> index 9999255ac5b6..3d0ed540a646 100644 >> --- a/Documentation/devicetree/bindings/display/tegra/nvidia,tegra20-host1x.txt >> +++ b/Documentation/devicetree/bindings/display/tegra/nvidia,tegra20-host1x.txt >> @@ -40,14 +40,24 @@ of the following host1x client modules: >> >> Required properties: >> - compatible: "nvidia,tegra-vi" >> - - reg: Physical base address and length of the controller's registers. >> + - reg: Physical base address and length of the controller registers. >> - interrupts: The interrupt outputs from the controller. >> - - clocks: Must contain one entry, for the module clock. >> + - clocks: Must contain an entry for the module clock "vi" >> See ../clocks/clock-bindings.txt for details. >> - resets: Must contain an entry for each entry in reset-names. >> See ../reset/reset.txt for details. >> - - reset-names: Must include the following entries: >> - - vi >> + - reset-names: Must include the entry "vi" >> + >> + Tegra210 has CSI part of VI sharing same host interface and register >> + space. So, VI device node should have CSI child node. >> + >> + - csi: mipi csi interface to vi >> + >> + Required properties: >> + - compatible: "nvidia,tegra-csi" >> + - reg: Physical base address and length of the controller registers. >> + - clocks: Must contain entries csi, cilab, cilcd, cile clocks. >> + See ../clocks/clock-bindings.txt for details. >> >> - epp: encoder pre-processor >> >> @@ -310,12 +320,41 @@ Example: >> }; >> >> vi { >> - compatible = "nvidia,tegra20-vi"; >> - reg = <0x54080000 0x00040000>; >> + compatible = "nvidia,tegra210-vi"; >> + reg = <0x0 0x54080000 0x0 0x700>; >> interrupts = <0 69 0x04>; >> - clocks = <&tegra_car TEGRA20_CLK_VI>; >> - resets = <&tegra_car 100>; >> + assigned-clocks = <&tegra_car TEGRA210_CLK_VI>; >> + assigned-clock-parents = <&tegra_car TEGRA210_CLK_PLL_C4_OUT0>; >> + clocks = <&tegra_car TEGRA210_CLK_VI>; >> + clock-names = "vi"; >> + resets = <&tegra_car 20>; >> reset-names = "vi"; >> + >> + #address-cells = <2>; >> + #size-cells = <2>; >> + >> + ranges = <0x0 0x54080808 0x0 0x54080808 0x0 0x2000>; >> + >> + csi@0x54080838 { > Drop '0x' Will fix in v4 > >> + compatible = "nvidia,tegra210-csi"; >> + reg = <0x0 0x54080838 0x0 0x2000>; > Kind of odd that this address and ranges address are not the same. And > also wrong that the size here exceeds the bounds of ranges. > > Also, best practice is to make the child address 0 or relative to the > parent. Actual CSI starts at offset 0x808 but we don't use couple of registers at offset 0x808. Will update ranges in v4 to start from 0x838 offset and will make child address relative to parent. > >> + status = "disabled"; > Don't show status in examples. Will remove. > >> + assigned-clocks = <&tegra_car TEGRA210_CLK_CILAB>, >> + <&tegra_car TEGRA210_CLK_CILCD>, >> + <&tegra_car TEGRA210_CLK_CILE>; >> + assigned-clock-parents = <&tegra_car TEGRA210_CLK_PLL_P>, >> + <&tegra_car TEGRA210_CLK_PLL_P>, >> + <&tegra_car TEGRA210_CLK_PLL_P>; >> + assigned-clock-rates = <102000000>, >> + <102000000>, >> + <102000000>; >> + clocks = <&tegra_car TEGRA210_CLK_CSI>, >> + <&tegra_car TEGRA210_CLK_CILAB>, >> + <&tegra_car TEGRA210_CLK_CILCD>, >> + <&tegra_car TEGRA210_CLK_CILE>; >> + clock-names = "csi", "cilab", "cilcd", "cile"; >> + }; >> + >> }; >> >> epp { >> -- >> 2.7.4 >>