Received: by 2002:a25:1506:0:0:0:0:0 with SMTP id 6csp349420ybv; Wed, 19 Feb 2020 00:43:12 -0800 (PST) X-Google-Smtp-Source: APXvYqwzv/6+D6Y9WD+BLW9j8htwVKLXKBVrMGdC4WX/BcERDdgTQVRFkDftsH0xhprcqhsDlUih X-Received: by 2002:a9d:6a2:: with SMTP id 31mr18441579otx.313.1582101791926; Wed, 19 Feb 2020 00:43:11 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1582101791; cv=none; d=google.com; s=arc-20160816; b=wwofJnme1kEv2YuhQJT/vKxrKOBCZl4V4aNjw4soZR5lXfoYjBbikDkVDeuMZc6YZB s7BP2lJ510lUIV2Ba9UCDOdMc91Q5i2p0LjzwL/lNIttXQ9Kkoq8UyAC575rWqro3tGa jrIJ98L/Pzbiay3gre3qtMYXDHXqOSgVYgA1+aZBFjMP2aR8FhAZo/UICvZ0muYqtveC Q/T85Re+sRCmIkqSMyoj6XAJpCEPW+s8xT30pPIpUW9/rqQPYMssWTRfmTHDm0e6nd60 f/Rs6PPiYh5Fr90zvQHqS9WkInQJnHzizQal+vflf2hyFc1gxePBZDOBghu6yXqCYBKN iOPA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=rEfRYK8X2QQnG43sHHHHoR8YIwfIEm7XxLTlJ/H+Qso=; b=IBrgx/DnQKgexx7Yz3PqJ3vgEFbyymmidkMyUxtiFToeuNx2llrMngVmdV4tDmSXAO a90E+u99FgphH2BtwTKwtUcB/zxMMKR1pRRsj8Upo8lSFwiHY6mG4qdtVWe1yrJgYz9K ujuaHH+biJoiGZ1DMLsv1zi0Z6t5hkAb1dXlRW/DuCP72OTTxp9PNdz8IKSLuXtbuZBo mjpdgpcdc42/5i9Nme0Ixwod75V+nJZLmSH5FpRF7xDwuI+P/YmV5TSEEc2iG5SMay+L yw1ousWAOxJWzVO31uI99O9DQ4Zu40cc9me47Q8liWnLxZGezsa1iwlGc6Cz1mUCWB8L ayKA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=D4fnLH50; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w77si9349113oif.216.2020.02.19.00.42.59; Wed, 19 Feb 2020 00:43:11 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=D4fnLH50; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726680AbgBSIme (ORCPT + 99 others); Wed, 19 Feb 2020 03:42:34 -0500 Received: from mail-pf1-f195.google.com ([209.85.210.195]:41638 "EHLO mail-pf1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727589AbgBSIm3 (ORCPT ); Wed, 19 Feb 2020 03:42:29 -0500 Received: by mail-pf1-f195.google.com with SMTP id j9so12144327pfa.8 for ; Wed, 19 Feb 2020 00:42:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=rEfRYK8X2QQnG43sHHHHoR8YIwfIEm7XxLTlJ/H+Qso=; b=D4fnLH50SoBcu24sBK+TREJyUfMHxXPaZKVeoLfvA5KFxaZ7c68RJNszw2tBFA9Qcp ba+eAmlzeBfOiXE8FiyX0VS/UsLgVA9SF+n+DR06ziu8bljGWCHxbU/czk9XIaQ7Imvj bhlROB8OvWew6mZ/ZxOVoOWi7afsncAZvIcNo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=rEfRYK8X2QQnG43sHHHHoR8YIwfIEm7XxLTlJ/H+Qso=; b=Ka1VMnl84MrQcyowH4IRghsU4uTDgV2H28YNon33vJPSPoGX3OonbcFfVs6tedEWsy m76+wt1BIMLMrDvk+DxxqwOv8kyt6WLiavnFMCA5xbJsimQ8oQ36Ak7KIOc+rzXUWM8D kvWYEcYyKy28s8Ukceur+mDolriDI90UTt98UaRLFhpesLcav4xYi9k8mBkYWMFUWJl2 9YZQzFsQmZun7EXiILsSPk87S1AP4mh2dViFC5urBDdTh4OivAo3qLi5NyQCzUfePxAF evDigYW92yEc9VQr21zbEzzVOt6A2Cu/TZwswMprHykYanTFiKp27Uji+O9ZjTOOOWkW IGrQ== X-Gm-Message-State: APjAAAVj43kMMArV0bHlBrW7DuZB10rSNTVn9lv4iK609uLdHEwFjTob xUtV4tgRoUEz2p+Gcb29wPz1ZA== X-Received: by 2002:aa7:9796:: with SMTP id o22mr25408908pfp.101.1582101748508; Wed, 19 Feb 2020 00:42:28 -0800 (PST) Received: from localhost ([2401:fa00:8f:203:5bbb:c872:f2b1:f53b]) by smtp.gmail.com with ESMTPSA id v25sm1829913pfe.147.2020.02.19.00.42.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 19 Feb 2020 00:42:27 -0800 (PST) Date: Wed, 19 Feb 2020 17:42:26 +0900 From: Sergey Senozhatsky To: Hans Verkuil Cc: Sergey Senozhatsky , Hans Verkuil , Tomasz Figa , Mauro Carvalho Chehab , Kyungmin Park , Marek Szyprowski , Sakari Ailus , Laurent Pinchart , Pawel Osciak , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [RFC][PATCHv2 11/12] videobuf2: add begin/end cpu_access callbacks to dma-sg Message-ID: <20200219084226.GC122464@google.com> References: <20200204025641.218376-1-senozhatsky@chromium.org> <20200204025641.218376-12-senozhatsky@chromium.org> <06d654ec-9d05-4ef5-c27e-ff78c96a3457@xs4all.nl> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <06d654ec-9d05-4ef5-c27e-ff78c96a3457@xs4all.nl> User-Agent: Mutt/1.12.2 (2019-09-21) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On (20/02/19 09:35), Hans Verkuil wrote: > On 2/4/20 3:56 AM, Sergey Senozhatsky wrote: > > Provide begin_cpu_access() and end_cpu_access() dma_buf_ops > > callbacks for cache synchronisation on exported buffers. > > > > V4L2_FLAG_MEMORY_NON_CONSISTENT has no effect on dma-sg buffers. > > dma-sg allocates memory using the page allocator directly, so > > there is no memory consistency guarantee. > > This should also be a comment in the code. OK. -ss