Received: by 2002:a25:1506:0:0:0:0:0 with SMTP id 6csp359608ybv; Wed, 19 Feb 2020 00:58:37 -0800 (PST) X-Google-Smtp-Source: APXvYqyO4QY0vN+BLlkgzGoJMJJuyUCwvxTXLC+rFy64ly3thWxAdcuhAL6DXfOFGDhDBeJbCjsB X-Received: by 2002:a05:6808:b23:: with SMTP id t3mr4053522oij.88.1582102717124; Wed, 19 Feb 2020 00:58:37 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1582102717; cv=none; d=google.com; s=arc-20160816; b=DTUiLOAOrhMHVyxQJGKxtZHGHwO2OcGhl60/k8OVgAt8QN/5hJws6OxsVO5zp71SdD F/xtyBWPVMErUCSVkFKwf6bRBLJuKAz+q9D9nYuzJVbaO1iIjraKVLzbLknlgqvbXijE N+JTUuxPF2AHpTZBz/doAO7fbBs1P1Jy/dFxPUF8SaoU+fDIEvA/derq3X3Yy+njWFMY ABKtkSbx1wdFXSe1x3jSr87g5x9Gqya7KqzHsr7K1L61EImqVJehEII7cSv4imw8CGlq owlBu//LRK7wcBCDtThJegllr4u2DbUMezriQlAnL3yPioFJ5SYuS11ByjNtPho7uxvI HFlQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:in-reply-to :content-disposition:mime-version:references:subject:cc:to:from:date; bh=RctsxtnbXbJEwKPHQfB1ny9ILW9uTbP/Avudwxoe4UY=; b=QGNSezDnuczx+QNMJcq01FsdX9iZ6BJMIaWnAAoRNdb2GEvIUZ9EHH1hx4JFaufdqC vud24bSrem1utsGDdZyNguL1PzmMJxFs2BBjn3PhOF37ledepEH9C+6oK3gE6HPVv9Go y3KQZNYm5ihjMPu1us/tDt8nXmUEcz/VKw+mZXzmR8T2SeA99ZLN5LCvJ/uEJ2UWRArz Uc2ovUYXSIt3RSM4bxs1tSUxcofAdmma5kzKT3Kvcc9MTMxefTZJrP6Ry9mZ4+ME2Szy rq2dEghBbgRIxKG5YlqmalPhiT+lJmB7N52WQhDjHIA3p/AvOUC8cDLYy9t0Y1uSCrQ/ u3xQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id j21si775344oie.210.2020.02.19.00.58.23; Wed, 19 Feb 2020 00:58:37 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726647AbgBSI5P (ORCPT + 99 others); Wed, 19 Feb 2020 03:57:15 -0500 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:15010 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726202AbgBSI5O (ORCPT ); Wed, 19 Feb 2020 03:57:14 -0500 Received: from pps.filterd (m0098396.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 01J8qDlY005937 for ; Wed, 19 Feb 2020 03:57:13 -0500 Received: from e06smtp04.uk.ibm.com (e06smtp04.uk.ibm.com [195.75.94.100]) by mx0a-001b2d01.pphosted.com with ESMTP id 2y8uecu6dy-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Wed, 19 Feb 2020 03:57:13 -0500 Received: from localhost by e06smtp04.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 19 Feb 2020 08:57:11 -0000 Received: from b06cxnps3075.portsmouth.uk.ibm.com (9.149.109.195) by e06smtp04.uk.ibm.com (192.168.101.134) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Wed, 19 Feb 2020 08:57:06 -0000 Received: from d06av22.portsmouth.uk.ibm.com (d06av22.portsmouth.uk.ibm.com [9.149.105.58]) by b06cxnps3075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 01J8v5qr58917114 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 19 Feb 2020 08:57:05 GMT Received: from d06av22.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 8ED074C044; Wed, 19 Feb 2020 08:57:05 +0000 (GMT) Received: from d06av22.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 9E2224C046; Wed, 19 Feb 2020 08:57:02 +0000 (GMT) Received: from linux.ibm.com (unknown [9.148.205.50]) by d06av22.portsmouth.uk.ibm.com (Postfix) with ESMTPS; Wed, 19 Feb 2020 08:57:02 +0000 (GMT) Date: Wed, 19 Feb 2020 09:57:00 +0100 From: Mike Rapoport To: Dan Williams Cc: Baoquan He , Linux Kernel Mailing List , Linux MM , Andrew Morton , Wei Yang , David Hildenbrand , Oscar Salvador , Michal Hocko Subject: Re: [PATCH v2 RESEND] mm/sparsemem: pfn_to_page is not valid yet on SPARSEMEM References: <20200219030454.4844-1-bhe@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-TM-AS-GCONF: 00 x-cbid: 20021908-0016-0000-0000-000002E830E4 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 20021908-0017-0000-0000-0000334B484C Message-Id: <20200219085700.GB32242@linux.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.138,18.0.572 definitions=2020-02-19_02:2020-02-19,2020-02-19 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 priorityscore=1501 mlxscore=0 adultscore=0 lowpriorityscore=0 bulkscore=0 impostorscore=0 phishscore=0 mlxlogscore=891 suspectscore=1 malwarescore=0 clxscore=1015 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2001150001 definitions=main-2002190066 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Feb 18, 2020 at 07:25:15PM -0800, Dan Williams wrote: > On Tue, Feb 18, 2020 at 7:05 PM Baoquan He wrote: > > > > From: Wei Yang > > > > When we use SPARSEMEM instead of SPARSEMEM_VMEMMAP, pfn_to_page() > > doesn't work before sparse_init_one_section() is called. This leads to a > > crash when hotplug memory: > > I'd also add: > > "On x86 the impact is limited to x86_32 builds, or x86_64 > configurations that override the default setting for > SPARSEMEM_VMEMMAP". Do we also want to check how it affects, say, arm64, ia64 and ppc? ;-) > Other than that: > > Reviewed-by: Dan Williams > -- Sincerely yours, Mike.